Bug 182241 - Use document.scrollingElement to access viewport scroll properties in tests
Summary: Use document.scrollingElement to access viewport scroll properties in tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on: 143609
Blocks: 5991 182230
  Show dependency treegraph
 
Reported: 2018-01-29 08:21 PST by Frédéric Wang (:fredw)
Modified: 2018-01-30 08:40 PST (History)
7 users (show)

See Also:


Attachments
Patch (28.35 KB, patch)
2018-01-29 08:26 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.14 MB, application/zip)
2018-01-29 09:56 PST, Build Bot
no flags Details
Patch (29.25 KB, patch)
2018-01-29 10:19 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (29.54 KB, patch)
2018-01-29 11:19 PST, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff
Patch (22.71 KB, patch)
2018-01-30 01:04 PST, Frédéric Wang (:fredw)
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2018-01-29 08:21:32 PST
Use document.scrollingElement to access viewport scroll properties in tests
Comment 1 Frédéric Wang (:fredw) 2018-01-29 08:26:53 PST
Created attachment 332543 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-01-29 08:30:16 PST
The changes to the WPT test is https://github.com/w3c/web-platform-tests/commit/fc33ef7641427a3f1388093c54b24f292c21b34d
Comment 3 Build Bot 2018-01-29 09:56:18 PST
Comment on attachment 332543 [details]
Patch

Attachment 332543 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6249814

New failing tests:
platform/ios/ios/fast/coordinates/inner-window-sizes-quirks.html
Comment 4 Build Bot 2018-01-29 09:56:19 PST
Created attachment 332548 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 5 Frédéric Wang (:fredw) 2018-01-29 10:19:23 PST
Created attachment 332550 [details]
Patch
Comment 6 Frédéric Wang (:fredw) 2018-01-29 11:19:16 PST
Created attachment 332561 [details]
Patch
Comment 7 Frédéric Wang (:fredw) 2018-01-30 01:04:23 PST
Created attachment 332635 [details]
Patch
Comment 8 Frédéric Wang (:fredw) 2018-01-30 01:17:01 PST
Comment on attachment 332561 [details]
Patch

Some of these tests are actually in quirks mode, so I'm not handling them in this bug. I also removed some end-of-file changes.
Comment 9 Frédéric Wang (:fredw) 2018-01-30 05:05:50 PST
Committed r227781: <https://trac.webkit.org/changeset/227781>
Comment 10 Radar WebKit Bug Importer 2018-01-30 05:08:06 PST
<rdar://problem/37025725>