RESOLVED FIXED 180990
[WinCairo] EWS is broken 
https://bugs.webkit.org/show_bug.cgi?id=180990
Summary [WinCairo] EWS is broken
Jonathan Bedard
Reported 2017-12-19 12:37:22 PST
Causing a lot of false-negatives, here are a few examples: https://bugs.webkit.org/show_bug.cgi?id=180555 https://bugs.webkit.org/show_bug.cgi?id=180959
Attachments
Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-12-19 12:42:22 PST
I was seeing breakages when there was a new file added. Fujii suggested core.autocrlf should be false so I went ahead and did that to the bots earlier today. I'll keep monitoring that to see if that helps any.
Don Olmstead
Comment 2 2017-12-19 13:28:51 PST
The other thing I'm seeing is that libpng's version isn't being reported properly in some builds. It seems to think its 1.6.29 despite the header clearly being 1.6.34. I'm not sure why this is happening there as I haven't seen it on our buildbot.
Fujii Hironori
Comment 3 2017-12-19 15:01:10 PST
Did you try to delete CMakeCache.txt? > -- Found ICU data libraries: > CMake Error at C:/tools/cmake/share/cmake-3.9/Modules/FindPackageHandleStandardArgs.cmake:137 (message): > Could NOT find PNG: Found unsuitable version "1.6.29", but required is at > least "1.6.34" (found > C:/WebKit-EWS/WebKit/WebKitLibraries/win/lib64/libpng16.lib)
Don Olmstead
Comment 4 2017-12-19 15:14:18 PST
(In reply to Fujii Hironori from comment #3) > Did you try to delete CMakeCache.txt? > > > -- Found ICU data libraries: > > CMake Error at C:/tools/cmake/share/cmake-3.9/Modules/FindPackageHandleStandardArgs.cmake:137 (message): > > Could NOT find PNG: Found unsuitable version "1.6.29", but required is at > > least "1.6.34" (found > > C:/WebKit-EWS/WebKit/WebKitLibraries/win/lib64/libpng16.lib) The bots should be doing a clean build on each 10 iterations. I also looked at the header files and verified it was a correct version. I'm really not sure what the root cause of it is...
Don Olmstead
Comment 5 2017-12-19 18:34:32 PST
Looking further there is a libpng 1.6.29 within perl's directories. C:\tools\perl\c\include\png.h C:\tools\perl\c\include\libpng16\png.h I'm not sure why EWS would be picking this header up but then finding the library in lib64.
Don Olmstead
Comment 6 2017-12-19 18:49:40 PST
My only thought here is maybe its something to do with https://bugs.webkit.org/show_bug.cgi?id=180137 landing which started detecting perl modules. I'm not sure if that might cause some paths to get added to CMake which would then cause this particular issue.
Don Olmstead
Comment 7 2017-12-19 20:06:22 PST
Its detecting multiple libraries within the perl c directory. I think the fix is to see if within perl there is a c/include directory then we need to use CMAKE_IGNORE_PATH to make sure that nothing appears from there.
Don Olmstead
Comment 8 2017-12-20 15:41:33 PST
Ok there are even more problems... webkit-patch appears to call update-webkit which will invoke update-webkit-auxiliary-libs. This will overwrite what was in WinCairoRequirements.
Don Olmstead
Comment 9 2017-12-21 14:45:59 PST
Ok EWS has had a couple successes after the dependent patches landed. I'm spinning up the other bots for a total of 4 running things. If things look like they've stabilized then I'll close this.
Don Olmstead
Comment 10 2018-01-04 11:32:43 PST
Its been behaving for a few weeks now so hopefully all is resolved.
Note You need to log in before you can comment on or make changes to this bug.