RESOLVED FIXED 181056
[CMake][Win] Add a way to set CMAKE_IGNORE_PATH 
https://bugs.webkit.org/show_bug.cgi?id=181056
Summary [CMake][Win] Add a way to set CMAKE_IGNORE_PATH
Don Olmstead
Reported 2017-12-20 14:18:29 PST
WinCairo EWS is detecting copies of libpng, libjpeg, and other dependencies of WebKit within Strawberry Perl's distribution. This is preventing EWS from functioning properly. Within CMake the variable CMAKE_IGNORE_PATH can be used to prevent CMake from searching paths. So providing a way to set this seems to be the correct approach.
Attachments
Patch (942 bytes, patch)
2017-12-20 14:30 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-12-20 14:30:55 PST
Created attachment 329954 [details] Patch Added WEBKIT_IGNORE_PATH as a way to set things within a windows build
Don Olmstead
Comment 2 2017-12-20 18:08:09 PST
Ok I tested this within a container that WinCairo's EWS is using and it will end up ignoring the directories specified in the environment variable. Would like to get this landed before spinning back up the EWS bots.
Konstantin Tokarev
Comment 3 2017-12-20 19:16:37 PST
Comment on attachment 329954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329954&action=review > Source/cmake/OptionsWin.cmake:94 > + set(CMAKE_IGNORE_PATH $ENV{WEBKIT_IGNORE_PATH}) Huh, I didn't know such variable exists :)
WebKit Commit Bot
Comment 4 2017-12-20 19:39:52 PST
Comment on attachment 329954 [details] Patch Clearing flags on attachment: 329954 Committed r226212: <https://trac.webkit.org/changeset/226212>
WebKit Commit Bot
Comment 5 2017-12-20 19:39:54 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-12-20 19:40:26 PST
<rdar://problem/36170547>
Note You need to log in before you can comment on or make changes to this bug.