RESOLVED FIXED 181065
[AppleWin] Auxiliary libraries should be updated within build-webkit 
https://bugs.webkit.org/show_bug.cgi?id=181065
Summary [AppleWin] Auxiliary libraries should be updated within build-webkit
Don Olmstead
Reported 2017-12-20 16:29:59 PST
Currently all ports are updating their own auxiliary libraries within the context of build-webkit with the exception of AppleWin which uses update-webkit. This should be moved into build-webkit for consistency. This also causes a problem with webkit-patch when developing on WinCairo. WinCairo has its own set of requirements and when update-webkit is called by webkit-patch it will act as though the port is AppleWin and download the auxiliary library zip and overwrite what is present in WinCairoRequirements. This makes the build fail within EWS.
Attachments
Patch (3.26 KB, patch)
2017-12-20 16:31 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-12-20 16:31:52 PST
Created attachment 329963 [details] Patch Removes update-auxiliary-libs from update-webkit and into build-webkit.
WebKit Commit Bot
Comment 2 2017-12-21 11:13:44 PST
Comment on attachment 329963 [details] Patch Clearing flags on attachment: 329963 Committed r226232: <https://trac.webkit.org/changeset/226232>
WebKit Commit Bot
Comment 3 2017-12-21 11:13:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-12-21 11:15:59 PST
<rdar://problem/36181856>
Note You need to log in before you can comment on or make changes to this bug.