Bug 181065 - [AppleWin] Auxiliary libraries should be updated within build-webkit
Summary: [AppleWin] Auxiliary libraries should be updated within build-webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks: 180990
  Show dependency tree / graph
 
Reported: 2017-12-20 16:29 PST by Don Olmstead
Modified: 2017-12-21 11:15 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2017-12-20 16:31 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-12-20 16:29:59 PST 
Currently all ports are updating their own auxiliary libraries within the context of build-webkit with the exception of AppleWin which uses update-webkit. This should be moved into build-webkit for consistency.

This also causes a problem with webkit-patch when developing on WinCairo. WinCairo has its own set of requirements and when update-webkit is called by webkit-patch it will act as though the port is AppleWin and download the auxiliary library zip and overwrite what is present in WinCairoRequirements. This makes the build fail within EWS.
Comment 1 Don Olmstead 2017-12-20 16:31:52 PST 
Created attachment 329963 [details]
Patch

Removes update-auxiliary-libs from update-webkit and into build-webkit.
Comment 2 WebKit Commit Bot 2017-12-21 11:13:44 PST 
Comment on attachment 329963 [details]
Patch

Clearing flags on attachment: 329963

Committed r226232: <https://trac.webkit.org/changeset/226232>
Comment 3 WebKit Commit Bot 2017-12-21 11:13:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-12-21 11:15:59 PST 
<rdar://problem/36181856>