Bug 180984 – Implement InlineTextBox painting using marker subranges

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Daniel Bates]

As a step towards fixing bug #175784, we should write the InlineTextBox painting code in terms of MarkerSubrange instances.

[Daniel Bates]

Created attachment 329779 [details]
Patch

[EWS Watchlist]

Attachment 329779 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/InlineTextBox.cpp:554:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 329779 [details]
Patch

Attachment 329779 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5756107

New failing tests:
fast/mediastream/MediaStream-MediaElement-setObject-null.html

[EWS Watchlist]

Created attachment 329797 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Daniel Bates]

(In reply to Build Bot from comment #4)
> Created attachment 329797 [details]
> Archive of layout-test-results from ews105 for mac-elcapitan-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-wk2-ews.
> Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

This test failure is not caused by this patch. The same test fails for the no-op patch on bug #180985.

[Dave Hyatt]

Comment on attachment 329779 [details]
Patch

r=me

[Radar WebKit Bug Importer]

<rdar://problem/36139364>

[Daniel Bates]

Committed r226138: <https://trac.webkit.org/changeset/226138>

[Carlos Alberto Lopez Perez]

(In reply to Daniel Bates from comment #8)
> Committed r226138: <https://trac.webkit.org/changeset/226138>

It seems this broke the build for me (Linux/GTK port, Clang compiler):

In file included from /home/clopez/webkit/webkit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource383.cpp:7:
../../Source/WebCore/rendering/InlineTextBox.cpp:852:13: error: fallthrough annotation does not directly precede switch label
            FALLTHROUGH;
            ^
../../Source/WTF/wtf/Compiler.h:196:21: note: expanded from macro 'FALLTHROUGH'
#define FALLTHROUGH [[fallthrough]]
                    ^
1 error generated.

I'm landing a build fix by moving the FALLTHROUGH inside ENABLE(TELEPHONE_NUMBER_DETECTION)

[Carlos Alberto Lopez Perez]

Committed r226174: <https://trac.webkit.org/changeset/226174>