RESOLVED FIXED 180985
Add support for computing the frontmost longest effective marker subrange 
https://bugs.webkit.org/show_bug.cgi?id=180985
Summary Add support for computing the frontmost longest effective marker subrange
Daniel Bates
Reported 2017-12-19 11:47:13 PST
Add support for computing the frontmost longest effective marker subrange. This will allow us to minimize the number of drawing commands needed to paint the currently selected text on a page when using MarkerSubrange instances for such painting. Currently the text selection painting code does not make use of MarkerSubrange instances and implements this optimization. We want to write the text selection painting code in terms of MarkerSubrange (bug #180984) to make it straightforward to support all of the style options afforded to the pseudo element ::selection. We should keep this optimization when migrating the text selection painting code to use MarkerSubrange instances.
Attachments
Patch and unit test (7.31 KB, patch)
2017-12-19 11:48 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch and unit test (8.58 KB, patch)
2017-12-19 11:57 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch and unit test (8.58 KB, patch)
2017-12-19 11:59 PST, Daniel Bates 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-12-19 11:48:53 PST
Created attachment 329782 [details] Patch and unit test
Daniel Bates
Comment 2 2017-12-19 11:57:24 PST
Created attachment 329783 [details] Patch and unit test
Daniel Bates
Comment 3 2017-12-19 11:59:18 PST
Created attachment 329784 [details] Patch and unit test
Dave Hyatt
Comment 4 2017-12-19 13:12:59 PST
Comment on attachment 329784 [details] Patch and unit test View in context: https://bugs.webkit.org/attachment.cgi?id=329784&action=review r=me > Source/WebCore/ChangeLog:12 > + of drawing commands needed to paint an entire line of text. We are not making this of > + this functionality now. We will make use of it to simplify the patch for <https://bugs.webkit.org/show_bug.cgi?id=180984>. Typo, "We are not making use of this functionality now."
Daniel Bates
Comment 5 2017-12-19 13:27:37 PST
(In reply to Dave Hyatt from comment #4) > > Source/WebCore/ChangeLog:12 > > + of drawing commands needed to paint an entire line of text. We are not making this of > > + this functionality now. We will make use of it to simplify the patch for <https://bugs.webkit.org/show_bug.cgi?id=180984>. > > Typo, "We are not making use of this functionality now." Will fix before landing.
Daniel Bates
Comment 6 2017-12-19 13:28:43 PST
Committed r226137: <https://trac.webkit.org/changeset/226137>
Radar WebKit Bug Importer
Comment 7 2017-12-19 13:29:23 PST
<rdar://problem/36139345>
Note You need to log in before you can comment on or make changes to this bug.