Bug 175784 - [css-pseudo-4] Implement ::spelling-error and ::grammar-error
Summary: [css-pseudo-4] Implement ::spelling-error and ::grammar-error
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: WebExposed
Depends on: 141774 178232 191040 177265 177490 177493 177882 180984
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-21 14:27 PDT by Daniel Bates
Modified: 2018-10-29 16:55 PDT (History)
5 users (show)

See Also:


Attachments
Work-in-progress (32.31 KB, patch)
2017-08-21 14:29 PDT, Daniel Bates
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.24 MB, application/zip)
2017-08-21 15:55 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews101 for mac-elcapitan (1.11 MB, application/zip)
2017-08-21 15:57 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.90 MB, application/zip)
2017-08-21 16:01 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (1.07 MB, application/zip)
2017-08-21 16:21 PDT, Build Bot
no flags Details
Work-in-progress patch (88.35 KB, patch)
2017-09-05 09:40 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Work-in-progress patch (74.54 KB, patch)
2018-03-19 11:50 PDT, Daniel Bates
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (13.10 MB, application/zip)
2018-04-02 14:27 PDT, EWS Watchlist
no flags Details
Work-in-progress patch (76.38 KB, patch)
2018-08-10 14:31 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Simple test (501 bytes, text/html)
2018-08-10 14:36 PDT, Daniel Bates
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-08-21 14:27:37 PDT
Implement pseudo elements spelling-error and grammar-error from <https://drafts.csswg.org/css-pseudo-4/> to allow a person to stylize the appearance of spelling and grammar errors, respectively.
Comment 1 Daniel Bates 2017-08-21 14:29:51 PDT
Created attachment 318674 [details]
Work-in-progress
Comment 2 Build Bot 2017-08-21 15:55:01 PDT Comment hidden (obsolete)
Comment 3 Build Bot 2017-08-21 15:55:02 PDT Comment hidden (obsolete)
Comment 4 Build Bot 2017-08-21 15:57:37 PDT Comment hidden (obsolete)
Comment 5 Build Bot 2017-08-21 15:57:38 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2017-08-21 16:01:03 PDT Comment hidden (obsolete)
Comment 7 Build Bot 2017-08-21 16:01:05 PDT Comment hidden (obsolete)
Comment 8 Build Bot 2017-08-21 16:21:43 PDT Comment hidden (obsolete)
Comment 9 Build Bot 2017-08-21 16:21:45 PDT Comment hidden (obsolete)
Comment 10 Daniel Bates 2017-09-05 09:40:12 PDT
Created attachment 319907 [details]
Work-in-progress patch

The painting approach in this patch is wrong. We need to account for spelling and grammar errors that can overlap. This is demonstrated by the failure of the included test LayoutTests/fast/css/spelling-and-grammar-errors-overlap.html.
Comment 11 Daniel Bates 2018-03-19 11:50:54 PDT
Created attachment 336064 [details]
Work-in-progress patch
Comment 12 EWS Watchlist 2018-03-19 11:52:47 PDT
Attachment 336064 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/InlineTextBox.cpp:575:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/rendering/InlineTextBox.cpp:665:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/rendering/InlineTextBox.cpp:667:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 EWS Watchlist 2018-04-02 14:27:22 PDT
Comment on attachment 336064 [details]
Work-in-progress patch

Attachment 336064 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7182260

New failing tests:
fast/selectors/text-field-selection-stroke-color.html
fast/css/spelling-and-grammar-error-pseudo-elements-appearance.html
http/wpt/css/css-pseudo-4/spelling-error-001.html
fast/css/grammar-error-pseudo-element.html
fast/css/spelling-and-grammar-error-pseudo-elements-vertical-appearance.html
fast/css/paint-non-misspelled-text-between-spelling-errors-when-text-wraps.html
imported/blink/svg/text/selection-partial-gradient.html
fast/css/spelling-and-grammar-error-pseudo-elements-cursor.html
fast/css/spelling-and-grammar-errors-overlap.html
Comment 14 EWS Watchlist 2018-04-02 14:27:35 PDT
Created attachment 337030 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 15 Daniel Bates 2018-08-10 14:31:54 PDT
Created attachment 346924 [details]
Work-in-progress patch

Rebased patch and wired it up so that we paint background and decorations for spelling errors and grammar errors. I need to fix up the style computation so that styles are collected with respect to intersecting pseudo elements.
Comment 16 Daniel Bates 2018-08-10 14:36:47 PDT
Created attachment 346925 [details]
Simple test