Bug 175784 – [css-pseudo-4] Implement ::spelling-error and ::grammar-error

• Status: ASSIGNED
• Component: CSS

[Daniel Bates]

Implement pseudo elements spelling-error and grammar-error from <https://drafts.csswg.org/css-pseudo-4/> to allow a person to stylize the appearance of spelling and grammar errors, respectively.

[Daniel Bates]

Created attachment 318674 [details]
Work-in-progress

[Build Bot]

Comment on attachment 318674 [details]
Work-in-progress

Attachment 318674 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4355959

New failing tests:
imported/blink/fast/css/viewport-percentage-compute-with-scrollbars.html
media/track/track-css-property-whitelist.html

[Build Bot]

Created attachment 318681 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 318674 [details]
Work-in-progress

Attachment 318674 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4355987

New failing tests:
imported/blink/fast/css/viewport-percentage-compute-with-scrollbars.html
media/track/track-css-property-whitelist.html

[Build Bot]

Created attachment 318682 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 318674 [details]
Work-in-progress

Attachment 318674 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4355962

New failing tests:
imported/blink/fast/css/viewport-percentage-compute-with-scrollbars.html
media/track/track-css-property-whitelist.html

[Build Bot]

Created attachment 318683 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 318674 [details]
Work-in-progress

Attachment 318674 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4355990

New failing tests:
imported/blink/fast/css/viewport-percentage-compute-with-scrollbars.html
media/track/track-css-property-whitelist.html

[Build Bot]

Created attachment 318689 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Daniel Bates]

Created attachment 319907 [details]
Work-in-progress patch

The painting approach in this patch is wrong. We need to account for spelling and grammar errors that can overlap. This is demonstrated by the failure of the included test LayoutTests/fast/css/spelling-and-grammar-errors-overlap.html.

[Daniel Bates]

Created attachment 336064 [details]
Work-in-progress patch

[EWS Watchlist]

Attachment 336064 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/InlineTextBox.cpp:575:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/rendering/InlineTextBox.cpp:665:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/rendering/InlineTextBox.cpp:667:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 336064 [details]
Work-in-progress patch

Attachment 336064 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7182260

New failing tests:
fast/selectors/text-field-selection-stroke-color.html
fast/css/spelling-and-grammar-error-pseudo-elements-appearance.html
http/wpt/css/css-pseudo-4/spelling-error-001.html
fast/css/grammar-error-pseudo-element.html
fast/css/spelling-and-grammar-error-pseudo-elements-vertical-appearance.html
fast/css/paint-non-misspelled-text-between-spelling-errors-when-text-wraps.html
imported/blink/svg/text/selection-partial-gradient.html
fast/css/spelling-and-grammar-error-pseudo-elements-cursor.html
fast/css/spelling-and-grammar-errors-overlap.html

[EWS Watchlist]

Created attachment 337030 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Daniel Bates]

Created attachment 346924 [details]
Work-in-progress patch

Rebased patch and wired it up so that we paint background and decorations for spelling errors and grammar errors. I need to fix up the style computation so that styles are collected with respect to intersecting pseudo elements.

[Daniel Bates]

Created attachment 346925 [details]
Simple test