Bug 179471 – REGRESSION(r224566): [GTK] 26 new timeouts on inspector related tests.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Alberto Lopez Perez]

Revision r224566 <https://trac.webkit.org/r224566> caused ~26 unexpected inspector related test timeouts

Regressions: Unexpected timeouts (26)
  inspector/console/console-message.html [ Timeout ]
  inspector/console/console-time.html [ Timeout ]
  inspector/console/heapSnapshot.html [ Timeout ]
  inspector/console/js-source-locations.html [ Timeout ]
  inspector/console/x-frame-options-message.html [ Timeout ]
  inspector/heap/tracking.html [ Timeout ]
  inspector/layers/layers-anonymous.html [ Timeout ]
  inspector/layers/layers-blending-compositing-reasons.html [ Timeout ]
  inspector/layers/layers-compositing-reasons.html [ Timeout ]
  inspector/layers/layers-for-node.html [ Timeout ]
  inspector/layers/layers-generated-content.html [ Timeout ]
  inspector/layers/layers-reflected-content.html [ Timeout ]
  inspector/memory/tracking.html [ Timeout ]
  inspector/page/media-query-list-listener-exception.html [ Timeout ]
  inspector/protocol/backend-dispatcher-argument-errors.html [ Timeout ]
  inspector/protocol/backend-dispatcher-malformed-message-errors.html [ Timeout ]
  inspector/runtime/CommandLineAPI-inspect.html [ Timeout ]
  inspector/script-profiler/event-type-API.html [ Timeout ]
  inspector/script-profiler/event-type-Microtask.html [ Timeout ]
  inspector/script-profiler/event-type-Other.html [ Timeout ]
  inspector/script-profiler/tracking.html [ Timeout ]
  inspector/unit-tests/async-test-suite.html [ Timeout ]
  inspector/unit-tests/protocol-test-dispatch-event-to-frontend.html [ Timeout ]
  inspector/unit-tests/sync-test-suite.html [ Timeout ]
  inspector/worker/worker-create-and-terminate.html [ Timeout ]
  inspector/worker/worker-recover-if-inspector-close.html [ Timeout ]


I have double checked this by reverting r224566 locally (this test pass with this reverted)

[Carlos Garcia Campos]

Created attachment 326568 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 326568 [details]
Patch

From my un-expertise on the webinspector, the patch looks fine ...
However I wonder why this (as well as bug 179419 which was fixed with a very similar patch) is not happening on the Mac port??? It will be helpful if someone with more expertise in this code can review it.

[Blaze Burg]

Comment on attachment 326568 [details]
Patch

r=me as well, I'm not sure that TestStub was minified before for Mac, but I guess there is no harm in it.

[Carlos Garcia Campos]

Committed r224745: <https://trac.webkit.org/changeset/224745>