Bug 179317 - [GTK][WPE] Build inspector resources using copy-user-interface-resources.pl script
Summary: [GTK][WPE] Build inspector resources using copy-user-interface-resources.pl s...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on: 179471
  Show dependency treegraph
Reported: 2017-11-06 06:06 PST by Carlos Garcia Campos
Modified: 2017-12-06 09:40 PST (History)
3 users (show)

See Also:

Patch (22.86 KB, patch)
2017-11-06 06:11 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch (25.37 KB, patch)
2017-11-07 04:50 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-11-06 06:06:32 PST
This is the script used by Apple and it has several advantages:

 - It allows to combine and minify most of the js and css files, which improves performance and binary size.
 - It removes the debug resources and assertions in production builds.
 - It allows to remove the test resources in production builds.
Comment 1 Carlos Garcia Campos 2017-11-06 06:11:18 PST
Created attachment 326116 [details]
Comment 2 Carlos Garcia Campos 2017-11-06 06:21:40 PST
It seems File::Copy::Recursive is required by copy-user-interface-resources.pl and it's not installed in EWS bots :-(

Please install the PEP module File::Copy::Recursive at /home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl line 50.
ninja: build stopped: subcommand failed.
Comment 3 Michael Catanzaro 2017-11-06 06:28:00 PST
I trust you'll add it to install-dependencies, of course.

Fedora package is perl-File-Copy-Recursive
Comment 4 Carlos Garcia Campos 2017-11-07 04:50:55 PST
Created attachment 326205 [details]
Comment 5 Michael Catanzaro 2017-11-07 06:44:34 PST
Comment on attachment 326205 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=326205&action=review

> Source/WebKit/InspectorGResources.cmake:46
> +    )

Always use VERBATIM with add_custom_command and add_custom_target.
Comment 6 Carlos Garcia Campos 2017-11-07 23:23:48 PST
Committed r224566: <https://trac.webkit.org/changeset/224566>