Bug 179419 - REGRESSION(r224566): [GTK][WPE] Many inspector tests are failing after r224566
Summary: REGRESSION(r224566): [GTK][WPE] Many inspector tests are failing after r224566
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk, LayoutTestFailure, Regression
: 179430 (view as bug list)
Depends on:
Reported: 2017-11-08 01:39 PST by Carlos Garcia Campos
Modified: 2017-11-09 07:16 PST (History)
6 users (show)

See Also:

Patch (3.42 KB, patch)
2017-11-08 01:42 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-11-08 01:39:35 PST
All of them fail with the following error:

Uncaught exception in Inspector page: ReferenceError: Can't find variable: CodeMirror [TestCombined.js:36658:15]

This is because Test.html, even when combined, is trying to load CodeMirror from External/CodeMirror, but CodeMirror was already combined for Main.html. We need to also combine CodeMirror for Test.html. I don't know why this works in Mac.
Comment 1 Carlos Garcia Campos 2017-11-08 01:42:00 PST
Created attachment 326316 [details]
Comment 2 Carlos Garcia Campos 2017-11-08 03:43:59 PST
Joe, Brian I guess this is ok for Mac too, at least EWS didn't complain.
Comment 3 Carlos Garcia Campos 2017-11-08 23:48:17 PST
*** Bug 179430 has been marked as a duplicate of this bug. ***
Comment 4 Carlos Garcia Campos 2017-11-08 23:51:27 PST
Comment on attachment 326316 [details]

Ok, I'm landing this because it broke many tests. Joe, Brian if you have any objection or comment I'll fix it in a follow up.
Comment 5 WebKit Commit Bot 2017-11-09 00:12:07 PST
Comment on attachment 326316 [details]

Clearing flags on attachment: 326316

Committed r224621: <https://trac.webkit.org/changeset/224621>
Comment 6 WebKit Commit Bot 2017-11-09 00:12:09 PST
All reviewed patches have been landed.  Closing bug.