Add proper implementation for 'updatefound' event: - https://w3c.github.io/ServiceWorker/#install (step 7)
Created attachment 326078 [details] Patch
Comment on attachment 326078 [details] Patch Attachment 326078 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5116687 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/multiple-register.https.html
Created attachment 326086 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 326078 [details] Patch Attachment 326078 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5116715 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/multiple-register.https.html
Created attachment 326087 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 326093 [details] Patch
I have this locally... along with a lot of other update/install related stuff. The reason it hasn't landed is that it's impossible to reconcile the real stuff with the fake microtask While your patch doesn't change test results, that's because it doesn't do other "real" stuff too" Let's sync up this morning instead of landing this, please.
(In reply to Brady Eidson from comment #7) > I have this locally... along with a lot of other update/install related > stuff. > > The reason it hasn't landed is that it's impossible to reconcile the real > stuff with the fake microtask > > While your patch doesn't change test results, that's because it doesn't do > other "real" stuff too" > > Let's sync up this morning instead of landing this, please. Note - The other stuff I have is most of the rest of "Install", which is literally the only place where updatefound is fired, so let's reconcile all of Install first.
(In reply to Brady Eidson from comment #8) > (In reply to Brady Eidson from comment #7) > > I have this locally... along with a lot of other update/install related > > stuff. > > > > The reason it hasn't landed is that it's impossible to reconcile the real > > stuff with the fake microtask > > > > While your patch doesn't change test results, that's because it doesn't do > > other "real" stuff too" > > > > Let's sync up this morning instead of landing this, please. > > Note - The other stuff I have is most of the rest of "Install", which is > literally the only place where updatefound is fired, so let's reconcile all > of Install first. https://bugs.webkit.org/show_bug.cgi?id=179318 for reference.
This focuses on updatefound event, nothing else, as discussed during our previous sync meeting. It applies and passes all the tests. As far as I can tell, this is a step in the right direction. Not sure why we cannot land it. It does not implement the update service worker state / update registration state algorithms which you were working on.
(In reply to Chris Dumez from comment #10) > This focuses on updatefound event, nothing else, as discussed during our > previous sync meeting. It applies and passes all the tests. As far as I can > tell, this is a step in the right direction. Not sure why we cannot land it. > > It does not implement the update service worker state / update registration > state algorithms which you were working on. As far as I can tell, I did not take a very different direction than you so I do not see the problem. I also add the install() function where you can add your other steps. The difference between my patch and your are mostly that: 1. Mine if case of Youenn's changes that landed last Friday. You'd likely have to apply the same changes to your patch anyway. Not sure this is better than landing my patch and rebasing. 2. You are doing more things (update worker / registration state), which I expected.
Created attachment 326127 [details] Patch
Created attachment 326149 [details] Patch
Comment on attachment 326149 [details] Patch Clearing flags on attachment: 326149 Committed r224506: <https://trac.webkit.org/changeset/224506>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35567107>