RESOLVED FIXED 179321
ServiceWorkerContainer should take a PendingActivity while a service worker job is pending 
https://bugs.webkit.org/show_bug.cgi?id=179321
Summary ServiceWorkerContainer should take a PendingActivity while a service worker j...
Chris Dumez
Reported 2017-11-06 08:46:38 PST
ServiceWorkerContainer should take a PendingActivity while a service worker job is pending.
Attachments
Patch (2.09 KB, patch)
2017-11-06 08:48 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-06 08:48:21 PST
Created attachment 326123 [details] Patch
youenn fablet
Comment 2 2017-11-06 09:44:21 PST
Comment on attachment 326123 [details] Patch The usual style would probably be to have scheduleJob take a completion handler so that we can ensure to have setpending/unsetpending close one to the other or use makePendingActivity. Given m_jobMap is only used to add/remove jobs, it could probably be moved at a different level as well.
Chris Dumez
Comment 3 2017-11-06 09:48:02 PST
Comment on attachment 326123 [details] Patch Clearing flags on attachment: 326123 Committed r224496: <https://trac.webkit.org/changeset/224496>
Chris Dumez
Comment 4 2017-11-06 09:48:04 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-11-15 12:10:38 PST
<rdar://problem/35567078>
Note You need to log in before you can comment on or make changes to this bug.