Bug 179321 - ServiceWorkerContainer should take a PendingActivity while a service worker job is pending
Summary: ServiceWorkerContainer should take a PendingActivity while a service worker j...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-06 08:46 PST by Chris Dumez
Modified: 2017-11-15 12:10 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.09 KB, patch)
2017-11-06 08:48 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-11-06 08:46:38 PST 
ServiceWorkerContainer should take a PendingActivity while a service worker job is pending.
Comment 1 Chris Dumez 2017-11-06 08:48:21 PST 
Created attachment 326123 [details]
Patch
Comment 2 youenn fablet 2017-11-06 09:44:21 PST 
Comment on attachment 326123 [details]
Patch

The usual style would probably be to have scheduleJob take a completion handler so that we can ensure to have setpending/unsetpending close one to the other or use makePendingActivity.
Given m_jobMap is only used to add/remove jobs, it could probably be moved at a different level as well.
Comment 3 Chris Dumez 2017-11-06 09:48:02 PST 
Comment on attachment 326123 [details]
Patch

Clearing flags on attachment: 326123

Committed r224496: <https://trac.webkit.org/changeset/224496>
Comment 4 Chris Dumez 2017-11-06 09:48:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-15 12:10:38 PST 
<rdar://problem/35567078>