Bug 179322 – ScriptExecutionContext::serviceWorkerContainer() should avoid constructing a Navigator object

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

ScriptExecutionContext::serviceWorkerContainer() should avoid constructing a Navigator object unnecessarily.

[Chris Dumez]

Created attachment 326124 [details]
Patch

[Chris Dumez]

Created attachment 326125 [details]
Patch

[Sam Weinig]

Comment on attachment 326125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326125&action=review

> Source/WebCore/page/DOMWindow.h:140
>      Navigator* navigator() const;
> +    Navigator* optionalNavigator() const { return m_navigator.get(); }

Should/can navigator() return something non-null?

[Sam Weinig]

(In reply to Sam Weinig from comment #3)
> Comment on attachment 326125 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=326125&action=review
> 
> > Source/WebCore/page/DOMWindow.h:140
> >      Navigator* navigator() const;
> > +    Navigator* optionalNavigator() const { return m_navigator.get(); }
> 
> Should/can navigator() return something non-null?

Nevermind, I remember it can't due to no-frame cases.

[WebKit Commit Bot]

Comment on attachment 326125 [details]
Patch

Clearing flags on attachment: 326125

Committed r224502: <https://trac.webkit.org/changeset/224502>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35567095>