RESOLVED FIXED 179322
ScriptExecutionContext::serviceWorkerContainer() should avoid constructing a Navigator object
https://bugs.webkit.org/show_bug.cgi?id=179322
Summary ScriptExecutionContext::serviceWorkerContainer() should avoid constructing a ...
Chris Dumez
Reported 2017-11-06 09:06:52 PST
ScriptExecutionContext::serviceWorkerContainer() should avoid constructing a Navigator object unnecessarily.
Attachments
Patch (2.25 KB, patch)
2017-11-06 09:07 PST, Chris Dumez
no flags
Patch (2.25 KB, patch)
2017-11-06 09:13 PST, Chris Dumez
no flags
Chris Dumez
Comment 1 2017-11-06 09:07:53 PST
Chris Dumez
Comment 2 2017-11-06 09:13:29 PST
Sam Weinig
Comment 3 2017-11-06 11:25:38 PST
Comment on attachment 326125 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326125&action=review > Source/WebCore/page/DOMWindow.h:140 > Navigator* navigator() const; > + Navigator* optionalNavigator() const { return m_navigator.get(); } Should/can navigator() return something non-null?
Sam Weinig
Comment 4 2017-11-06 11:27:04 PST
(In reply to Sam Weinig from comment #3) > Comment on attachment 326125 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326125&action=review > > > Source/WebCore/page/DOMWindow.h:140 > > Navigator* navigator() const; > > + Navigator* optionalNavigator() const { return m_navigator.get(); } > > Should/can navigator() return something non-null? Nevermind, I remember it can't due to no-frame cases.
WebKit Commit Bot
Comment 5 2017-11-06 11:46:38 PST
Comment on attachment 326125 [details] Patch Clearing flags on attachment: 326125 Committed r224502: <https://trac.webkit.org/changeset/224502>
WebKit Commit Bot
Comment 6 2017-11-06 11:46:40 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-11-15 12:11:00 PST
Note You need to log in before you can comment on or make changes to this bug.