RESOLVED FIXED 178637
[Settings] It should be easier to add settings to WebCore/WebKit 
https://bugs.webkit.org/show_bug.cgi?id=178637
Summary [Settings] It should be easier to add settings to WebCore/WebKit
Sam Weinig
Reported 2017-10-21 16:12:43 PDT
It should be easier to add settings to WebCore and WebKit. Currently, there is quite a bit of plumbing you have to do, to surface a setting as an API preference, and it's easy to get wrong.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-10-21 16:16:30 PDT
I'm not sure on the exact balance yet, but I leaning toward a system where to expose a setting via WebKit SPI you need to edit two configuration files (API will require something hand written on top of those edits): the Settings configuration file in WebCore, and Preferences configuration file in WebKit. We could conceivably get away with just the one in WebCore, but that feels like too great a layering violation, and would make it too easy to accidentally expose something as SPI that was only meant for testing.
Sam Weinig
Comment 2 2017-10-21 16:19:04 PDT
With 178634, WebCore will be converted to a YAML based configuration for Settings. I think adding a similar file for WebKit, where you can both declare a WebCore setting that should re-exported via WebKit, and add new WebKit layer only settings.
Sam Weinig
Comment 3 2024-11-20 18:47:32 PST
Marking complete. This has been done for some time now.
Note You need to log in before you can comment on or make changes to this bug.