Bug 178656 – [Settings] Add initial support for generating preferences related code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[Settings] Add initial support for generating preferences related code

[Sam Weinig]

Created attachment 324549 [details]
Patch

[Sam Weinig]

Created attachment 324550 [details]
Patch

[Sam Weinig]

Created attachment 324557 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 324557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324557&action=review

> Source/WebKit/Scripts/GeneratePreferences.rb:78
> +    @humanReadableName = "\"#{opts["humanReadableName"]}\"" || '""'
> +    @humanReadableDescription = "\"#{opts["humanReadableDescription"]}\"" || '""'

I don't think `||` part does anything here, the left side always produces a string that at least has quotes so it won't be falsey.

In the unlikely event that we might want to escape double quotes or other escape characters in the humanReadableDescription you could use String#inspect:
http://ruby-doc.org/core-2.1.1/String.html#method-i-inspect

    @humanReadableName = (opts["humanReadableName"] || "").inspect
    @humanReadableDescription = (opts["humanReadableDescription"] || "").inspect

That said, this might be cryptic, even for Rubyists. Perhaps just a simple:

    @humanReadableName = '"' + (opts["humanReadableName"] || "") + "'"
    @humanReadableDescription = '"' + (opts["humanReadableDescription"] || "") + '"'

> Source/WebKit/Scripts/GeneratePreferences.rb:119
> +    @boolPreferncesNotDebug = @preferences.select { |p| !p.category && !p.webkitOnly && p.type == "bool" }
> +    @doublePreferncesNotDebug = @preferences.select { |p| !p.category && !p.webkitOnly && p.type == "double" }

Typo (all members): "Prefernces" => "Preferences"

[Sam Weinig]

Created attachment 324597 [details]
Patch

[Sam Weinig]

Created attachment 324599 [details]
Patch

[Sam Weinig]

Created attachment 324600 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 324600 [details]
Patch

Clearing flags on attachment: 324600

Committed r223903: <https://trac.webkit.org/changeset/223903>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35568675>