Bug 178945 – [Settings] Generate more of the WebKit preferences code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[Settings] Generate more of the WebKit preferences code

[Sam Weinig]

Created attachment 325181 [details]
Patch

[Sam Weinig]

Created attachment 325207 [details]
Patch

[Chris Dumez]

Comment on attachment 325207 [details]
Patch

For what it's worth, I really hate that we're using Ruby instead of Python for this. This does against our efforts to move everything to Python and have a single language for our scripts. A lot of people do not know Ruby.

[Chris Dumez]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 325207 [details]
> Patch
> 
> For what it's worth, I really hate that we're using Ruby instead of Python
> for this. This does against our efforts to move everything to Python and
> have a single language for our scripts. A lot of people do not know Ruby.

*goes* against

[Sam Weinig]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 325207 [details]
> Patch
> 
> For what it's worth, I really hate that we're using Ruby instead of Python
> for this. This does against our efforts to move everything to Python and
> have a single language for our scripts. A lot of people do not know Ruby.

I wasn't aware we had an effort to converge on a single scripting language (e.g. I have made no attempt to migrate the bindings generator to python nor has anyone else as far as I know). I have always gone with use the right tool for the job, and in this case, I wanted a templating library, which ruby has built in by way of ERB.

[WebKit Commit Bot]

Comment on attachment 325207 [details]
Patch

Rejecting attachment 325207 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 325207, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/5024589

[Sam Weinig]

Committed r224154: <https://trac.webkit.org/changeset/224154>

[Sam Weinig]

(In reply to WebKit Commit Bot from comment #6)
> Comment on attachment 325207 [details]
> Patch
> 
> Rejecting attachment 325207 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch',
> '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02',
> 'validate-changelog', '--check-oops', '--non-interactive', 325207,
> '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
> 
> /Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid
> reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case
> insensitive).
> 
> Full output: http://webkit-queues.webkit.org/results/5024589

I don't get why this is happening. I feel like the commit queue used to be able to fill in the Reviewed by part. :\

[Joseph Pecoraro]

> I don't get why this is happening. I feel like the commit queue used to be
> able to fill in the Reviewed by part. :\

I think it’s looking for an OOPS line to fill in which is missing.

[Sam Weinig]

(In reply to Joseph Pecoraro from comment #9)
> > I don't get why this is happening. I feel like the commit queue used to be
> > able to fill in the Reviewed by part. :\
> 
> I think it’s looking for an OOPS line to fill in which is missing.

Weird. Why did I remove that!

[Radar WebKit Bug Importer]

<rdar://problem/35567850>