Change String::number to use "shortest" instead of "fixed precision 6 digits"
Created attachment 323834 [details] Patch
Attachment 323834 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 87 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 325269 [details] Patch
Created attachment 325307 [details] Patch
Created attachment 325312 [details] Patch
Created attachment 325316 [details] Patch
Created attachment 325325 [details] Patch
Created attachment 325326 [details] Patch
Comment on attachment 325326 [details] Patch Attachment 325326 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5037136 New failing tests: js/kde/Number.html js/dom/number-toprecision.html
Created attachment 325330 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325326 [details] Patch Attachment 325326 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5037148 New failing tests: js/kde/Number.html js/dom/number-toprecision.html
Created attachment 325332 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 325326 [details] Patch Attachment 325326 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5037160 New failing tests: js/kde/Number.html js/dom/number-toprecision.html
Created attachment 325333 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 325326 [details] Patch Attachment 325326 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5037161 New failing tests: js/kde/Number.html js/dom/number-toprecision.html
Created attachment 325334 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 325679 [details] Patch
Attachment 325679 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 95 files If any of these errors are false positives, please file a bug against check-webkit-style.
Having trouble figuring out what is causing the JavaScript stress tests to fail. Once I resolve that then I guess this is ready.
Not going to use the large patch I had here. Instead we are doing this more carefully and gradually and will be able to throw the switch soon.
Created attachment 364944 [details] Patch
Created attachment 364987 [details] Patch
Created attachment 369725 [details] Patch
Comment on attachment 369725 [details] Patch Attachment 369725 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/12176478 New failing tests: fast/visual-viewport/zoomed-fixed-scroll-down-then-up.html
Created attachment 369730 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.14.4
Created attachment 369731 [details] Patch
Created attachment 369816 [details] Patch
Created attachment 369918 [details] Patch
Comment on attachment 369918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369918&action=review > Source/WTF/wtf/text/StringBuilder.h:236 > // FIXME: Delete in favor of the name appendShortestFormNumber or just appendNumber. Since appendNumber for these types are now 'delete', this comment should be updated to just call for using appendShortestFormNumber. > Source/WTF/wtf/text/WTFString.h:193 > // FIXME: Delete in favor of the name numberToStringShortest or just number. Since number for these types are now 'delete', this comment should be updated to just call for using numberToStringShortest.
Comment on attachment 369918 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369918&action=review >> Source/WTF/wtf/text/StringBuilder.h:236 >> // FIXME: Delete in favor of the name appendShortestFormNumber or just appendNumber. > > Since appendNumber for these types are now 'delete', this comment should be updated to just call for using appendShortestFormNumber. Comment refers to the overload for double. In this patch, only the float overload is deleted. It’s there and deleted to prevent implicit float to double type conversion. So I think I am still happy with the comment as is. >> Source/WTF/wtf/text/WTFString.h:193 >> // FIXME: Delete in favor of the name numberToStringShortest or just number. > > Since number for these types are now 'delete', this comment should be updated to just call for using numberToStringShortest. Same thought as above.
Also, thanks for the review. I feel like I’ve been working on this for so long, but it’s almost done.
Comment on attachment 369918 [details] Patch Clearing flags on attachment: 369918 Committed r245504: <https://trac.webkit.org/changeset/245504>
All reviewed patches have been landed. Closing bug.
<rdar://problem/50929253>