Finish cleanup of String::number for floating point
Created attachment 371172 [details] Patch
Comment on attachment 371172 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371172&action=review > Source/WTF/wtf/text/WTFString.h:132 > + // We have verified empirically that we need to, but it would be good understand exactly why. Oops, missing word here in my edit to this comment. In my local patch I have now deleted the entire FIXME comment instead and that’s what I’ll land unless I get some feedback to the contrary during review.
Created attachment 371173 [details] Patch
Comment on attachment 371173 [details] Patch Attachment 371173 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12359319 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit-validate-phases apiTests
(In reply to Build Bot from comment #4) > Comment on attachment 371173 [details] > mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-dfg-eager-no-cjit- > validate-phases > apiTests Seems obvious from reading the error messages that this is not a real failure. Just a slow run on the test bot.
Comment on attachment 371173 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371173&action=review r=me > Source/WebCore/rendering/RenderListMarker.cpp:139 > + // The asterisks list-style-type is the worst case; we show |number| asterisks. > + CharacterType symbol = symbols[(number - 1) % symbolsSize]; > + unsigned count = (number - 1) / symbolsSize + 1; > + > + CharacterType* characters; > + String result = String::createUninitialized(count, characters); > + for (unsigned i = 0; i < count; ++i) > + characters[i] = symbol; > + return result; Nice! The code becomes much cleaner.
Comment on attachment 371173 [details] Patch Clearing flags on attachment: 371173 Committed r246034: <https://trac.webkit.org/changeset/246034>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51353064>