Bug 195142 - Fixed makeString(float) to do shortest-form serialization without first converting to double
Summary: Fixed makeString(float) to do shortest-form serialization without first conve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks: 178319
  Show dependency tree / graph
 
Reported: 2019-02-27 20:20 PST by Darin Adler
Modified: 2019-03-10 12:46 PDT (History)
7 users (show)

See Also:

Attachments
Patch (31.87 KB, patch)
2019-02-27 20:34 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (31.79 KB, patch)
2019-03-01 21:48 PST, Darin Adler 		dbates: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2019-02-27 20:20:42 PST 
Fixed makeString(float) to do shortest-form serialization without first converting to double
Comment 1 Darin Adler 2019-02-27 20:34:32 PST Comment hidden (obsolete)
Comment 2 Darin Adler 2019-03-01 21:48:35 PST 
Created attachment 363411 [details]
Patch
Comment 3 Darin Adler 2019-03-02 07:45:26 PST 
Passes tests, ready for review. Followups will reduce use of fixed precision and fixed width, which have been used to work around the lack of this.
Comment 4 Daniel Bates 2019-03-02 09:04:44 PST 
Comment on attachment 363411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363411&action=review

This patch is ok as-is. I’m was torn during review between pointing out style issues in the dtoa code or not because its code we brought over. For the lines you touched we could go farther towards conforming to the guide

> Source/WTF/ChangeLog:12
> +        marked the constructor explicit, removed types used only fir arguments for

fir

> Source/WTF/wtf/dtoa.h:30
> +using DtoaBuffer = std::array<char, 80>;

Nice.
Comment 5 Darin Adler 2019-03-02 12:55:04 PST 
Committed r242316: <https://trac.webkit.org/changeset/242316>
Comment 6 Radar WebKit Bug Importer 2019-03-02 12:56:25 PST 
<rdar://problem/48537932>