Bug 178272 - WK1 LayoutTest failures after "Use asynchronous ResourceHandleClient calls for WebKit1"
Summary: WK1 LayoutTest failures after "Use asynchronous ResourceHandleClient calls fo...
Status: RESOLVED DUPLICATE of bug 160677
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 150095 178365 178370 178371
  Show dependency treegraph
Reported: 2017-10-13 11:14 PDT by Ryan Haddad
Modified: 2017-10-31 17:24 PDT (History)
4 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-10-13 11:14:53 PDT
The following tests are failing / timing out on Sierra WK1 bots after "Use asynchronous ResourceHandleClient calls for WebKit1" <https://trac.webkit.org/changeset/223271/webkit>

Regressions: Unexpected text-only failures (8)
  http/tests/loading/basic-auth-resend-wrong-credentials.html [ Failure ]
  http/tests/media/video-redirect.html [ Failure ]
  http/tests/security/contentSecurityPolicy/audio-redirect-allowed.html [ Failure ]
  http/tests/security/contentSecurityPolicy/video-redirect-allowed.html [ Failure ]
  http/tests/security/contentSecurityPolicy/video-with-http-url-allowed-by-csp-media-src-star.html [ Failure ]
  http/tests/security/cross-frame-access-put.html [ Failure ]
  http/tests/security/local-video-source-from-remote.html [ Failure ]
  http/tests/security/video-cross-origin-accesssameorigin.html [ Failure ]

Regressions: Unexpected timeouts (8)
  http/tests/canvas/webgl/origin-clean-conformance.html [ Timeout ]
  http/tests/media/autoplay-if-audio-is-playing.html [ Timeout ]
  http/tests/media/video-load-twice.html [ Timeout ]
  http/tests/media/video-play-progress.html [ Timeout ]
  http/tests/security/canvas-remote-read-remote-video-localhost.html [ Timeout ]
  http/tests/security/canvas-remote-read-remote-video-redirect.html [ Timeout ]
  http/tests/security/video-cross-origin-caching.html [ Timeout ]
  http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html [ Timeout ]

Comment 1 Ryan Haddad 2017-10-13 11:21:04 PDT
Based on the changelog in r223271, tests may be less deterministic than they used to be, so I don't know if this is a definitive list of the newly-flaky / failing tests.
Comment 2 Alex Christensen 2017-10-13 11:39:09 PDT
I can only reproduce http/tests/loading/basic-auth-resend-wrong-credentials.html rarely and http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html
Comment 3 Alex Christensen 2017-10-13 16:41:28 PDT
I think we should just skip whatever tests start being flaky on that patch, since they will be WK1 changes only which are intentional, especially if they are only on certain operating systems.
Comment 4 Ryan Haddad 2017-10-13 17:42:27 PDT
Also seems to affect these tests:



I'll update expectations if that is the route we really want to take, but I still feel uneasy about it. Alexey, what are your thoughts?
Comment 5 Alexey Proskuryakov 2017-10-16 09:10:06 PDT
I don't think that it's OK to skip these tests on WK1. Please roll back until a better solution can be found.
Comment 6 Ryan Haddad 2017-10-16 09:12:54 PDT
Rolled out in https://trac.webkit.org/changeset/223408. Duping to original bug.

*** This bug has been marked as a duplicate of bug 160677 ***
Comment 7 Alex Christensen 2017-10-16 16:07:00 PDT
http/tests/loading/basic-credentials-sent-automatically.html is being fixed in https://bugs.webkit.org/show_bug.cgi?id=178365
Comment 8 Alex Christensen 2017-10-25 14:45:19 PDT
http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html was fixed in https://bugs.webkit.org/show_bug.cgi?id=150095
http/tests/loading/basic-auth-resend-wrong-credentials.html was fixed in https://bugs.webkit.org/show_bug.cgi?id=178370
http/tests/security/cross-frame-access-put.html was fixed in https://bugs.webkit.org/show_bug.cgi?id=178371
Comment 9 Alex Christensen 2017-10-31 17:24:13 PDT
Since I cannot reproduce any of the remaining tests, I'm going to mark them as flaky and try speculative fixes until the bots are happy.