RESOLVED FIXED Bug 178371
de-flakify http/tests/security/cross-frame-access-put.html
https://bugs.webkit.org/show_bug.cgi?id=178371
Summary de-flakify http/tests/security/cross-frame-access-put.html
Alex Christensen
Reported 2017-10-16 18:29:47 PDT
de-flakify http/tests/security/cross-frame-access-put.html
Attachments
Patch (5.08 KB, patch)
2017-10-16 18:32 PDT, Alex Christensen
thorton: review+
Alex Christensen
Comment 1 2017-10-16 18:32:23 PDT
Alex Christensen
Comment 2 2017-10-16 18:32:37 PDT
*** Bug 151053 has been marked as a duplicate of this bug. ***
Tim Horton
Comment 3 2017-10-17 10:27:08 PDT
Comment on attachment 323966 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323966&action=review > LayoutTests/ChangeLog:8 > + In the iframe, the test was being run after 0ms. Sometimes, the whole iframe hadn't loaded yet, You should get signoff from the test's author, since it's in security/ > LayoutTests/http/tests/security/cross-frame-access-put.html:33 > + alert(message.data); Did you mean to leave this alert here?
Alex Christensen
Comment 4 2017-10-17 10:40:06 PDT
Mostly added in http://trac.webkit.org/r30634 I cc'd Sam in case he has any input, but this test still tests the accessibility of properties and still reports those results. This test was never intended to test the synchronousness of loading.
Alex Christensen
Comment 5 2017-10-17 10:40:47 PDT
(In reply to Tim Horton from comment #3) > > LayoutTests/http/tests/security/cross-frame-access-put.html:33 > > + alert(message.data); > > Did you mean to leave this alert here? Yes, so we can see that the message is being sent in the results.
Alex Christensen
Comment 6 2017-10-17 10:41:40 PDT
Radar WebKit Bug Importer
Comment 7 2017-10-17 10:42:49 PDT
Note You need to log in before you can comment on or make changes to this bug.