Bug 178371 – de-flakify http/tests/security/cross-frame-access-put.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

de-flakify http/tests/security/cross-frame-access-put.html

[Alex Christensen]

Created attachment 323966 [details]
Patch

[Alex Christensen]

*** Bug 151053 has been marked as a duplicate of this bug. ***

[Tim Horton]

Comment on attachment 323966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323966&action=review

> LayoutTests/ChangeLog:8
> +        In the iframe, the test was being run after 0ms.  Sometimes, the whole iframe hadn't loaded yet,

You should get signoff from the test's author, since it's in security/

> LayoutTests/http/tests/security/cross-frame-access-put.html:33
> +    alert(message.data);

Did you mean to leave this alert here?

[Alex Christensen]

Mostly added in http://trac.webkit.org/r30634
I cc'd Sam in case he has any input, but this test still tests the accessibility of properties and still reports those results.  This test was never intended to test the synchronousness of loading.

[Alex Christensen]

(In reply to Tim Horton from comment #3)
> > LayoutTests/http/tests/security/cross-frame-access-put.html:33
> > +    alert(message.data);
> 
> Did you mean to leave this alert here?

Yes, so we can see that the message is being sent in the results.

[Alex Christensen]

http://trac.webkit.org/r223556

[Radar WebKit Bug Importer]

<rdar://problem/35032351>