Bug 178371 - de-flakify http/tests/security/cross-frame-access-put.html
Summary: de-flakify http/tests/security/cross-frame-access-put.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
: 151053 (view as bug list)
Depends on:
Blocks: 178272
  Show dependency treegraph
 
Reported: 2017-10-16 18:29 PDT by Alex Christensen
Modified: 2017-10-17 10:42 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.08 KB, patch)
2017-10-16 18:32 PDT, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-10-16 18:29:47 PDT
de-flakify http/tests/security/cross-frame-access-put.html
Comment 1 Alex Christensen 2017-10-16 18:32:23 PDT
Created attachment 323966 [details]
Patch
Comment 2 Alex Christensen 2017-10-16 18:32:37 PDT
*** Bug 151053 has been marked as a duplicate of this bug. ***
Comment 3 Tim Horton 2017-10-17 10:27:08 PDT
Comment on attachment 323966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323966&action=review

> LayoutTests/ChangeLog:8
> +        In the iframe, the test was being run after 0ms.  Sometimes, the whole iframe hadn't loaded yet,

You should get signoff from the test's author, since it's in security/

> LayoutTests/http/tests/security/cross-frame-access-put.html:33
> +    alert(message.data);

Did you mean to leave this alert here?
Comment 4 Alex Christensen 2017-10-17 10:40:06 PDT
Mostly added in http://trac.webkit.org/r30634
I cc'd Sam in case he has any input, but this test still tests the accessibility of properties and still reports those results.  This test was never intended to test the synchronousness of loading.
Comment 5 Alex Christensen 2017-10-17 10:40:47 PDT
(In reply to Tim Horton from comment #3)
> > LayoutTests/http/tests/security/cross-frame-access-put.html:33
> > +    alert(message.data);
> 
> Did you mean to leave this alert here?

Yes, so we can see that the message is being sent in the results.
Comment 6 Alex Christensen 2017-10-17 10:41:40 PDT
http://trac.webkit.org/r223556
Comment 7 Radar WebKit Bug Importer 2017-10-17 10:42:49 PDT
<rdar://problem/35032351>