160677 – Use asynchronous ResourceHandleClient calls for WebKit1

Bug 160677 - Use asynchronous ResourceHandleClient calls for WebKit1

Summary: Use asynchronous ResourceHandleClient calls for WebKit1

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Alex Christensen

URL:
Keywords:	InRadar

Duplicates (1):	178272 (view as bug list)
Depends on:	173964
Blocks:
	Show dependency tree / graph

Reported:	2016-08-08 16:54 PDT by Alex Christensen
Modified:	2018-04-27 21:09 PDT (History)
CC List:	15 users (show)

See Also:	185105

Attachments
Patch (82.97 KB, patch) 2016-08-08 17:05 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews100 for mac-yosemite (969.16 KB, application/zip) 2016-08-08 17:56 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-yosemite (1.49 MB, application/zip) 2016-08-08 18:08 PDT, Build Bot	no flags	Details
Patch (84.59 KB, patch) 2016-10-17 14:32 PDT, Alex Christensen	achristensen: review- buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews103 for mac-yosemite (987.19 KB, application/zip) 2016-10-17 15:41 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-yosemite (1.94 MB, application/zip) 2016-10-17 15:54 PDT, Build Bot	no flags	Details
apply patch on HEAD (93.57 KB, patch) 2017-02-10 16:43 PST, Basuke Suzuki	buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1010.53 KB, application/zip) 2017-02-10 17:35 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews103 for mac-elcapitan (1.53 MB, application/zip) 2017-02-10 17:40 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.94 MB, application/zip) 2017-02-10 18:02 PST, Build Bot	no flags	Details
patch (113.82 KB, patch) 2017-07-06 13:09 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (125.45 KB, patch) 2017-07-07 18:01 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews100 for mac-elcapitan (1.04 MB, application/zip) 2017-07-07 19:08 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (2.07 MB, application/zip) 2017-07-07 19:44 PDT, Build Bot	no flags	Details
Patch (131.86 KB, patch) 2017-10-05 13:36 PDT, Per Arne Vollan	no flags	Details \| Formatted Diff \| Diff
Patch (132.81 KB, patch) 2017-10-05 18:53 PDT, Per Arne Vollan	no flags	Details \| Formatted Diff \| Diff
Patch (150.88 KB, patch) 2017-10-09 14:15 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (153.12 KB, patch) 2017-10-09 14:23 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (53.79 KB, patch) 2017-10-09 15:11 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (154.48 KB, patch) 2017-10-09 15:13 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (146.86 KB, patch) 2017-10-09 16:42 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.28 MB, application/zip) 2017-10-09 17:45 PDT, Build Bot	no flags	Details
Patch (147.00 KB, patch) 2017-10-09 18:06 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.22 MB, application/zip) 2017-10-09 18:56 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-elcapitan (2.12 MB, application/zip) 2017-10-09 20:25 PDT, Build Bot	no flags	Details
Patch (148.11 KB, patch) 2017-10-09 23:47 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews112 for mac-elcapitan (2.10 MB, application/zip) 2017-10-10 01:35 PDT, Build Bot	no flags	Details
Patch (148.88 KB, patch) 2017-10-10 10:49 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (149.10 KB, patch) 2017-10-10 15:32 PDT, Alex Christensen	buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews112 for mac-elcapitan (1.80 MB, application/zip) 2017-10-10 17:00 PDT, Build Bot	no flags	Details
patch (149.10 KB, patch) 2017-10-10 17:05 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.19 MB, application/zip) 2017-10-10 18:05 PDT, Build Bot	no flags	Details
Patch (151.98 KB, patch) 2017-10-10 20:26 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (152.25 KB, patch) 2017-10-11 22:49 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch for wincairo (219 bytes, patch) 2017-10-12 12:46 PDT, Basuke Suzuki	no flags	Details \| Formatted Diff \| Diff
Patch for wincairo (3.03 KB, patch) 2017-10-12 12:49 PDT, Basuke Suzuki	no flags	Details \| Formatted Diff \| Diff
Patch (155.88 KB, patch) 2017-10-12 12:59 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Patch (158.69 KB, patch) 2017-10-31 17:45 PDT, Alex Christensen	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (37) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alex Christensen 2016-08-08 16:54:21 PDT

Use asynchronous ResourceHandleClient calls for WebKit1

Comment 1 Alex Christensen 2016-08-08 17:05:00 PDT

Created attachment 285610 [details]
Patch

Comment 2 Alex Christensen 2016-08-08 17:05:45 PDT

There are still a few problems with this first patch.  I want to see the failures

Comment 3 Build Bot 2016-08-08 17:56:51 PDT

Comment on attachment 285610 [details]
Patch

Attachment 285610 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1836992

New failing tests:
fast/harness/show-modal-dialog.html
fast/events/scroll-event-during-modal-dialog.html
http/tests/security/cross-origin-modal-dialog-base.html

Comment 4 Build Bot 2016-08-08 17:56:54 PDT

Created attachment 285622 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 5 Build Bot 2016-08-08 18:08:25 PDT

Comment on attachment 285610 [details]
Patch

Attachment 285610 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1837006

New failing tests:
fast/harness/show-modal-dialog.html
http/tests/svg/svg-use-external.html
http/tests/security/cross-origin-modal-dialog-base.html
fast/events/scroll-event-during-modal-dialog.html
http/tests/loading/text-content-type-with-binary-extension.html

Comment 6 Build Bot 2016-08-08 18:08:29 PDT

Created attachment 285624 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 7 Alex Christensen 2016-08-09 22:30:52 PDT

Comment on attachment 285610 [details]
Patch

Windows isn't quite ready for this :(
Will revisit

Comment 8 Alex Christensen 2016-10-17 14:32:44 PDT

Created attachment 291878 [details]
Patch

Comment 9 Build Bot 2016-10-17 15:41:24 PDT

Comment on attachment 291878 [details]
Patch

Attachment 291878 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2307224

New failing tests:
fast/harness/show-modal-dialog.html
security/block-test.html
fast/events/scroll-event-during-modal-dialog.html
http/tests/security/cross-origin-modal-dialog-base.html

Comment 10 Build Bot 2016-10-17 15:41:29 PDT

Created attachment 291885 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 11 Build Bot 2016-10-17 15:54:06 PDT

Comment on attachment 291878 [details]
Patch

Attachment 291878 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2307244

New failing tests:
http/tests/cache/iframe-304-crash.html
fast/files/apply-blob-url-to-xhr.html
http/tests/svg/svg-use-external.html
fast/events/scroll-event-during-modal-dialog.html
fast/files/xhr-blob-request.html
http/tests/loading/text-content-type-with-binary-extension.html
fast/harness/show-modal-dialog.html
http/tests/security/cross-origin-modal-dialog-base.html

Comment 12 Build Bot 2016-10-17 15:54:11 PDT

Created attachment 291889 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 13 Basuke Suzuki 2017-02-10 16:43:17 PST

Created attachment 301215 [details]
apply patch on HEAD

Just testing rebase patch working

Comment 14 WebKit Commit Bot 2017-02-10 16:45:45 PST

Attachment 301215 [details] did not pass style-queue:


ERROR: Source/WebKit/PlatformWin.cmake:257:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/PlatformWin.cmake:258:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/PlatformWin.cmake:259:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/PlatformWin.cmake:260:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/PlatformWin.cmake:261:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:47:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:568:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:569:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:570:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:571:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:571:  Missing space before ( in while(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1163:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1164:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1165:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1166:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1167:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1168:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1169:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1170:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1171:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1172:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1173:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1168:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:48:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:48:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:104:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:105:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:106:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:107:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:108:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:109:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:110:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:112:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:113:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:115:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:128:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:129:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:130:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:131:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:131:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:132:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:133:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:165:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:166:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:167:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:168:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:169:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:172:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:173:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:175:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:196:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:197:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:198:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:199:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:199:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:200:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:201:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:202:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:208:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:209:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:233:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:235:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:237:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:243:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:244:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:245:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:246:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:247:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:250:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:251:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:253:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:262:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:263:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:264:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:265:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:265:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:266:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:267:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:268:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:277:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:279:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:281:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:67:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 83 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 15 Build Bot 2017-02-10 17:35:27 PST

Comment on attachment 301215 [details]
apply patch on HEAD

Attachment 301215 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3065432

New failing tests:
http/tests/security/http-0.9/iframe-blocked.html
http/tests/security/http-0.9/worker-connect-src-blocked.html
http/tests/security/http-0.9/xhr-blocked.html
http/tests/security/http-0.9/xhr-asynchronous-blocked.html
http/tests/security/http-0.9/image-blocked.html
http/tests/security/http-0.9/worker-importScripts-blocked.html

Comment 16 Build Bot 2017-02-10 17:35:32 PST

Created attachment 301220 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

Comment 17 Build Bot 2017-02-10 17:40:22 PST

Comment on attachment 301215 [details]
apply patch on HEAD

Attachment 301215 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3065440

New failing tests:
http/tests/security/http-0.9/iframe-blocked.html
http/tests/security/http-0.9/worker-connect-src-blocked.html
http/tests/security/http-0.9/xhr-blocked.html
http/tests/security/http-0.9/xhr-asynchronous-blocked.html
http/tests/security/cross-origin-modal-dialog-base.html
http/tests/security/http-0.9/image-blocked.html
fast/harness/show-modal-dialog.html
http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked.html
http/tests/security/http-0.9/worker-importScripts-blocked.html
fast/events/scroll-event-during-modal-dialog.html

Comment 18 Build Bot 2017-02-10 17:40:26 PST

Created attachment 301224 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 19 Build Bot 2017-02-10 18:02:23 PST

Comment on attachment 301215 [details]
apply patch on HEAD

Attachment 301215 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3065484

New failing tests:
http/tests/cache/iframe-304-crash.html
fast/files/apply-blob-url-to-xhr.html
http/tests/security/http-0.9/iframe-blocked.html
http/tests/security/http-0.9/worker-connect-src-blocked.html
http/tests/svg/svg-use-external.html
http/tests/security/http-0.9/xhr-blocked.html
http/tests/security/http-0.9/xhr-asynchronous-blocked.html
http/tests/security/cross-origin-modal-dialog-base.html
http/tests/security/http-0.9/image-blocked.html
fast/files/xhr-blob-request.html
http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked.html
fast/harness/show-modal-dialog.html
http/tests/security/http-0.9/worker-importScripts-blocked.html
fast/events/scroll-event-during-modal-dialog.html

Comment 20 Build Bot 2017-02-10 18:02:28 PST

Created attachment 301229 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 21 Alex Christensen 2017-07-06 13:09:30 PDT

Created attachment 314747 [details]
patch

Comment 22 Alex Christensen 2017-07-07 18:01:29 PDT

Created attachment 314903 [details]
Patch

Comment 23 Build Bot 2017-07-07 19:08:44 PDT

Comment on attachment 314903 [details]
Patch

Attachment 314903 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4074625

New failing tests:
fast/harness/show-modal-dialog.html
security/block-test.html
fast/events/scroll-event-during-modal-dialog.html

Comment 24 Build Bot 2017-07-07 19:08:46 PDT

Created attachment 314906 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 25 Build Bot 2017-07-07 19:44:36 PDT

Comment on attachment 314903 [details]
Patch

Attachment 314903 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4074670

New failing tests:
fast/files/apply-blob-url-to-xhr-using-open-panel.html
fast/files/apply-blob-url-to-xhr.html
fast/harness/show-modal-dialog.html
fast/files/xhr-blob-request.html
http/tests/loading/basic-credentials-sent-automatically.html
fast/events/scroll-event-during-modal-dialog.html

Comment 26 Build Bot 2017-07-07 19:44:38 PDT

Created attachment 314911 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 27 Alex Christensen 2017-07-20 09:35:23 PDT

Comment on attachment 314903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314903&action=review

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:217
> +    auto work = [protectedThis = makeRef(*this)] () mutable {

We need to capture this here.

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:239
> +    auto work = [protectedThis = makeRef(*this), error = RetainPtr<CFErrorRef>(error)] () mutable {

ditto

Comment 28 Basuke Suzuki 2017-10-03 14:41:13 PDT

I believe the curl port is ready for this change now by implementing the bug 173964.

Comment 29 Per Arne Vollan 2017-10-05 13:36:43 PDT

Created attachment 322912 [details]
Patch

Comment 30 Per Arne Vollan 2017-10-05 18:53:33 PDT

Created attachment 322961 [details]
Patch

Comment 31 Alex Christensen 2017-10-09 14:15:38 PDT

Created attachment 323215 [details]
Patch

Comment 32 Alex Christensen 2017-10-09 14:23:03 PDT

Created attachment 323216 [details]
Patch

Comment 33 Alex Christensen 2017-10-09 15:11:08 PDT

Created attachment 323230 [details]
Patch

Comment 34 Alex Christensen 2017-10-09 15:13:20 PDT

Created attachment 323231 [details]
Patch

Comment 35 Alex Christensen 2017-10-09 16:42:53 PDT

Created attachment 323242 [details]
Patch

Comment 36 Per Arne Vollan 2017-10-09 17:39:23 PDT

(In reply to Alex Christensen from comment #35)
> Created attachment 323242 [details]
> Patch

The Windows build seems to be failing. I think the hook procedure needs to have the __stdcall calling convention:

LRESULT __stdcall hookProcedure(int,WPARAM,LPARAM)
{
    ...
}

Comment 37 Build Bot 2017-10-09 17:45:46 PDT

Comment on attachment 323242 [details]
Patch

Attachment 323242 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4806153

New failing tests:
fast/harness/show-modal-dialog.html
fast/events/scroll-event-during-modal-dialog.html
svg/in-html/by-reference.html

Comment 38 Build Bot 2017-10-09 17:45:48 PDT

Created attachment 323257 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 39 Alex Christensen 2017-10-09 18:06:18 PDT

Created attachment 323261 [details]
Patch

Comment 40 Build Bot 2017-10-09 18:56:57 PDT

Comment on attachment 323261 [details]
Patch

Attachment 323261 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4807225

New failing tests:
security/block-test.html
svg/in-html/by-reference.html

Comment 41 Build Bot 2017-10-09 18:56:59 PDT

Created attachment 323266 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 42 Build Bot 2017-10-09 20:25:36 PDT

Comment on attachment 323261 [details]
Patch

Attachment 323261 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4807885

New failing tests:
fast/files/apply-blob-url-to-xhr-using-open-panel.html
fast/files/apply-blob-url-to-xhr.html
security/block-test.html
fast/files/xhr-blob-request.html

Comment 43 Build Bot 2017-10-09 20:25:38 PDT

Created attachment 323278 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 44 Alex Christensen 2017-10-09 23:47:51 PDT

Created attachment 323284 [details]
Patch

Comment 45 Build Bot 2017-10-10 01:35:40 PDT

Comment on attachment 323284 [details]
Patch

Attachment 323284 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4809885

New failing tests:
fast/files/xhr-blob-request.html
fast/files/apply-blob-url-to-xhr.html
fast/files/apply-blob-url-to-xhr-using-open-panel.html

Comment 46 Build Bot 2017-10-10 01:35:41 PDT

Created attachment 323289 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 47 Alex Christensen 2017-10-10 10:49:55 PDT

Created attachment 323320 [details]
Patch

Comment 48 Alex Christensen 2017-10-10 15:32:49 PDT

Created attachment 323353 [details]
Patch

Comment 49 Build Bot 2017-10-10 17:00:18 PDT

Comment on attachment 323353 [details]
Patch

Attachment 323353 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4817229

New failing tests:
http/tests/loading/basic-credentials-sent-automatically.html
svg/in-html/by-reference.html

Comment 50 Build Bot 2017-10-10 17:00:20 PDT

Created attachment 323362 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 51 Alex Christensen 2017-10-10 17:05:18 PDT

Created attachment 323364 [details]
patch

Comment 52 Build Bot 2017-10-10 18:05:26 PDT

Comment on attachment 323364 [details]
patch

Attachment 323364 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4817994

New failing tests:
svg/in-html/by-reference.html

Comment 53 Build Bot 2017-10-10 18:05:27 PDT

Created attachment 323367 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 54 Alex Christensen 2017-10-10 20:26:07 PDT

Created attachment 323377 [details]
Patch

Comment 55 Brady Eidson 2017-10-10 23:43:19 PDT

Looks like windows is still unhappy

Comment 56 Brady Eidson 2017-10-10 23:46:10 PDT

Comment on attachment 323377 [details]
Patch

Make sure windows is good.

Comment 57 Alex Christensen 2017-10-11 22:49:23 PDT

Created attachment 323513 [details]
Patch

Comment 58 Basuke Suzuki 2017-10-12 12:46:03 PDT

Created attachment 323550 [details]
Patch for wincairo

Here's a wincairo part patch.

Comment 59 Basuke Suzuki 2017-10-12 12:49:25 PDT

Created attachment 323551 [details]
Patch for wincairo

Second try

Comment 60 Alex Christensen 2017-10-12 12:59:41 PDT

Created attachment 323552 [details]
Patch

Comment 61 Alex Christensen 2017-10-12 18:55:41 PDT

http://trac.webkit.org/r223271

Comment 62 Radar WebKit Bug Importer 2017-10-12 18:56:20 PDT

<rdar://problem/34969108>

Comment 63 Ryan Haddad 2017-10-16 09:12:25 PDT

Reverted r223271 for reason:

This change introduced LayoutTest failures on WK1.

Committed r223408: <https://trac.webkit.org/changeset/223408>

Comment 64 Ryan Haddad 2017-10-16 09:12:54 PDT

*** Bug 178272 has been marked as a duplicate of this bug. ***

Comment 65 Basuke Suzuki 2017-10-19 00:59:51 PDT

Alex, what is your plan for this patch? Do you postpone to land this for a while? We have several patches waiting to submit, but taking a break to see the result of this one. Please share your upcoming action or plan for this.

Comment 66 Alex Christensen 2017-10-19 16:24:05 PDT

We need to fix all the tests noted in https://bugs.webkit.org/show_bug.cgi?id=178272 before re-landing this.

Comment 67 Alex Christensen 2017-10-31 17:45:20 PDT

Created attachment 325529 [details]
Patch

Comment 68 Alex Christensen 2017-10-31 18:13:22 PDT

http://trac.webkit.org/r224267

Comment 69 Simon Fraser (smfr) 2017-11-01 19:09:53 PDT

After this change, all the code that used to run on the WebThread on iOS in UIWebView is now running on the main thread, and lots of isMainThread() assertions fire. I want to roll this out.

Comment 70 Alex Christensen 2017-11-08 14:34:04 PST

That was fixed by https://bugs.webkit.org/show_bug.cgi?id=179189

Comment 71 Alex Christensen 2017-11-09 21:59:06 PST

WebKitLegacy scheduleInRunLoop fixed in https://bugs.webkit.org/show_bug.cgi?id=179515

Comment 72 Daniel Bates 2018-04-27 20:44:08 PDT

Comment on attachment 325529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325529&action=review

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:201
> +#if !PLATFORM(WIN)
>              adjustMIMETypeIfNecessary(cfResponse.get(), isMainResourceLoad);
> +#endif

How did you come to the conclusion that we only want to do this on Cocoa platforms? This change disagrees with the comment above "Avoid MIME type sniffing if the response comes back as 304 Not Modified." It seems weird that we would only do this for Cocoa platforms.

Comment 73 Daniel Bates 2018-04-27 21:09:35 PDT

(In reply to Daniel Bates from comment #72)
> Comment on attachment 325529 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325529&action=review
> 
> > Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:201
> > +#if !PLATFORM(WIN)
> >              adjustMIMETypeIfNecessary(cfResponse.get(), isMainResourceLoad);
> > +#endif
> 
> How did you come to the conclusion that we only want to do this on Cocoa
> platforms? This change disagrees with the comment above "Avoid MIME type
> sniffing if the response comes back as 304 Not Modified." It seems weird
> that we would only do this for Cocoa platforms.

Filed bug #185105 to fix this up.