Bug 160677 – Use asynchronous ResourceHandleClient calls for WebKit1

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Use asynchronous ResourceHandleClient calls for WebKit1

[Alex Christensen]

Created attachment 285610 [details]
Patch

[Alex Christensen]

There are still a few problems with this first patch.  I want to see the failures

[Build Bot]

Comment on attachment 285610 [details]
Patch

Attachment 285610 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1836992

New failing tests:
fast/harness/show-modal-dialog.html
fast/events/scroll-event-during-modal-dialog.html
http/tests/security/cross-origin-modal-dialog-base.html

[Build Bot]

Created attachment 285622 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 285610 [details]
Patch

Attachment 285610 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1837006

New failing tests:
fast/harness/show-modal-dialog.html
http/tests/svg/svg-use-external.html
http/tests/security/cross-origin-modal-dialog-base.html
fast/events/scroll-event-during-modal-dialog.html
http/tests/loading/text-content-type-with-binary-extension.html

[Build Bot]

Created attachment 285624 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Alex Christensen]

Comment on attachment 285610 [details]
Patch

Windows isn't quite ready for this :(
Will revisit

[Alex Christensen]

Created attachment 291878 [details]
Patch

[Build Bot]

Comment on attachment 291878 [details]
Patch

Attachment 291878 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2307224

New failing tests:
fast/harness/show-modal-dialog.html
security/block-test.html
fast/events/scroll-event-during-modal-dialog.html
http/tests/security/cross-origin-modal-dialog-base.html

[Build Bot]

Created attachment 291885 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291878 [details]
Patch

Attachment 291878 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2307244

New failing tests:
http/tests/cache/iframe-304-crash.html
fast/files/apply-blob-url-to-xhr.html
http/tests/svg/svg-use-external.html
fast/events/scroll-event-during-modal-dialog.html
fast/files/xhr-blob-request.html
http/tests/loading/text-content-type-with-binary-extension.html
fast/harness/show-modal-dialog.html
http/tests/security/cross-origin-modal-dialog-base.html

[Build Bot]

Created attachment 291889 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Basuke Suzuki]

Created attachment 301215 [details]
apply patch on HEAD

Just testing rebase patch working

[WebKit Commit Bot]

Attachment 301215 [details] did not pass style-queue:


ERROR: Source/WebKit/PlatformWin.cmake:257:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/PlatformWin.cmake:258:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/PlatformWin.cmake:259:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/PlatformWin.cmake:260:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/PlatformWin.cmake:261:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:47:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:568:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:569:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:570:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:571:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:571:  Missing space before ( in while(  [whitespace/parens] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1163:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1164:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1165:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1166:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1167:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1168:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1169:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1170:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1171:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1172:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1173:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:1168:  No trailing spaces  [whitespace/trailing] [5]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:48:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:48:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:104:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:105:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:106:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:107:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:108:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:109:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:110:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:112:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:113:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:115:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:128:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:129:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:130:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:131:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:131:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:132:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:133:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:165:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:166:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:167:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:168:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:169:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:172:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:173:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:175:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:196:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:197:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:198:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:199:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:199:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:200:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:201:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:202:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:208:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:209:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:233:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:235:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:237:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:243:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:244:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:245:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:246:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:247:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:250:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:251:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:253:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:262:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:263:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:264:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:265:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:265:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:266:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:267:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:268:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:277:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:279:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:281:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:67:  Tab found; better to use spaces  [whitespace/tab] [1]
Total errors found: 83 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 301215 [details]
apply patch on HEAD

Attachment 301215 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3065432

New failing tests:
http/tests/security/http-0.9/iframe-blocked.html
http/tests/security/http-0.9/worker-connect-src-blocked.html
http/tests/security/http-0.9/xhr-blocked.html
http/tests/security/http-0.9/xhr-asynchronous-blocked.html
http/tests/security/http-0.9/image-blocked.html
http/tests/security/http-0.9/worker-importScripts-blocked.html

[Build Bot]

Created attachment 301220 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301215 [details]
apply patch on HEAD

Attachment 301215 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3065440

New failing tests:
http/tests/security/http-0.9/iframe-blocked.html
http/tests/security/http-0.9/worker-connect-src-blocked.html
http/tests/security/http-0.9/xhr-blocked.html
http/tests/security/http-0.9/xhr-asynchronous-blocked.html
http/tests/security/cross-origin-modal-dialog-base.html
http/tests/security/http-0.9/image-blocked.html
fast/harness/show-modal-dialog.html
http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked.html
http/tests/security/http-0.9/worker-importScripts-blocked.html
fast/events/scroll-event-during-modal-dialog.html

[Build Bot]

Created attachment 301224 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301215 [details]
apply patch on HEAD

Attachment 301215 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3065484

New failing tests:
http/tests/cache/iframe-304-crash.html
fast/files/apply-blob-url-to-xhr.html
http/tests/security/http-0.9/iframe-blocked.html
http/tests/security/http-0.9/worker-connect-src-blocked.html
http/tests/svg/svg-use-external.html
http/tests/security/http-0.9/xhr-blocked.html
http/tests/security/http-0.9/xhr-asynchronous-blocked.html
http/tests/security/cross-origin-modal-dialog-base.html
http/tests/security/http-0.9/image-blocked.html
fast/files/xhr-blob-request.html
http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked.html
fast/harness/show-modal-dialog.html
http/tests/security/http-0.9/worker-importScripts-blocked.html
fast/events/scroll-event-during-modal-dialog.html

[Build Bot]

Created attachment 301229 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Alex Christensen]

Created attachment 314747 [details]
patch

[Alex Christensen]

Created attachment 314903 [details]
Patch

[Build Bot]

Comment on attachment 314903 [details]
Patch

Attachment 314903 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4074625

New failing tests:
fast/harness/show-modal-dialog.html
security/block-test.html
fast/events/scroll-event-during-modal-dialog.html

[Build Bot]

Created attachment 314906 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 314903 [details]
Patch

Attachment 314903 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4074670

New failing tests:
fast/files/apply-blob-url-to-xhr-using-open-panel.html
fast/files/apply-blob-url-to-xhr.html
fast/harness/show-modal-dialog.html
fast/files/xhr-blob-request.html
http/tests/loading/basic-credentials-sent-automatically.html
fast/events/scroll-event-during-modal-dialog.html

[Build Bot]

Created attachment 314911 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Alex Christensen]

Comment on attachment 314903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314903&action=review

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:217
> +    auto work = [protectedThis = makeRef(*this)] () mutable {

We need to capture this here.

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:239
> +    auto work = [protectedThis = makeRef(*this), error = RetainPtr<CFErrorRef>(error)] () mutable {

ditto

[Basuke Suzuki]

I believe the curl port is ready for this change now by implementing the bug 173964.

[Per Arne Vollan]

Created attachment 322912 [details]
Patch

[Per Arne Vollan]

Created attachment 322961 [details]
Patch

[Alex Christensen]

Created attachment 323215 [details]
Patch

[Alex Christensen]

Created attachment 323216 [details]
Patch

[Alex Christensen]

Created attachment 323230 [details]
Patch

[Alex Christensen]

Created attachment 323231 [details]
Patch

[Alex Christensen]

Created attachment 323242 [details]
Patch

[Per Arne Vollan]

(In reply to Alex Christensen from comment #35)
> Created attachment 323242 [details]
> Patch

The Windows build seems to be failing. I think the hook procedure needs to have the __stdcall calling convention:

LRESULT __stdcall hookProcedure(int,WPARAM,LPARAM)
{
    ...
}

[Build Bot]

Comment on attachment 323242 [details]
Patch

Attachment 323242 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4806153

New failing tests:
fast/harness/show-modal-dialog.html
fast/events/scroll-event-during-modal-dialog.html
svg/in-html/by-reference.html

[Build Bot]

Created attachment 323257 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Alex Christensen]

Created attachment 323261 [details]
Patch

[Build Bot]

Comment on attachment 323261 [details]
Patch

Attachment 323261 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4807225

New failing tests:
security/block-test.html
svg/in-html/by-reference.html

[Build Bot]

Created attachment 323266 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323261 [details]
Patch

Attachment 323261 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4807885

New failing tests:
fast/files/apply-blob-url-to-xhr-using-open-panel.html
fast/files/apply-blob-url-to-xhr.html
security/block-test.html
fast/files/xhr-blob-request.html

[Build Bot]

Created attachment 323278 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Alex Christensen]

Created attachment 323284 [details]
Patch

[Build Bot]

Comment on attachment 323284 [details]
Patch

Attachment 323284 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4809885

New failing tests:
fast/files/xhr-blob-request.html
fast/files/apply-blob-url-to-xhr.html
fast/files/apply-blob-url-to-xhr-using-open-panel.html

[Build Bot]

Created attachment 323289 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Alex Christensen]

Created attachment 323320 [details]
Patch

[Alex Christensen]

Created attachment 323353 [details]
Patch

[Build Bot]

Comment on attachment 323353 [details]
Patch

Attachment 323353 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4817229

New failing tests:
http/tests/loading/basic-credentials-sent-automatically.html
svg/in-html/by-reference.html

[Build Bot]

Created attachment 323362 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Alex Christensen]

Created attachment 323364 [details]
patch

[Build Bot]

Comment on attachment 323364 [details]
patch

Attachment 323364 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4817994

New failing tests:
svg/in-html/by-reference.html

[Build Bot]

Created attachment 323367 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Alex Christensen]

Created attachment 323377 [details]
Patch

[Brady Eidson]

Looks like windows is still unhappy

[Brady Eidson]

Comment on attachment 323377 [details]
Patch

Make sure windows is good.

[Alex Christensen]

Created attachment 323513 [details]
Patch

[Basuke Suzuki]

Created attachment 323550 [details]
Patch for wincairo

Here's a wincairo part patch.

[Basuke Suzuki]

Created attachment 323551 [details]
Patch for wincairo

Second try

[Alex Christensen]

Created attachment 323552 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r223271

[Radar WebKit Bug Importer]

<rdar://problem/34969108>

[Ryan Haddad]

Reverted r223271 for reason:

This change introduced LayoutTest failures on WK1.

Committed r223408: <https://trac.webkit.org/changeset/223408>

[Ryan Haddad]

*** Bug 178272 has been marked as a duplicate of this bug. ***

[Basuke Suzuki]

Alex, what is your plan for this patch? Do you postpone to land this for a while? We have several patches waiting to submit, but taking a break to see the result of this one. Please share your upcoming action or plan for this.

[Alex Christensen]

We need to fix all the tests noted in https://bugs.webkit.org/show_bug.cgi?id=178272 before re-landing this.

[Alex Christensen]

Created attachment 325529 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r224267

[Simon Fraser (smfr)]

After this change, all the code that used to run on the WebThread on iOS in UIWebView is now running on the main thread, and lots of isMainThread() assertions fire. I want to roll this out.

[Alex Christensen]

That was fixed by https://bugs.webkit.org/show_bug.cgi?id=179189

[Alex Christensen]

WebKitLegacy scheduleInRunLoop fixed in https://bugs.webkit.org/show_bug.cgi?id=179515

[Daniel Bates]

Comment on attachment 325529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=325529&action=review

> Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:201
> +#if !PLATFORM(WIN)
>              adjustMIMETypeIfNecessary(cfResponse.get(), isMainResourceLoad);
> +#endif

How did you come to the conclusion that we only want to do this on Cocoa platforms? This change disagrees with the comment above "Avoid MIME type sniffing if the response comes back as 304 Not Modified." It seems weird that we would only do this for Cocoa platforms.

[Daniel Bates]

(In reply to Daniel Bates from comment #72)
> Comment on attachment 325529 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=325529&action=review
> 
> > Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:201
> > +#if !PLATFORM(WIN)
> >              adjustMIMETypeIfNecessary(cfResponse.get(), isMainResourceLoad);
> > +#endif
> 
> How did you come to the conclusion that we only want to do this on Cocoa
> platforms? This change disagrees with the comment above "Avoid MIME type
> sniffing if the response comes back as 304 Not Modified." It seems weird
> that we would only do this for Cocoa platforms.

Filed bug #185105 to fix this up.