Bug 179515 – REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load

[Alex Christensen]

Created attachment 326521 [details]
Patch

[Build Bot]

Attachment 326521 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/NeverDestroyed.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 326521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326521&action=review

> Source/WTF/ChangeLog:15
> +        Unfortunately we need to go back to #ifdef guards because different copies of this header are included while building WTF.

Wat

> Source/WTF/wtf/mac/MainThreadMac.mm:125
> +static RetainPtr<NSArray<NSString *>> nsArrayFromVector(const Vector<String>& strings)

The name of this function should be way more clear that it does crazy things.

[Alex Christensen]

Created attachment 326531 [details]
Patch

[Geoffrey Garen]

Comment on attachment 326531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=326531&action=review

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:277
> +    RetainPtr<NSArray<NSString *>> runLoopModes;
> +    if (auto* scheduledPairs = d->m_context->scheduledRunLoopPairs()) {
> +        runLoopModes = adoptNS([[NSMutableArray alloc] initWithCapacity:scheduledPairs->size()]);
> +        for (auto& pair : *scheduledPairs)
> +            [runLoopModes addObject:(NSString *)pair->mode()];
> +    }

Can we just pass though the SchedulePairHashSet instead of copying into an NSArray *?

Reasons to prefer:

(1) A full fix for this bug requires honoring not just the run loop mode but also the run loop, which need not be the main run loop.

(2) It's nice to pass C++ types to C++ code -- and faster too.

[Alex Christensen]

Created attachment 326547 [details]
Patch

[Alex Christensen]

Created attachment 326550 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/r224687

[Radar WebKit Bug Importer]

<rdar://problem/35562089>