Bug 177364 – REGRESSION(r221909): Failing fast/text/international/iso-8859-8.html

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Zan Dobersek]

Created attachment 321545 [details]
Diff image for fast/text/word-space-between-inlines.html failure

The following two layout tests fail after changes in r221909:
- fast/text/international/iso-8859-8.html
- fast/text/word-space-between-inlines.html

https://trac.webkit.org/changeset/221909/webkit

The first one fails with a text failure:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/text/international/iso-8859-8-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/text/international/iso-8859-8-actual.txt
@@ -1,4 +1,4 @@
 Test rendering of ISO-8859-8.
 
-PASS Test completed successfully
+FAIL Test 1 LTR: character   should be rendered right of כ
 

The second one is a reference test, but fails with a minimum difference between the actual and expected renderings (0.01%). Diff image is attached.

[Fujii Hironori]

fast/text/word-space-between-inlines.html fails in ports enabling
the advance text rendering mode, Cocoa and FreeType ports.
Bug 142086 tracks the failure.

[Fujii Hironori]

fast/text/international/iso-8859-8.html outputs the following error message to stderr in Debug build:

> ERROR: Shaper couldn't shape text run.
> /webkit/Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp(97) : void WebCore::FontCascade::adjustSelectionRectForComplexText(const WebCore::TextRun&, WebCore::LayoutRect&, unsigned int, unsigned int) const

[Fujii Hironori]

The second div element has 8 chracters.

> <div class="test">שנב גקכ </div>

Its RenderText removes the last trailing space.
Then, it has 7 characters, "שנב גקכ".

getClientRects tried get the position of the 7th character (the removed space).

Then, HarfBuzzShaper::shape failed.

[Fujii Hironori]

Created attachment 322490 [details]
A test content to check the position of the trainling space

I checked the position of the trainling space.

Google Chrome 61: left:78    width:0
Firefox 56      : left:63.98 width:0
Edge            : left:56.79 width:4
Mac port        : left:68    width:0
GTK+ port       : left:11    width:57

Screenshots: https://photos.app.goo.gl/HpfoE56etUyYj2092

GTK+ port returns the rect of the whole sentence.

[Fujii Hironori]

Created attachment 322495 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 322495 [details]:

fast/events/popup-blocking-timers3.html bug 177822 (authors: [e-mail], [e-mail], and [e-mail])
http/tests/security/window-properties-clear-domain.html bug 177823 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 322495 [details]
Patch

Clearing flags on attachment: 322495

Committed r222792: <http://trac.webkit.org/changeset/222792>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.