Bug 177344 – Export libwebrtc symbols through an export file

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

This will reduce changes made to libwebrtc header files.

[youenn fablet]

Created attachment 321516 [details]
Patch

[Build Bot]

Attachment 321516 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/base/messagehandler.h:27:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/base/ipaddress.h:89:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/base/ipaddress.h:89:  ipv4_address is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/base/ipaddress.h:90:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/base/ipaddress.h:90:  ipv6_address is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/jsep.h:73:  sdp_mid is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/video/i420_buffer.h:46:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/video/i420_buffer.h:55:  The parameter name "buffer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/video/i420_buffer.h:55:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/base/logging.h:178:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/base/logging.h:178:  min_sev is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_video/libyuv/include/webrtc_libyuv.h:85:  src_video_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/base/network.h:213:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/stats/rtcstats.h:77:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/stats/rtcstats.h:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/api/mediatypes.h:24:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basicportallocator.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basicportallocator.h:28:  The parameter name "network_manager" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 18 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 321516 [details]
Patch

Clearing flags on attachment: 321516

Committed r222430: <http://trac.webkit.org/changeset/222430>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Blaze Burg]

This caused the following warning in the build:

=== BUILD TARGET libwebrtc OF PROJECT libwebrtc WITH CONFIGURATION Debug ===

Check dependencies
Warning: The Compile Sources build phase contains this target's exported symbols file 'Configurations/libwebrtc.exp'.
warning: no rule to process file '/Users/bburg/repos/webkit/OpenSource/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp' of type sourcecode.exports for architecture x86_64


I think this is just a mistake in the Xcode project file. Can you investigate?

[youenn fablet]

Right, I'll fix that as part of bug 177465

[Radar WebKit Bug Importer]

<rdar://problem/34693095>