Bug 181378 - libwebrtc: Fix 'ld: warning: cannot export hidden symbol' messages
Summary: libwebrtc: Fix 'ld: warning: cannot export hidden symbol' messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 177344
Blocks:
  Show dependency tree / graph
 
Reported: 2018-01-08 03:00 PST by David Kilzer (:ddkilzer)
Modified: 2018-01-08 03:41 PST (History)
6 users (show)

See Also:

Attachments
Patch v1 (12.68 KB, patch)
2018-01-08 03:02 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-01-08 03:00:55 PST 
When building libwebrtc using Release or Production configurations, 117 linker warnings like this occur:

ld: warning: cannot export hidden symbol _WebRtcVad_ValidRateAndFrameLength from libwebrtc.build/Release-iphoneos/libwebrtc.build/Objects-normal/arm64/webrtc_vad.o

This happens because the symbol isn't exported.  These symbols should be removed from *.exp files.
Comment 1 David Kilzer (:ddkilzer) 2018-01-08 03:02:29 PST 
Created attachment 330673 [details]
Patch v1
Comment 2 WebKit Commit Bot 2018-01-08 03:33:17 PST 
Comment on attachment 330673 [details]
Patch v1

Clearing flags on attachment: 330673

Committed r226506: <https://trac.webkit.org/changeset/226506>
Comment 3 WebKit Commit Bot 2018-01-08 03:33:19 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-01-08 03:41:36 PST 
<rdar://problem/36346790>