Bug 177211 - Build libwebrtc unit tests executables
Summary: Build libwebrtc unit tests executables
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 177252 177344 177890
Blocks:
  Show dependency tree / graph
 
Reported: 2017-09-19 17:11 PDT by youenn fablet
Modified: 2017-10-04 12:27 PDT (History)
12 users (show)

See Also:

Attachments
Patch (6.60 MB, patch)
2017-09-19 18:48 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (6.60 MB, patch)
2017-09-19 21:17 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (6.59 MB, patch)
2017-09-20 10:33 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (6.60 MB, patch)
2017-09-20 11:05 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (822.09 KB, patch)
2017-09-21 10:33 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (823.10 KB, patch)
2017-09-21 12:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (816.46 KB, patch)
2017-09-21 13:02 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (816.48 KB, patch)
2017-09-21 14:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (819.01 KB, patch)
2017-09-22 16:54 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.02 MB, patch)
2017-09-24 10:25 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.05 MB, patch)
2017-09-24 21:03 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.05 MB, patch)
2017-09-24 21:29 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.06 MB, patch)
2017-09-25 09:56 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.22 MB, patch)
2017-09-25 10:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (710.82 KB, patch)
2017-09-25 17:14 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (710.67 KB, patch)
2017-09-26 16:14 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (710.19 KB, patch)
2017-09-26 16:17 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (701.65 KB, patch)
2017-09-28 13:53 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (708.86 KB, patch)
2017-10-02 10:36 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (704.22 KB, patch)
2017-10-02 14:25 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for relanding (701.87 KB, patch)
2017-10-02 14:40 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (20) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-09-19 17:11:16 PDT 
That is handy to build them when needed.
Comment 1 youenn fablet 2017-09-19 18:48:04 PDT 
Created attachment 321276 [details]
Patch
Comment 2 Alex Christensen 2017-09-19 18:50:40 PDT 
We already have Source/ThirdParty/gtest.  Could we just update that/move it instead?
Comment 3 youenn fablet 2017-09-19 18:51:20 PDT 
This requires googletest to be upstreamed.
I can try to trim up what to upstream.

The current build approach is to build everything as a static library, which means that we compile everything twice.
This may not be good for our bots, so the unittest new target would be optional by default and we need to find a way to activate it whenever useful.

If we want to run these tests for every commit, we could add a new bot task that would  run these tests and maybe compile them as part of a related task.
Comment 4 youenn fablet 2017-09-19 18:55:59 PDT 
(In reply to Alex Christensen from comment #2)
> We already have Source/ThirdParty/gtest.  Could we just update that/move it
> instead?

I tried and it is currently failing.
This gtest is including JSExportMacros.h from JSC so I guess that it is tailored for JSC/WebCore stuff.
Reusing that test would then create an unnecessary libwebrtc dependency to JSC.

Maybe we can remove the JSC/WebCore specific stuff from gtest?
Comment 5 youenn fablet 2017-09-19 21:17:21 PDT 
Created attachment 321286 [details]
Patch
Comment 6 Alex Christensen 2017-09-19 21:17:50 PDT 
Hmmm.
Could we upstream googletest in a separate patch if we need to upstream it?
Comment 7 youenn fablet 2017-09-19 21:25:07 PDT 
(In reply to Alex Christensen from comment #6)
> Hmmm.
> Could we upstream googletest in a separate patch if we need to upstream it?

Sure.

One issue with the current patch is that it activates compiling libwebrtc twice.
The final version should disable that.

If we do so, it will be probably easy to break it and notice it late only.
Or maybe there is an easy way to activate targets for some specific configurations?
Comment 8 youenn fablet 2017-09-20 10:33:33 PDT 
Created attachment 321329 [details]
Patch
Comment 9 youenn fablet 2017-09-20 11:05:59 PDT 
Created attachment 321336 [details]
Patch
Comment 10 youenn fablet 2017-09-21 10:33:38 PDT 
Created attachment 321444 [details]
Patch
Comment 11 Build Bot 2017-09-21 10:36:32 PDT 
Attachment 321444 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 youenn fablet 2017-09-21 12:15:21 PDT 
Created attachment 321461 [details]
Patch
Comment 13 Build Bot 2017-09-21 12:16:35 PDT 
Attachment 321461 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 youenn fablet 2017-09-21 13:02:32 PDT 
Created attachment 321467 [details]
Patch
Comment 15 Build Bot 2017-09-21 13:05:18 PDT 
Attachment 321467 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 youenn fablet 2017-09-21 14:15:09 PDT 
Created attachment 321477 [details]
Patch
Comment 17 Build Bot 2017-09-21 14:17:56 PDT 
Attachment 321477 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 18 youenn fablet 2017-09-22 16:54:30 PDT 
Created attachment 321604 [details]
Patch
Comment 19 Build Bot 2017-09-23 21:04:20 PDT 
Attachment 321604 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 9 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 20 youenn fablet 2017-09-24 10:25:20 PDT 
Created attachment 321655 [details]
Patch
Comment 21 Build Bot 2017-09-24 10:27:45 PDT 
Attachment 321655 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 9 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 youenn fablet 2017-09-24 21:03:01 PDT 
Created attachment 321665 [details]
Patch
Comment 23 Build Bot 2017-09-24 21:04:25 PDT 
Attachment 321665 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 9 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 24 youenn fablet 2017-09-24 21:29:25 PDT 
Created attachment 321667 [details]
Patch
Comment 25 Build Bot 2017-09-24 21:31:15 PDT 
Attachment 321667 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 9 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 26 youenn fablet 2017-09-25 09:56:07 PDT 
Created attachment 321695 [details]
Patch
Comment 27 Build Bot 2017-09-25 09:58:51 PDT 
Attachment 321695 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 9 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 28 youenn fablet 2017-09-25 10:58:34 PDT 
Created attachment 321702 [details]
Patch
Comment 29 youenn fablet 2017-09-25 10:59:52 PDT 
libwebrtc.dylib size now gets bigger from 9MB up to 10MB with these changes as we no longer strip some code that is only used for testing.
Some optimization might be doable there if really necessary.
Comment 30 Build Bot 2017-09-25 11:01:29 PDT 
Attachment 321702 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 9 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 31 youenn fablet 2017-09-25 17:14:09 PDT 
Created attachment 321776 [details]
Patch
Comment 32 Build Bot 2017-09-25 17:34:12 PDT 
Attachment 321776 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 9 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 33 Alex Christensen 2017-09-26 16:03:09 PDT 
Comment on attachment 321776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321776&action=review

> Source/ThirdParty/libwebrtc/ChangeLog:15
> +        The static libwebrtc library is then linked to each unit test executable.

libwebrtctest
Comment 34 youenn fablet 2017-09-26 16:14:09 PDT 
Created attachment 321884 [details]
Patch for landing
Comment 35 youenn fablet 2017-09-26 16:17:33 PDT 
Created attachment 321886 [details]
Patch for landing
Comment 36 Build Bot 2017-09-26 16:19:00 PDT 
Attachment 321886 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 9 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 37 WebKit Commit Bot 2017-09-26 17:38:04 PDT 
Comment on attachment 321886 [details]
Patch for landing

Clearing flags on attachment: 321886

Committed r222537: <http://trac.webkit.org/changeset/222537>
Comment 38 WebKit Commit Bot 2017-09-26 17:38:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 39 Ryan Haddad 2017-09-27 09:10:31 PDT 
Reverted r222537 for reason:

This change broke internal builds.

Committed r222555: <http://trac.webkit.org/changeset/222555>
Comment 40 youenn fablet 2017-09-28 13:53:37 PDT 
Created attachment 322112 [details]
Patch
Comment 41 Build Bot 2017-09-28 13:55:45 PDT 
Attachment 322112 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 9 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 42 youenn fablet 2017-09-29 09:33:59 PDT 
Retrying landing. Patch no longer include a target which had no file to compile.
Comment 43 WebKit Commit Bot 2017-09-29 10:05:42 PDT 
Comment on attachment 322112 [details]
Patch

Clearing flags on attachment: 322112

Committed r222652: <http://trac.webkit.org/changeset/222652>
Comment 44 WebKit Commit Bot 2017-09-29 10:05:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 45 Radar WebKit Bug Importer 2017-09-29 10:07:42 PDT 
<rdar://problem/34741355>
Comment 46 Matt Lewis 2017-09-29 15:25:21 PDT 
Reverted r222652 for reason:

This broke an internal build.

Committed r222668: <http://trac.webkit.org/changeset/222668>
Comment 47 youenn fablet 2017-10-02 10:35:13 PDT 
There is a missing symbol FunctionThatDoesNothingImpl for asan build which does not get exported and is needed.
The simplest approach is to compile the file that contains the symbol in libwebrtc static library.
Comment 48 youenn fablet 2017-10-02 10:36:13 PDT 
Created attachment 322388 [details]
Patch
Comment 49 youenn fablet 2017-10-02 14:25:54 PDT 
Created attachment 322436 [details]
Patch
Comment 50 youenn fablet 2017-10-02 14:40:37 PDT 
Created attachment 322443 [details]
Patch for relanding
Comment 51 Build Bot 2017-10-02 14:43:43 PDT 
Attachment 322443 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
Total errors found: 9 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 52 WebKit Commit Bot 2017-10-03 02:43:53 PDT 
Comment on attachment 322443 [details]
Patch for relanding

Clearing flags on attachment: 322443

Committed r222775: <http://trac.webkit.org/changeset/222775>
Comment 53 WebKit Commit Bot 2017-10-03 02:43:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 54 Alexey Proskuryakov 2017-10-03 20:26:21 PDT 
Can we avoid doing this? This adds 3-4 minutes to production build time, which is a huge huge number.
Comment 55 WebKit Commit Bot 2017-10-04 12:27:17 PDT 
Re-opened since this is blocked by bug 177890