Bug 176591 - Make RenderLayerCompositor always use isRootLayer()
Summary: Make RenderLayerCompositor always use isRootLayer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks: 176261 176684
  Show dependency tree / graph
 
Reported: 2017-09-08 06:13 PDT by Frédéric Wang (:fredw)
Modified: 2017-09-27 12:34 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.77 KB, patch)
2017-09-08 06:23 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (3.53 KB, patch)
2017-09-08 07:27 PDT, Frédéric Wang (:fredw) 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-09-08 06:13:11 PDT 
Sometimes, RenderLayerCompositor performs the verification &layer == m_renderView.layer() which could be replaced with the more readable isRootLayer() for consistency with the rest of the file.
Comment 1 Frédéric Wang (:fredw) 2017-09-08 06:23:32 PDT 
Created attachment 320258 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2017-09-08 07:27:07 PDT 
Created attachment 320260 [details]
Patch
Comment 3 Frédéric Wang (:fredw) 2017-09-08 08:10:18 PDT 
Some part is extracted from Simon's patch for bug 176261
Comment 4 Simon Fraser (smfr) 2017-09-08 10:30:43 PDT 
Comment on attachment 320260 [details]
Patch

I would like to rename isRootLayer() to isRenderViewLayer() at the same time.
Comment 5 Darin Adler 2017-09-10 15:17:44 PDT 
(In reply to Simon Fraser (smfr) from comment #4)
> I would like to rename isRootLayer() to isRenderViewLayer()

Good idea.

> at the same time.

Seems unnecessary to time it that way. Much bigger than this patch. Should do with do-webcore-rename!
Comment 6 Frédéric Wang (:fredw) 2017-09-10 22:50:28 PDT 
Committed r221845: <http://trac.webkit.org/changeset/221845>
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:34:02 PDT 
<rdar://problem/34693498>