Bug 175909 - REGRESSION (r220052): VideoControlsManager.VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling is a flaky API test
Summary: REGRESSION (r220052): VideoControlsManager.VideoControlsManagerMultipleVideos...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
: 242043 243675 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-08-23 15:18 PDT by Matt Lewis
Modified: 2022-09-30 18:55 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-08-23 15:18:51 PDT
The API test VideoControlsManager.VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling is a flaky timeout on macOS Sierra.

This test looks to have started to be flaky after r220052 like other tests from VideoControlsManager

Results:
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20%28Tests%29/builds/4087/steps/run-api-tests/logs/stdio
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/3798
Comment 1 Matt Lewis 2017-08-24 11:28:45 PDT
I was able to confirm the regression point locally by running all of the api tests on a debug build. I was unable to reproduce the timeout when just running the VideoControlsManager test alone.

Disabled the test for now in:
https://trac.webkit.org/changeset/221151/webkit
Comment 2 Radar WebKit Bug Importer 2018-07-31 17:01:59 PDT
<rdar://problem/42793000>
Comment 3 Cameron McCormack (:heycam) 2022-09-29 00:25:14 PDT
*** Bug 242043 has been marked as a duplicate of this bug. ***
Comment 4 Cameron McCormack (:heycam) 2022-09-29 00:25:25 PDT
*** Bug 243675 has been marked as a duplicate of this bug. ***
Comment 5 Cameron McCormack (:heycam) 2022-09-29 01:04:28 PDT
I'll fix the flakiness of these three tests in this bug:

VideoControlsManager.VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling
VideoControlsManager.VideoControlsManagerMultipleVideosScrollOnlyLargeVideoOutOfView
VideoControlsManager.VideoControlsManagerMultipleVideosScrollPlayingMutedVideoOutOfView

But it turns out VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling is also permanently failing for other reasons.  I'll file a separate bug on that after fixing the flakiness.
Comment 6 Cameron McCormack (:heycam) 2022-09-29 17:10:17 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4843
Comment 7 EWS 2022-09-30 18:55:50 PDT
Committed 255057@main (f83459d64a06): <https://commits.webkit.org/255057@main>

Reviewed commits have been landed. Closing PR #4843 and removing active labels.