Bug 175143 - REGRESSION (r220052):VideoControlsManager.VideoControlsManagerMultipleVideosWithAudioAndAutoplay is a flaky API test.
Summary: REGRESSION (r220052):VideoControlsManager.VideoControlsManagerMultipleVideosW...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
Keywords: InRadar
Depends on:
Reported: 2017-08-03 11:27 PDT by Matt Lewis
Modified: 2021-11-01 12:01 PDT (History)
7 users (show)

See Also:

Patch (2.90 KB, patch)
2018-01-23 07:22 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-08-03 11:27:54 PDT
VideoControlsManager.VideoControlsManagerMultipleVideosWithAudioAndAutoplay has been a flaky timeout on macOS Sierra. 

The test first failed with this build:

The test became flaky after the revision:

However I don't think this was the cause.
Comment 1 Radar WebKit Bug Importer 2017-08-07 15:03:48 PDT
Comment 2 Matt Lewis 2017-08-09 15:47:30 PDT
Spoke with Jer about the Timeout and determined the regression point is most likely
https://trac.webkit.org/changeset/220052/webkit and likely deals with the change in html/HTMLMediaElement.cpp
Comment 3 Ryan Haddad 2017-08-14 11:33:07 PDT
Skipped this flaky test in https://trac.webkit.org/changeset/220711/webkit
Comment 4 Jer Noble 2018-01-23 07:22:21 PST
Created attachment 332028 [details]
Comment 5 Peng Liu 2020-08-26 16:05:52 PDT
Comment on attachment 332028 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=332028&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:157
> +TEST(VideoControlsManager, VideoControlsManagerMultipleVideosWithAudioAndAutoplay)

Looks like this test still fails on Mac.
Comment 6 youenn fablet 2020-08-27 01:10:48 PDT
Comment on attachment 332028 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=332028&action=review

> Tools/ChangeLog:9
> +        Add the same "twice through the event loop" fix for this tast as was done in r221589.


> Tools/TestWebKitAPI/Tests/WebKitCocoa/large-videos-with-audio-autoplay.html:7
> +        // to happen in a certain number of timeouts.

Is there a way to make Internals API know whether controls are visible?
If so, we could inject Internals in that test instead of using setTimeout.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/large-videos-with-audio-autoplay.html:10
> +                webkit.messageHandlers.testHandler.postMessage("autoplaying");

Should it be "autoplayed" instead of "autoplaying"?
Comment 7 Alex Christensen 2021-11-01 12:01:16 PDT
Comment on attachment 332028 [details]

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.