Bug 175329 - REGRESSION (r220052): [Sierra] API test VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a flaky failure
Summary: REGRESSION (r220052): [Sierra] API test VideoControlsManager.VideoControlsMan...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
Keywords: InRadar
Depends on:
Reported: 2017-08-08 09:46 PDT by Ryan Haddad
Modified: 2019-01-15 17:10 PST (History)
9 users (show)

See Also:

Patch (6.50 KB, patch)
2017-09-03 15:31 PDT, Darin Adler
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-08-08 09:46:50 PDT
API test VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame is a flaky failure

FAIL VideoControlsManager.VideoControlsManagerFullSizeVideoInWideMainFrame

Value of: hasVideoForControlsManager
  Actual: false
Expected: true

Comment 1 Alexey Proskuryakov 2017-08-08 10:40:35 PDT
HAs something changed, or have we simply been not noticing this for so long?
Comment 2 Ryan Haddad 2017-08-08 10:42:43 PDT
(In reply to Alexey Proskuryakov from comment #1)
> HAs something changed, or have we simply been not noticing this for so long?

This seems to be a recent regression, perhaps sharing the same root cause as https://bugs.webkit.org/show_bug.cgi?id=175143

I am trying to reproduce both failures locally and identify a regression point.
Comment 3 Ryan Haddad 2017-08-10 13:17:22 PDT
This regressed with https://trac.webkit.org/changeset/220052/webkit
Comment 4 Ryan Haddad 2017-08-14 11:33:02 PDT
Skipped this flaky test in https://trac.webkit.org/changeset/220711/webkit
Comment 5 Darin Adler 2017-08-15 09:16:38 PDT
Jer, can you perhaps help me figure out why this is failing? I would like to fix it and re-enable the test.
Comment 6 Darin Adler 2017-09-03 15:31:17 PDT
Created attachment 319811 [details]
Comment 7 Darin Adler 2017-09-03 22:24:30 PDT
Passing all EWS now. Ready for someone to review.
Comment 8 Wenson Hsieh 2017-09-04 00:34:10 PDT
Comment on attachment 319811 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=319811&action=review

> Tools/ChangeLog:9
> +        video controls to appear. With changes to how loading occurrs, it can now

Nit - occurrs => occurs

> Tools/ChangeLog:13
> +        changing the tests to wait one more run loop should get rid of the flakiness.

In the longer term, I think it makes more sense for some of these tests to expect media controls to show up eventually, instead of expecting them after a "playing" message sent after a 0-delay timer in the web process. As you noted, there isn't a guarantee of how many run loop cycles it would take for the web process to be in a state where it wants to show media controls, nor should there be, since touch bar presence for media elements isn't web/API exposed.
Comment 9 Darin Adler 2017-09-04 09:27:41 PDT
Committed r221589: <http://trac.webkit.org/changeset/221589>
Comment 10 Radar WebKit Bug Importer 2017-09-27 12:48:20 PDT