Bug 173061 - [WPE] The run-minibrowser script should allow to execute also a WPE launcher
Summary: [WPE] The run-minibrowser script should allow to execute also a WPE launcher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on: 173433
Blocks:
  Show dependency tree / graph
 
Reported: 2017-06-07 09:06 PDT by Carlos Alberto Lopez Perez
Modified: 2017-06-15 14:13 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.38 KB, patch)
2017-06-07 09:12 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (4.91 KB, patch)
2017-06-14 08:14 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (5.21 KB, patch)
2017-06-14 10:10 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-06-07 09:06:34 PDT 
dyz <https://github.com/Igalia/dyz> is simple launcher for the WPE port.

It will be a good idea to plug this into our jhbuild and the webkit tooling to executing this with development builds of WPE is easy.

The idea would be to do simply:

Tools/Scripts/run-minibrowser --wpe http://url.com
Tools/Scripts/run-minibrowser --debug --wpe http://url.com


And get things just working.
Comment 1 Carlos Alberto Lopez Perez 2017-06-07 09:12:36 PDT 
Created attachment 312190 [details]
Patch

This is working, but I am not asking for review still as the dyz source on the JHBuild moduleset points to my fork of dyz on github. Waiting for the PR request i sent to be merged first on dyz in order to change the source on the moduleset.
Comment 2 Carlos Alberto Lopez Perez 2017-06-14 08:14:39 PDT 
Created attachment 312888 [details]
Patch
Comment 3 Carlos Alberto Lopez Perez 2017-06-14 10:10:29 PDT 
Created attachment 312901 [details]
Patch

Adjust install-dependencies script: both luajit and luajit-devel are needed
Comment 4 WebKit Commit Bot 2017-06-15 11:44:45 PDT 
Comment on attachment 312901 [details]
Patch

Clearing flags on attachment: 312901

Committed r218344: <http://trac.webkit.org/changeset/218344>
Comment 5 WebKit Commit Bot 2017-06-15 11:44:47 PDT 
All reviewed patches have been landed.  Closing bug.