171110 – Upstream the WPE port

RESOLVED FIXED Bug 171110

Upstream the WPE port

https://bugs.webkit.org/show_bug.cgi?id=171110

Summary Upstream the WPE port

Zan Dobersek

Reported 2017-04-21 04:39:54 PDT

This bug hopes to upstream the WPE port of WebKit.

Attachments
Patch (473.98 KB, patch) 2017-04-21 04:41 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
git diff --stat output for the specific changes (12.07 KB, text/plain) 2017-04-21 04:43 PDT, Zan Dobersek	no flags	Details
Patch (491.52 KB, patch) 2017-04-21 05:04 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (491.54 KB, patch) 2017-04-21 07:03 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (492.69 KB, patch) 2017-04-21 07:48 PDT, Zan Dobersek	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (906.35 KB, application/zip) 2017-04-21 09:24 PDT, Build Bot	no flags	Details
WIP patch (472.39 KB, patch) 2017-04-27 06:08 PDT, Zan Dobersek	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-elcapitan (1.83 MB, application/zip) 2017-04-27 07:52 PDT, Build Bot	no flags	Details
Patch (473.00 KB, patch) 2017-04-27 13:41 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
git diff --stat output for the specific changes (12.45 KB, text/plain) 2017-04-27 13:46 PDT, Zan Dobersek	no flags	Details
\ (491.05 KB, patch) 2017-04-28 13:29 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Patch (491.05 KB, patch) 2017-04-28 13:30 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
git diff --stat output for the specific changes (25.31 KB, text/plain) 2017-04-28 13:31 PDT, Zan Dobersek	no flags	Details
Patch (490.93 KB, patch) 2017-05-04 02:32 PDT, Zan Dobersek	achristensen: review+	Details Formatted Diff Diff
git diff --stat output (22.59 KB, text/plain) 2017-05-04 02:33 PDT, Zan Dobersek	no flags	Details
Patch for landing (481.05 KB, patch) 2017-05-09 00:57 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
Show Obsolete (15) View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2017-04-21 04:41:26 PDT

Created attachment 307718 [details] Patch Patch containing the source code changes required to bring the WPE port upstream.

Zan Dobersek

Comment 2 2017-04-21 04:43:01 PDT

Created attachment 307719 [details] git diff --stat output for the specific changes

Build Bot

Comment 3 2017-04-21 04:45:33 PDT

Attachment 307718 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:36: "WebKit/WKBase.h" already included at Source/WebKit2/Shared/API/c/wpe/WebKit.h:31 [build/include] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:47: "WebKit/WKType.h" already included at Source/WebKit2/Shared/API/c/wpe/WebKit.h:32 [build/include] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:54: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:80: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:83: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:96: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/wpe/WebEventFactory.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:45: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:44: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEViewClient.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/PlatformWPE.cmake:48: Alphabetical sorting problem. "Platform/IPC/glib/GSocketMonitor.cpp" should be before "Platform/glib/ModuleGlib.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:71: Alphabetical sorting problem. "Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp" should be before "Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:108: Alphabetical sorting problem. "UIProcess/BackingStore.cpp" should be before "UIProcess/API/wpe/WPEViewClient.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:116: Alphabetical sorting problem. "UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp" should be before "UIProcess/InspectorServer/wpe/WebInspectorServerWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:177: Alphabetical sorting problem. "# FIXME-GWSHARE:" should be before "WebProcess/wpe/WebProcessMainWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:178: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp". [list/emptyline] [5] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:44: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:45: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:46: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:48: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:49: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:50: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:55: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:56: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:57: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:59: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:60: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:61: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:62: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:65: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:68: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:71: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:75: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:78: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:79: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/CMakeLists.txt:3999: No space before ")" [whitespace/parentheses] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WKBaseWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:128: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebCore/platform/graphics/PlatformDisplay.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/wpe/generate-inspector-gresource-manifest.py:77: blank line at end of file [pep8/W391] [5] ERROR: Tools/Scripts/webkitpy/port/wpe.py:34: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/wpe/WebEventFactory.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.cpp:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.cpp:63: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/PlatformWPE.cmake:11: Alphabetical sorting problem. "API/JSBase.h" should be before "API/JavaScript.h". [list/order] [5] ERROR: Source/WebCore/page/wpe/EventHandlerWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/wpe/EventHandlerWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/CompositingManager.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/LocalizedStringsWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/PlatformWPE.cmake:57: Alphabetical sorting problem. "page/scrolling/ScrollingStateStickyNode.cpp" should be before "page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:108: Alphabetical sorting problem. "platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp" should be before "platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:143: Alphabetical sorting problem. "# FIXME: Split build targers below into a WebCorePlatform library" should be before "platform/text/TextEncodingDetectorICU.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:144: There should be exactly one empty line instead of 0 between "# FIXME: Split build targers below into a WebCorePlatform library" and "editing/wpe/EditorWPE.cpp". [list/emptyline] [5] ERROR: Source/WebCore/PlatformWPE.cmake:154: Alphabetical sorting problem. "platform/glib/SSLKeyGeneratorGLib.cpp" should be before "platform/glib/SharedBufferGlib.cpp". [list/order] [5] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKAPICastWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:38: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:40: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/WebPageWPE.cpp:31: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:28: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:28: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:66: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:41: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:43: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:44: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/Shared/wpe/NativeWebTouchEventWPE.cpp:35: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:36: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/PlatformWPE.cmake:8: Alphabetical sorting problem. "glib/GLibUtilities.cpp" should be before "glib/GRefPtr.cpp". [list/order] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:46: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:47: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:48: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:50: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:54: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:56: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:57: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:58: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:59: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:60: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:62: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:63: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:65: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:67: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:68: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:69: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:71: "virtual" is redundant since function is already declared as "override" [readability/ inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:72: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:73: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:74: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:76: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:77: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:78: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:79: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:81: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:82: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:83: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:85: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:87: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:90: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:91: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:92: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:94: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:96: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:97: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:98: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:99: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:100: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:101: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:103: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:104: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:105: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:106: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:108: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:110: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:111: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:114: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:117: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:119: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.cpp:194: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:71: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/graphics/wpe/PlatformDisplayWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.h:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEViewClient.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:38: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:39: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:41: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:42: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:43: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:96: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:97: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:98: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:99: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] Total errors found: 161 in 201 files If any of these errors are false positives, please file a bug against check-webkit-style.

Zan Dobersek

Comment 4 2017-04-21 04:49:23 PDT

webkit-dev thread: https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html

Zan Dobersek

Comment 5 2017-04-21 05:04:37 PDT

Created attachment 307721 [details] Patch

Build Bot

Comment 6 2017-04-21 05:17:04 PDT

Attachment 307721 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:36: "WebKit/WKBase.h" already included at Source/WebKit2/Shared/API/c/wpe/WebKit.h:31 [build/include] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:47: "WebKit/WKType.h" already included at Source/WebKit2/Shared/API/c/wpe/WebKit.h:32 [build/include] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:54: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:80: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:83: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:96: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/wpe/WebEventFactory.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:45: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:44: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEViewClient.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/PlatformWPE.cmake:48: Alphabetical sorting problem. "Platform/IPC/glib/GSocketMonitor.cpp" should be before "Platform/glib/ModuleGlib.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:71: Alphabetical sorting problem. "Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp" should be before "Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:108: Alphabetical sorting problem. "UIProcess/BackingStore.cpp" should be before "UIProcess/API/wpe/WPEViewClient.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:116: Alphabetical sorting problem. "UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp" should be before "UIProcess/InspectorServer/wpe/WebInspectorServerWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:177: Alphabetical sorting problem. "# FIXME-GWSHARE:" should be before "WebProcess/wpe/WebProcessMainWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:178: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp". [list/emptyline] [5] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:44: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:45: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:46: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:48: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:49: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:50: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:55: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:56: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:57: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:59: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:60: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:61: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:62: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:65: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:68: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:71: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:75: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:78: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:79: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/CMakeLists.txt:3999: No space before ")" [whitespace/parentheses] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WKBaseWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:128: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebCore/platform/graphics/PlatformDisplay.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/wpe/generate-inspector-gresource-manifest.py:77: blank line at end of file [pep8/W391] [5] ERROR: Tools/Scripts/webkitpy/port/wpe.py:34: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/wpe/WebEventFactory.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.cpp:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.cpp:63: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/PlatformWPE.cmake:11: Alphabetical sorting problem. "API/JSBase.h" should be before "API/JavaScript.h". [list/order] [5] ERROR: Source/WebCore/page/wpe/EventHandlerWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/wpe/EventHandlerWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/CompositingManager.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/LocalizedStringsWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/PlatformWPE.cmake:57: Alphabetical sorting problem. "page/scrolling/ScrollingStateStickyNode.cpp" should be before "page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:108: Alphabetical sorting problem. "platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp" should be before "platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:143: Alphabetical sorting problem. "# FIXME: Split build targers below into a WebCorePlatform library" should be before "platform/text/TextEncodingDetectorICU.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:144: There should be exactly one empty line instead of 0 between "# FIXME: Split build targers below into a WebCorePlatform library" and "editing/wpe/EditorWPE.cpp". [list/emptyline] [5] ERROR: Source/WebCore/PlatformWPE.cmake:154: Alphabetical sorting problem. "platform/glib/SSLKeyGeneratorGLib.cpp" should be before "platform/glib/SharedBufferGlib.cpp". [list/order] [5] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKAPICastWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:38: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:40: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/WebPageWPE.cpp:31: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:28: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:28: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:66: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:41: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:43: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:44: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/Shared/wpe/NativeWebTouchEventWPE.cpp:35: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:36: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/PlatformWPE.cmake:8: Alphabetical sorting problem. "glib/GLibUtilities.cpp" should be before "glib/GRefPtr.cpp". [list/order] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:46: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:47: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:48: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:50: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:54: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:56: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:57: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:58: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:59: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:60: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:62: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:63: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:65: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:67: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:68: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:69: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:71: "virtual" is redundant since function is already declared as "override" [readability/ inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:72: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:73: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:74: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:76: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:77: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:78: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:79: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:81: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:82: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:83: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:85: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:87: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:90: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:91: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:92: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:94: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:96: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:97: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:98: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:99: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:100: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:101: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:103: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:104: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:105: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:106: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:108: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:110: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:111: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:114: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:117: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:119: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.cpp:194: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:71: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/graphics/wpe/PlatformDisplayWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.h:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEViewClient.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:38: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:39: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:41: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:42: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:43: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:96: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:97: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:98: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:99: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] Total errors found: 161 in 209 files If any of these errors are false positives, please file a bug against check-webkit-style.

Zan Dobersek

Comment 7 2017-04-21 07:03:19 PDT

Created attachment 307726 [details] Patch Should avoid header collision with Cocoa's WebKit.h file.

Build Bot

Comment 8 2017-04-21 07:12:55 PDT

Attachment 307726 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/wpe/WebEventFactory.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:45: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:44: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEViewClient.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/PlatformWPE.cmake:48: Alphabetical sorting problem. "Platform/IPC/glib/GSocketMonitor.cpp" should be before "Platform/glib/ModuleGlib.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:71: Alphabetical sorting problem. "Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp" should be before "Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:108: Alphabetical sorting problem. "UIProcess/BackingStore.cpp" should be before "UIProcess/API/wpe/WPEViewClient.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:116: Alphabetical sorting problem. "UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp" should be before "UIProcess/InspectorServer/wpe/WebInspectorServerWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:177: Alphabetical sorting problem. "# FIXME-GWSHARE:" should be before "WebProcess/wpe/WebProcessMainWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:178: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp". [list/emptyline] [5] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:44: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:45: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:46: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:48: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:49: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:50: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:55: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:56: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:57: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:59: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:60: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:61: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:62: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:65: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:68: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:71: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:75: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:78: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:79: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/CMakeLists.txt:3999: No space before ")" [whitespace/parentheses] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WKBaseWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:128: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebCore/platform/graphics/PlatformDisplay.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/wpe/generate-inspector-gresource-manifest.py:77: blank line at end of file [pep8/W391] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:36: "WebKit/WKBase.h" already included at Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:31 [build/include] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:47: "WebKit/WKType.h" already included at Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:32 [build/include] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:54: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:80: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:83: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:96: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/Scripts/webkitpy/port/wpe.py:34: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/wpe/WebEventFactory.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.cpp:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.cpp:63: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/PlatformWPE.cmake:11: Alphabetical sorting problem. "API/JSBase.h" should be before "API/JavaScript.h". [list/order] [5] ERROR: Source/WebCore/page/wpe/EventHandlerWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/wpe/EventHandlerWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/CompositingManager.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/LocalizedStringsWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/PlatformWPE.cmake:57: Alphabetical sorting problem. "page/scrolling/ScrollingStateStickyNode.cpp" should be before "page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:108: Alphabetical sorting problem. "platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp" should be before "platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:143: Alphabetical sorting problem. "# FIXME: Split build targers below into a WebCorePlatform library" should be before "platform/text/TextEncodingDetectorICU.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:144: There should be exactly one empty line instead of 0 between "# FIXME: Split build targers below into a WebCorePlatform library" and "editing/wpe/EditorWPE.cpp". [list/emptyline] [5] ERROR: Source/WebCore/PlatformWPE.cmake:154: Alphabetical sorting problem. "platform/glib/SSLKeyGeneratorGLib.cpp" should be before "platform/glib/SharedBufferGlib.cpp". [list/order] [5] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKAPICastWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:38: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:40: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/WebPageWPE.cpp:31: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:28: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:28: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:66: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:41: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:43: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:44: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/Shared/wpe/NativeWebTouchEventWPE.cpp:35: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:36: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/PlatformWPE.cmake:8: Alphabetical sorting problem. "glib/GLibUtilities.cpp" should be before "glib/GRefPtr.cpp". [list/order] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:46: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:47: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:48: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:50: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:54: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:56: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:57: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:58: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:59: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:60: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:62: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:63: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:65: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:67: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:68: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:69: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:71: "virtual" is redundant since function is already declare d as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:72: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:73: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:74: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:76: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:77: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:78: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:79: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:81: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:82: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:83: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:85: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:87: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:90: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:91: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:92: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:94: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:96: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:97: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:98: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:99: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:100: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:101: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:103: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:104: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:105: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:106: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:108: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:110: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:111: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:114: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:117: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:119: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.cpp:194: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:71: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/graphics/wpe/PlatformDisplayWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.h:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEViewClient.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:38: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:39: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:41: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:42: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:43: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:96: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:97: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:98: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:99: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] Total errors found: 161 in 209 files If any of these errors are false positives, please file a bug against check-webkit-style.

Michael Catanzaro

Comment 9 2017-04-21 07:44:31 PDT

You do need to placate style bot, since these are all new files. I'm sure there are a couple false positives in there like whitespace/parens, but it looks like the overwhelming majority of those complaints are valid.

Zan Dobersek

Comment 10 2017-04-21 07:48:50 PDT

Created attachment 307728 [details] Patch Also undefs the BUILDING_WPE__ macro in WKBase.h post-process step in WebKit2.xcodeproj/project.pbxproj.

Build Bot

Comment 11 2017-04-21 07:53:23 PDT

Attachment 307728 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/wpe/WebEventFactory.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:45: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:44: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEViewClient.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/PlatformWPE.cmake:48: Alphabetical sorting problem. "Platform/IPC/glib/GSocketMonitor.cpp" should be before "Platform/glib/ModuleGlib.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:71: Alphabetical sorting problem. "Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp" should be before "Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:108: Alphabetical sorting problem. "UIProcess/BackingStore.cpp" should be before "UIProcess/API/wpe/WPEViewClient.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:116: Alphabetical sorting problem. "UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp" should be before "UIProcess/InspectorServer/wpe/WebInspectorServerWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:177: Alphabetical sorting problem. "# FIXME-GWSHARE:" should be before "WebProcess/wpe/WebProcessMainWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:178: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp". [list/emptyline] [5] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:44: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:45: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:46: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:48: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:49: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:50: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:55: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:56: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:57: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:59: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:60: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:61: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:62: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:65: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:68: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:71: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:75: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:78: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/DrawingAreaWPE.h:79: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/CMakeLists.txt:3999: No space before ")" [whitespace/parentheses] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WKBaseWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:128: 'protector' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebCore/platform/graphics/PlatformDisplay.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/wpe/generate-inspector-gresource-manifest.py:77: blank line at end of file [pep8/W391] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:36: "WebKit/WKBase.h" already included at Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:31 [build/include] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:47: "WebKit/WKType.h" already included at Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:32 [build/include] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:54: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:80: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:83: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WPEWebKit.h:96: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/Scripts/webkitpy/port/wpe.py:34: expected 2 blank lines, found 1 [pep8/E302] [5] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/wpe/WebEventFactory.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.cpp:56: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.cpp:63: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/PlatformWPE.cmake:11: Alphabetical sorting problem. "API/JSBase.h" should be before "API/JavaScript.h". [list/order] [5] ERROR: Source/WebCore/page/wpe/EventHandlerWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/page/wpe/EventHandlerWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/CompositingManager.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/LocalizedStringsWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/PlatformWPE.cmake:57: Alphabetical sorting problem. "page/scrolling/ScrollingStateStickyNode.cpp" should be before "page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:108: Alphabetical sorting problem. "platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp" should be before "platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:143: Alphabetical sorting problem. "# FIXME: Split build targers below into a WebCorePlatform library" should be before "platform/text/TextEncodingDetectorICU.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:144: There should be exactly one empty line instead of 0 between "# FIXME: Split build targers below into a WebCorePlatform library" and "editing/wpe/EditorWPE.cpp". [list/emptyline] [5] ERROR: Source/WebCore/PlatformWPE.cmake:154: Alphabetical sorting problem. "platform/glib/SSLKeyGeneratorGLib.cpp" should be before "platform/glib/SharedBufferGlib.cpp". [list/order] [5] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKAPICastWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:38: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ThemeWPE.h:40: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebPage/wpe/WebPageWPE.cpp:31: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:28: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:28: You should not add a blank line before implementation file's own header. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/wpe/PlatformPasteboardWPE.cpp:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Tools/WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:66: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:41: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:43: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:44: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/Shared/wpe/NativeWebTouchEventWPE.cpp:35: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:36: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/PlatformWPE.cmake:8: Alphabetical sorting problem. "glib/GLibUtilities.cpp" should be before "glib/GRefPtr.cpp". [list/order] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:46: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:47: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:48: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:50: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:51: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:54: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:56: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:57: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:58: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:59: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:60: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:62: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:63: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:65: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:67: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:68: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:69: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:71: "virtual" is redundant since function is already declare d as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:72: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:73: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:74: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:76: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:77: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:78: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:79: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:81: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:82: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:83: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:85: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:87: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:90: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:91: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:92: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:94: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:96: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:97: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:98: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:99: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:100: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:101: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:103: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:104: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:105: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:106: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:108: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:110: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:111: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:114: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:117: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.h:119: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.cpp:35: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/PageClientImpl.cpp:194: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.h:71: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/graphics/wpe/PlatformDisplayWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/DrawingAreaProxyWPE.h:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/wpe/RenderThemeWPE.cpp:30: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEViewClient.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:38: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:39: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:41: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:42: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebCore/platform/wpe/ScrollbarThemeWPE.h:43: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:96: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:97: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:98: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:99: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:52: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/CompositingManagerProxy.h:53: "virtual" is redundant since function is already declared as "override" [readability/inheritance] [4] Total errors found: 161 in 210 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 12 2017-04-21 09:24:47 PDT

Comment on attachment 307728 [details] Patch Attachment 307728 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3576579 New failing tests: webrtc/datachannel/bufferedAmountLowThreshold.html

Build Bot

Comment 13 2017-04-21 09:24:48 PDT

Created attachment 307738 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Zan Dobersek

Comment 14 2017-04-27 06:08:05 PDT

Created attachment 308384 [details] WIP patch

Build Bot

Comment 15 2017-04-27 06:11:23 PDT

Attachment 308384 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:52: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:78: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:45: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/PlatformWPE.cmake:177: Alphabetical sorting problem. "# FIXME-GWSHARE:" should be before "WebProcess/wpe/WebProcessMainWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:178: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp". [list/emptyline] [5] ERROR: Source/WebCore/CMakeLists.txt:4001: No space before ")" [whitespace/parentheses] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WKBaseWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/graphics/PlatformDisplay.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/PlatformWPE.cmake:143: Alphabetical sorting problem. "# FIXME: Split build targers below into a WebCorePlatform library" should be before "platform/text/TextEncodingDetectorICU.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:144: There should be exactly one empty line instead of 0 between "# FIXME: Split build targers below into a WebCorePlatform library" and "editing/wpe/EditorWPE.cpp". [list/emptyline] [5] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKAPICastWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:34: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 18 in 200 files If any of these errors are false positives, please file a bug against check-webkit-style.

Olivier Blin

Comment 16 2017-04-27 06:52:46 PDT

Comment on attachment 308384 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=308384&action=review > Source/WTF/wtf/glib/RunLoopSourcePriority.h:110 > DiskCacheWrite = 200, > }; > > +#elif PLATFORM(WPE) > + > +enum RunLoopSourcePriority { > + RunLoopDispatcher = -70, > + RunLoopTimer = -70, > + > + MainThreadDispatcherTimer = -60, > + > + MemoryPressureHandlerTimer = -80, > + > + JavascriptTimer = -60, > + MainThreadSharedTimer = -60, > + > + LayerFlushTimer = -70, > + DisplayRefreshMonitorTimer = -70, > + > + CompositingThreadUpdateTimer = -70, > + > + ReleaseUnusedResourcesTimer = -70, > + > + AsyncIONetwork = -70, > + DiskCacheRead = -70, > + DiskCacheWrite = -60 > +}; > + > +#endif Can this be factorized with the GTK port? Any reason to have different values? > Source/WebCore/platform/graphics/wpe/PlatformDisplayWPE.h:32 > +#define __GBM__ 1 There should be a FIXME comment about __GBM__ like in Source/WebCore/platform/graphics/GLContext.h > Source/WebCore/platform/wpe/PlatformScreenWPE.cpp:67 > +FloatRect screenRect(Widget*) > +{ > + notImplemented(); > + return FloatRect(0, 0, 1024, 640); > +} > + > +FloatRect screenAvailableRect(Widget*) > +{ > + notImplemented(); > + return FloatRect(0, 0, 1024, 640); > +} Is it intended to have different hardcoded values for the default geometry? 1024x640 here > Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:44 > +View::View(struct wpe_view_backend* backend, const API::PageConfiguration& baseConfiguration) > + : m_pageClient(std::make_unique<PageClientImpl>(*this)) > + , m_size { 800, 600 } and 800x600 here? > Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:49 > + bool platformInitialize() override > + { > + // TODO: Wrap with #ifndef NDEBUG > + if (g_getenv("WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH")) { > + g_printerr("WebProcess PID: %d\n", getpid()); > + WTF::sleep(30); > + } Maybe this can be fixed in the initial patch by adding NDEBUG guards?

Build Bot

Comment 17 2017-04-27 07:52:00 PDT

Comment on attachment 308384 [details] WIP patch Attachment 308384 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3619493 New failing tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html

Build Bot

Comment 18 2017-04-27 07:52:01 PDT

Created attachment 308388 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Zan Dobersek

Comment 19 2017-04-27 13:38:53 PDT

(In reply to Olivier Blin from comment #16) > > Can this be factorized with the GTK port? > Any reason to have different values? > We haven't settled yet on values that work for both ports. > > Source/WebCore/platform/graphics/wpe/PlatformDisplayWPE.h:32 > > +#define __GBM__ 1 > > There should be a FIXME comment about __GBM__ like in > Source/WebCore/platform/graphics/GLContext.h > I'll add it in the next round, or after it's upstream. > > Source/WebCore/platform/wpe/PlatformScreenWPE.cpp:67 > > +FloatRect screenRect(Widget*) > > +{ > > + notImplemented(); > > + return FloatRect(0, 0, 1024, 640); > > +} > > + > > +FloatRect screenAvailableRect(Widget*) > > +{ > > + notImplemented(); > > + return FloatRect(0, 0, 1024, 640); > > +} > > Is it intended to have different hardcoded values for the default geometry? > 1024x640 here > > > Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:44 > > +View::View(struct wpe_view_backend* backend, const API::PageConfiguration& baseConfiguration) > > + : m_pageClient(std::make_unique<PageClientImpl>(*this)) > > + , m_size { 800, 600 } > > and 800x600 here? > Screen geometry is mocked above, view size below. The former would need additional API, but is currently not vital for any use case. The latter normally gets resized as instructed by the application. > > Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:49 > > + bool platformInitialize() override > > + { > > + // TODO: Wrap with #ifndef NDEBUG > > + if (g_getenv("WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH")) { > > + g_printerr("WebProcess PID: %d\n", getpid()); > > + WTF::sleep(30); > > + } > > Maybe this can be fixed in the initial patch by adding NDEBUG guards? In the next round, or after it's upstreamed.

Zan Dobersek

Comment 20 2017-04-27 13:41:37 PDT

Created attachment 308438 [details] Patch

Build Bot

Comment 21 2017-04-27 13:46:16 PDT

Attachment 308438 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:52: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:78: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:45: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/PlatformWPE.cmake:472: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:177: Alphabetical sorting problem. "# FIXME-GWSHARE:" should be before "WebProcess/wpe/WebProcessMainWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:178: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp". [list/emptyline] [5] ERROR: Source/WebCore/CMakeLists.txt:4001: No space before ")" [whitespace/parentheses] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WKBaseWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/graphics/PlatformDisplay.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/PlatformWPE.cmake:143: Alphabetical sorting problem. "# FIXME: Split build targers below into a WebCorePlatform library" should be before "platform/text/TextEncodingDetectorICU.cpp". [list/order] [5] ERROR: Source/WebCore/PlatformWPE.cmake:144: There should be exactly one empty line instead of 0 between "# FIXME: Split build targers below into a WebCorePlatform library" and "editing/wpe/EditorWPE.cpp". [list/emptyline] [5] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKAPICastWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:34: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 19 in 200 files If any of these errors are false positives, please file a bug against check-webkit-style.

Zan Dobersek

Comment 22 2017-04-27 13:46:30 PDT

Created attachment 308440 [details] git diff --stat output for the specific changes

Carlos Alberto Lopez Perez

Comment 23 2017-04-27 14:13:10 PDT

(In reply to Zan Dobersek from comment #22) > Created attachment 308440 [details] > git diff --stat output for the specific changes tip: if you do git diff --stat=999 >file.txt You get lines as long as 999 width, otherwise git will cut them at <= 72

Michael Catanzaro

Comment 24 2017-04-27 14:54:29 PDT

Style checker is much happier now, but I still see some low-hanging fruit there.

Alex Christensen

Comment 25 2017-04-27 23:07:23 PDT

Comment on attachment 308438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308438&action=review I read about the first 1/4 of this. Seems pretty good so far. > Source/WebCore/CMakeLists.txt:4001 > + set(ANGLE_PLATFORM_DEFINITIONS ) This isn't necessary. > Source/WebCore/CMakeLists.txt:4003 > + list(APPEND ANGLE_PLATFORM_DEFINITIONS "USE_WPE") Let's move this definition to PlatformWPE.cmake > Source/WebCore/PlatformWPE.cmake:143 > + # FIXME: Split build targers below into a WebCorePlatform library targets I agree, there are a lot of duplicate lists here. > Source/WebCore/editing/wpe/EditorWPE.cpp:37 > +static PassRefPtr<DocumentFragment> createFragmentFromPasteboardData(Pasteboard& pasteboard, Frame& frame, Range& range, bool allowPlainText, bool& chosePlainText) Could we not add any new code with PassRefPtr unless absolutely necessary? > Source/WebCore/platform/DragImage.h:44 > +#elif PLATFORM(GTK) || PLATFORM(WPE) We should merge these into USE(CAIRO). It will probably be pretty common to have GTK || WPE and I think we will usually be needing USE(GLIB) or something. > Source/WebCore/platform/graphics/wpe/ImageWPE.cpp:37 > +PassRefPtr<Image> Image::loadPlatformResource(const char* resource) We should remove PassRefPtr from all platforms' implementations.

Zan Dobersek

Comment 26 2017-04-28 13:22:21 PDT

(In reply to Alex Christensen from comment #25) > > Source/WebCore/CMakeLists.txt:4001 > > + set(ANGLE_PLATFORM_DEFINITIONS ) > > This isn't necessary. > > > Source/WebCore/CMakeLists.txt:4003 > > + list(APPEND ANGLE_PLATFORM_DEFINITIONS "USE_WPE") > > Let's move this definition to PlatformWPE.cmake > Done. > > Source/WebCore/PlatformWPE.cmake:143 > > + # FIXME: Split build targers below into a WebCorePlatform library > > targets > I agree, there are a lot of duplicate lists here. > Moved most of those build targets (the WPE-specific ones) into WebCorePlatformWPE library, the rest remain listed there. > > Source/WebCore/editing/wpe/EditorWPE.cpp:37 > > +static PassRefPtr<DocumentFragment> createFragmentFromPasteboardData(Pasteboard& pasteboard, Frame& frame, Range& range, bool allowPlainText, bool& chosePlainText) > > Could we not add any new code with PassRefPtr unless absolutely necessary? > Sure, now uses RefPtr<>. > > Source/WebCore/platform/DragImage.h:44 > > +#elif PLATFORM(GTK) || PLATFORM(WPE) > > We should merge these into USE(CAIRO). It will probably be pretty common to > have GTK || WPE and I think we will usually be needing USE(GLIB) or > something. > It depends on the context, e.g. in CryptoKey* files we'd be using USE(LIBGCRYPT), but that flag doesn't exist (yet). But yes, given that the ports will be sharing a lot of the internals, we'll try to find a single flag. > > Source/WebCore/platform/graphics/wpe/ImageWPE.cpp:37 > > +PassRefPtr<Image> Image::loadPlatformResource(const char* resource) > > We should remove PassRefPtr from all platforms' implementations. Agreed, but I don't want to touch cross-port implementations in this patch.

Zan Dobersek

Comment 27 2017-04-28 13:28:27 PDT

(In reply to Michael Catanzaro from comment #24) > Style checker is much happier now, but I still see some low-hanging fruit > there. A few of those errors are bugs, and in some cases the necessary include order has to be preserved.

Zan Dobersek

Comment 28 2017-04-28 13:29:24 PDT

Created attachment 308589 [details] \

Zan Dobersek

Comment 29 2017-04-28 13:30:16 PDT

Created attachment 308590 [details] Patch

Zan Dobersek

Comment 30 2017-04-28 13:31:21 PDT

Created attachment 308591 [details] git diff --stat output for the specific changes

Build Bot

Comment 31 2017-04-28 13:33:42 PDT

Attachment 308590 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:52: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:78: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:45: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/PlatformWPE.cmake:177: Alphabetical sorting problem. "# FIXME-GWSHARE:" should be before "WebProcess/wpe/WebProcessMainWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:178: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp". [list/emptyline] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WKBaseWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/graphics/PlatformDisplay.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKAPICastWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:34: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 15 in 208 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 32 2017-04-28 14:43:44 PDT

Comment on attachment 308590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308590&action=review > Source/WTF/wtf/Platform.h:627 > +#if PLATFORM(COCOA) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(WPE) > #define HAVE_ACCESSIBILITY 1 This is everybody! We should consider removing the HAVE(ACCESSIBILITY) macros unless someone has a reason they want to maintain a build without accessibility. > Source/WTF/wtf/Platform.h:1081 > +#if PLATFORM(COCOA) || PLATFORM(GTK) || PLATFORM(WPE) || (PLATFORM(WIN) && !USE(WINGDI)) > #define USE_REQUEST_ANIMATION_FRAME_TIMER 1 Same with this. USE(WINGDI) was true with the WinCE port which was removed years ago. There's cleanup we could do after this. > Source/WebCore/PlatformWPE.cmake:7 > +if (PORT STREQUAL "WPE") This check isn't needed in PlatformWPE.cmake. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:240 > + ::glFlush(); Let's not add this in this patch. We're trying to reduce the required number of calls to glFlush. If it's really needed, let's do it in a separate patch. > Source/WebCore/platform/graphics/wpe/ImageWPE.cpp:37 > +PassRefPtr<Image> Image::loadPlatformResource(const char* resource) Yeah, making this RefPtr would require refactoring that we shouldn't do in this patch. Let's do it soon, though. > Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:79 > +#if PLATFORM(GTK) || PLATFORM(WPE) > m_threadCountLimit = 1; Aren't GTK and now WPE the only ports using CoordinatedGraphics in WebKit2 now? > Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:63 > +class ThreadedCompositor : public CoordinatedGraphicsSceneClient, public ThreadSafeRefCounted<ThreadedCompositor> > +#if PLATFORM(WPE) > + , public WebCore::PlatformDisplayWPE::EGLTarget::Client This feels like it's not designed well if we need a new type of client just for one platform. This has led to problems before. > Source/WebKit2/WebProcess/WebPage/wpe/CompositingManager.h:44 > + int m_connectionFd { -1 }; Would std::optional<int> make sense here? std::optional<unsigned>?

Zan Dobersek

Comment 33 2017-05-04 01:10:33 PDT

Comment on attachment 308590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308590&action=review >> Source/WebCore/PlatformWPE.cmake:7 >> +if (PORT STREQUAL "WPE") > > This check isn't needed in PlatformWPE.cmake. Removed. >> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:240 >> + ::glFlush(); > > Let's not add this in this patch. We're trying to reduce the required number of calls to glFlush. If it's really needed, let's do it in a separate patch. Opened bug #171647. >> Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:79 >> m_threadCountLimit = 1; > > Aren't GTK and now WPE the only ports using CoordinatedGraphics in WebKit2 now? They are. I can remove the guards, taking 1 as the default limit, and add a FIXME to make this limit configurable in the future. >> Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:63 >> + , public WebCore::PlatformDisplayWPE::EGLTarget::Client > > This feels like it's not designed well if we need a new type of client just for one platform. This has led to problems before. It's the best we can do at the moment, before we move the GTK+ stack on top of WPE and potentially make the CoordinatedGraphics subsystem explicitly exclusive to the WPE and GTK+ ports. >> Source/WebKit2/WebProcess/WebPage/wpe/CompositingManager.h:44 >> + int m_connectionFd { -1 }; > > Would std::optional<int> make sense here? std::optional<unsigned>? std::optional<> would make sense, not yet sure about the embedded type.

Zan Dobersek

Comment 34 2017-05-04 02:32:05 PDT

Created attachment 309027 [details] Patch

Zan Dobersek

Comment 35 2017-05-04 02:33:30 PDT

Created attachment 309028 [details] git diff --stat output

Build Bot

Comment 36 2017-05-04 02:35:55 PDT

Attachment 309027 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:52: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:78: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:45: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/PlatformWPE.cmake:177: Alphabetical sorting problem. "# FIXME-GWSHARE:" should be before "WebProcess/wpe/WebProcessMainWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:178: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp". [list/emptyline] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WKBaseWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/graphics/PlatformDisplay.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKAPICastWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:34: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 15 in 208 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 37 2017-05-08 08:56:34 PDT

Comment on attachment 309027 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309027&action=review What, nobody reviewed this? Let's land this. r=me > Source/WebKit2/UIProcess/InspectorServer/wpe/WebInspectorServerWPE.cpp:94 > +void WebInspectorServer::buildPageList(Vector<char>& data, String& contentType) > +{ > + // chromedevtools (http://code.google.com/p/chromedevtools) 0.3.8 expected JSON format: This is strange. First of all, platformResourceForPath seems to only be called in one place from WebInspectorServer.cpp, and there isn't an existing implementation, so how does that work? Second, we are trying to move away from passing return values in as references in parameters. Third, why are we trying to match the Chrome devtools JSON format? Are people using Chrome devtools with WPE WebKit? I'm not sure that's something we want to support. If it is, we should add this in another patch and add tests. > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:265 > + bool shouldPaintBrokenImage(const WebCore::URL&) const override; This doesn't seem to be called. Can it be added later if needed? > Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:92 > + This space is inconsistent. I don't think it should be here. The lack of space here indicates that all these functions have to do with the pasteboard stuff. > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:428 > + if options.platform in ["efl", "gtk", "wpe"]: we need to go through all the tools and remove efl stuff.

Zan Dobersek

Comment 38 2017-05-09 00:25:32 PDT

Comment on attachment 309027 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309027&action=review >> Source/WebKit2/UIProcess/InspectorServer/wpe/WebInspectorServerWPE.cpp:94 >> + // chromedevtools (http://code.google.com/p/chromedevtools) 0.3.8 expected JSON format: > > This is strange. First of all, platformResourceForPath seems to only be called in one place from WebInspectorServer.cpp, and there isn't an existing implementation, so how does that work? Second, we are trying to move away from passing return values in as references in parameters. Third, why are we trying to match the Chrome devtools JSON format? Are people using Chrome devtools with WPE WebKit? I'm not sure that's something we want to support. If it is, we should add this in another patch and add tests. This WebInspectorServer stuff is a legacy way of loading the Web Inspector remotely. The GTK+ port switched over to using the remote inspector stack, and WPE will follow closely. That said, I can't ensure we'll be able to completely drop WebInspectorServer, but it should be upstreamed separately later, if necessary. No idea about the Chrome dev tools JSON format, it maybe used to conform to that, but I suspect it wouldn't work this way anymore. >> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:265 >> + bool shouldPaintBrokenImage(const WebCore::URL&) const override; > > This doesn't seem to be called. Can it be added later if needed? OK. >> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:92 >> + > > This space is inconsistent. I don't think it should be here. The lack of space here indicates that all these functions have to do with the pasteboard stuff. OK. >> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:428 >> + if options.platform in ["efl", "gtk", "wpe"]: > > we need to go through all the tools and remove efl stuff. Yes.

Zan Dobersek

Comment 39 2017-05-09 00:57:44 PDT

Created attachment 309485 [details] Patch for landing

Build Bot

Comment 40 2017-05-09 01:02:24 PDT

Attachment 309485 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:52: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/Shared/API/c/wpe/WebKit.h:78: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/wpe/WPEView.cpp:45: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/PlatformWPE.cmake:175: Alphabetical sorting problem. "# FIXME-GWSHARE:" should be before "WebProcess/wpe/WebProcessMainWPE.cpp". [list/order] [5] ERROR: Source/WebKit2/PlatformWPE.cmake:176: There should be exactly one empty line instead of 0 between "# FIXME-GWSHARE:" and "DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp". [list/emptyline] [5] ERROR: Source/WebKit2/Shared/API/c/wpe/WKBaseWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/platform/graphics/PlatformDisplay.h:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKAPICastWPE.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:29: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit2/WebProcess/wpe/WebProcessMainWPE.cpp:34: Streams are highly discouraged. [readability/streams] [3] ERROR: Source/WebKit2/UIProcess/API/C/wpe/WKView.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 15 in 205 files If any of these errors are false positives, please file a bug against check-webkit-style.

Zan Dobersek

Comment 41 2017-05-09 04:08:02 PDT

Comment on attachment 309485 [details] Patch for landing Clearing flags on attachment: 309485 Committed r216497: <http://trac.webkit.org/changeset/216497>

Zan Dobersek

Comment 42 2017-05-09 04:08:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Zan Dobersek

Reported

2017-04-21 04:39 PDT

Modified

2017-06-14 10:11 PDT History

CC List

14 users Show

URL

Keywords

Depends on

Blocks