Bug 172693 - Add a WPE EWS queue
Summary: Add a WPE EWS queue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-29 15:15 PDT by Carlos Alberto Lopez Perez
Modified: 2018-06-15 09:17 PDT (History)
13 users (show)

See Also:


Attachments
Patch (6.92 KB, patch)
2017-05-29 15:38 PDT, Carlos Alberto Lopez Perez
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-05-29 15:15:38 PDT
Adding a WPE EWS queue will help to detect WPE build failures early.
Comment 1 Carlos Alberto Lopez Perez 2017-05-29 15:38:50 PDT
Created attachment 311486 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-05-29 23:56:27 PDT
Comment on attachment 311486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311486&action=review

> Tools/QueueStatusServer/config/queues.py:46
> +    "wpe-wk2-ews",

Why not just wpe-ews? gtk one has the -wk2 for historical reasons, but wpe has always been wk2 only.
Comment 3 Carlos Alberto Lopez Perez 2017-05-30 07:25:57 PDT
(In reply to Carlos Garcia Campos from comment #2)
> Comment on attachment 311486 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311486&action=review
> 
> > Tools/QueueStatusServer/config/queues.py:46
> > +    "wpe-wk2-ews",
> 
> Why not just wpe-ews? gtk one has the -wk2 for historical reasons, but wpe
> has always been wk2 only.

I thought this was consistent with the other port naming policies.

But I can see how the ios-ews doesn't contain wk2 on the name or on the handle and AFAIK is a wk2 port.

So, I will remove the wk2 strings for wpe on this patch before landing.
Comment 4 Carlos Alberto Lopez Perez 2017-05-30 07:43:51 PDT
Committed r217555: <http://trac.webkit.org/changeset/217555>
Comment 5 Aakash Jain 2017-05-30 16:09:44 PDT
Updated webkit-queues server to pick up the changes. the queue is now visible at https://webkit-queues.webkit.org/queue-status/wpe-ews
Comment 6 Carlos Alberto Lopez Perez 2017-05-30 16:43:56 PDT
(In reply to Aakash Jain from comment #5)
> Updated webkit-queues server to pick up the changes. the queue is now
> visible at https://webkit-queues.webkit.org/queue-status/wpe-ews

Amazing! 

Thanks a lot :)
Comment 7 Radar WebKit Bug Importer 2017-05-30 20:19:13 PDT
<rdar://problem/32479644>