WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172693
Add a WPE EWS queue
https://bugs.webkit.org/show_bug.cgi?id=172693
Summary
Add a WPE EWS queue
Carlos Alberto Lopez Perez
Reported
2017-05-29 15:15:38 PDT
Adding a WPE EWS queue will help to detect WPE build failures early.
Attachments
Patch
(6.92 KB, patch)
2017-05-29 15:38 PDT
,
Carlos Alberto Lopez Perez
cgarcia
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2017-05-29 15:38:50 PDT
Created
attachment 311486
[details]
Patch
Carlos Garcia Campos
Comment 2
2017-05-29 23:56:27 PDT
Comment on
attachment 311486
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=311486&action=review
> Tools/QueueStatusServer/config/queues.py:46 > + "wpe-wk2-ews",
Why not just wpe-ews? gtk one has the -wk2 for historical reasons, but wpe has always been wk2 only.
Carlos Alberto Lopez Perez
Comment 3
2017-05-30 07:25:57 PDT
(In reply to Carlos Garcia Campos from
comment #2
)
> Comment on
attachment 311486
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=311486&action=review
> > > Tools/QueueStatusServer/config/queues.py:46 > > + "wpe-wk2-ews", > > Why not just wpe-ews? gtk one has the -wk2 for historical reasons, but wpe > has always been wk2 only.
I thought this was consistent with the other port naming policies. But I can see how the ios-ews doesn't contain wk2 on the name or on the handle and AFAIK is a wk2 port. So, I will remove the wk2 strings for wpe on this patch before landing.
Carlos Alberto Lopez Perez
Comment 4
2017-05-30 07:43:51 PDT
Committed
r217555
: <
http://trac.webkit.org/changeset/217555
>
Aakash Jain
Comment 5
2017-05-30 16:09:44 PDT
Updated webkit-queues server to pick up the changes. the queue is now visible at
https://webkit-queues.webkit.org/queue-status/wpe-ews
Carlos Alberto Lopez Perez
Comment 6
2017-05-30 16:43:56 PDT
(In reply to Aakash Jain from
comment #5
)
> Updated webkit-queues server to pick up the changes. the queue is now > visible at
https://webkit-queues.webkit.org/queue-status/wpe-ews
Amazing! Thanks a lot :)
Radar WebKit Bug Importer
Comment 7
2017-05-30 20:19:13 PDT
<
rdar://problem/32479644
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug