Bug 172212 – Import the css-display-3 w3c tests for display: contents

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Emilio Cobos Álvarez]

Depends on bug 171984, but I'll post the patch here anyway.

[Emilio Cobos Álvarez]

Created attachment 310360 [details]
Patch

[Build Bot]

Attachment 310360 [details] did not pass style-queue:


ERROR: LayoutTests/TestExpectations:1153:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/TestExpectations:1154:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/TestExpectations:1155:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/TestExpectations:1156:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/TestExpectations:1157:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/TestExpectations:1158:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 6 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Emilio Cobos Álvarez]

Created attachment 310362 [details]
Patch

[Build Bot]

Comment on attachment 310362 [details]
Patch

Attachment 310362 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3760967

New failing tests:
imported/w3c/web-platform-tests/css/css-display-3/display-contents-computed-style.html

[Build Bot]

Created attachment 310373 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310362 [details]
Patch

Attachment 310362 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3761570

New failing tests:
imported/w3c/web-platform-tests/css/css-display-3/display-contents-td-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-flex-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-text-only-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-first-letter-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-oof-002.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-float-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-001-inline.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-inline-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-oof-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-tr-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-block-001.html

[Build Bot]

Created attachment 310375 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310362 [details]
Patch

Attachment 310362 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3761062

New failing tests:
imported/w3c/web-platform-tests/css/css-display-3/display-contents-td-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-flex-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-text-only-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-first-letter-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-oof-002.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-float-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-001-inline.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-inline-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-oof-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-tr-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-block-001.html

[Build Bot]

Created attachment 310376 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310362 [details]
Patch

Attachment 310362 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3762238

New failing tests:
imported/w3c/web-platform-tests/css/css-display-3/display-contents-computed-style.html

[Build Bot]

Created attachment 310384 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Emilio Cobos Álvarez]

Created attachment 311008 [details]
Patch

[Emilio Cobos Álvarez]

Hi Antti, could you review the attached patch?

Thanks for all the other reviews btw :)

[Chris Dumez]

Comment on attachment 311008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311008&action=review

r=me with comment.

> LayoutTests/TestExpectations:1169
> +webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline.html [ Crash ]

I think crashes deserve their own bugzilla bugs with the stack traces.

[Emilio Cobos Álvarez]

Created attachment 311017 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 311017 [details]
Patch

Clearing flags on attachment: 311017

Committed r217280: <http://trac.webkit.org/changeset/217280>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.