Bug 172212 - Import the css-display-3 w3c tests for display: contents
Summary: Import the css-display-3 w3c tests for display: contents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 171984
Blocks: 172215
  Show dependency tree / graph
 
Reported: 2017-05-17 01:48 PDT by Emilio Cobos Álvarez
Modified: 2017-05-23 11:35 PDT (History)
6 users (show)

See Also:

Attachments
Patch (160.44 KB, patch)
2017-05-17 01:51 PDT, Emilio Cobos Álvarez 		no flags Details | Formatted Diff | Diff
Patch (160.44 KB, patch)
2017-05-17 02:05 PDT, Emilio Cobos Álvarez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-elcapitan (1.94 MB, application/zip)
2017-05-17 03:27 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.26 MB, application/zip)
2017-05-17 03:39 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.28 MB, application/zip)
2017-05-17 03:40 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews100 for mac-elcapitan (1.24 MB, application/zip)
2017-05-17 05:55 PDT, Build Bot 		no flags Details
Patch (160.41 KB, patch)
2017-05-23 07:22 PDT, Emilio Cobos Álvarez 		no flags Details | Formatted Diff | Diff
Patch (160.41 KB, patch)
2017-05-23 09:09 PDT, Emilio Cobos Álvarez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez 2017-05-17 01:48:04 PDT 
Depends on bug 171984, but I'll post the patch here anyway.
Comment 1 Emilio Cobos Álvarez 2017-05-17 01:51:34 PDT 
Created attachment 310360 [details]
Patch
Comment 2 Build Bot 2017-05-17 01:55:54 PDT 
Attachment 310360 [details] did not pass style-queue:


ERROR: LayoutTests/TestExpectations:1153:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/TestExpectations:1154:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/TestExpectations:1155:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/TestExpectations:1156:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/TestExpectations:1157:  Line contains tab character.  [whitespace/tab] [5]
ERROR: LayoutTests/TestExpectations:1158:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 6 in 100 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Emilio Cobos Álvarez 2017-05-17 02:05:13 PDT 
Created attachment 310362 [details]
Patch
Comment 4 Build Bot 2017-05-17 03:27:46 PDT 
Comment on attachment 310362 [details]
Patch

Attachment 310362 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3760967

New failing tests:
imported/w3c/web-platform-tests/css/css-display-3/display-contents-computed-style.html
Comment 5 Build Bot 2017-05-17 03:27:47 PDT 
Created attachment 310373 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-05-17 03:39:24 PDT 
Comment on attachment 310362 [details]
Patch

Attachment 310362 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3761570

New failing tests:
imported/w3c/web-platform-tests/css/css-display-3/display-contents-td-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-flex-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-text-only-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-first-letter-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-oof-002.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-float-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-001-inline.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-inline-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-oof-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-tr-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-block-001.html
Comment 7 Build Bot 2017-05-17 03:39:25 PDT 
Created attachment 310375 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-05-17 03:40:13 PDT 
Comment on attachment 310362 [details]
Patch

Attachment 310362 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3761062

New failing tests:
imported/w3c/web-platform-tests/css/css-display-3/display-contents-td-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-flex-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-text-only-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-first-letter-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-oof-002.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-float-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-001-inline.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-inline-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-oof-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-tr-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-block-001.html
Comment 9 Build Bot 2017-05-17 03:40:14 PDT 
Created attachment 310376 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Build Bot 2017-05-17 05:55:03 PDT 
Comment on attachment 310362 [details]
Patch

Attachment 310362 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3762238

New failing tests:
imported/w3c/web-platform-tests/css/css-display-3/display-contents-computed-style.html
Comment 11 Build Bot 2017-05-17 05:55:04 PDT 
Created attachment 310384 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 12 Emilio Cobos Álvarez 2017-05-23 07:22:45 PDT 
Created attachment 311008 [details]
Patch
Comment 13 Emilio Cobos Álvarez 2017-05-23 08:09:24 PDT 
Hi Antti, could you review the attached patch?

Thanks for all the other reviews btw :)
Comment 14 Chris Dumez 2017-05-23 08:52:10 PDT 
Comment on attachment 311008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311008&action=review

r=me with comment.

> LayoutTests/TestExpectations:1169
> +webkit.org/b/157477 imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline.html [ Crash ]

I think crashes deserve their own bugzilla bugs with the stack traces.
Comment 15 Emilio Cobos Álvarez 2017-05-23 09:09:13 PDT 
Created attachment 311017 [details]
Patch
Comment 16 WebKit Commit Bot 2017-05-23 09:27:40 PDT 
Comment on attachment 311017 [details]
Patch

Clearing flags on attachment: 311017

Committed r217280: <http://trac.webkit.org/changeset/217280>
Comment 17 WebKit Commit Bot 2017-05-23 09:27:42 PDT 
All reviewed patches have been landed.  Closing bug.