Bug 172215 - Use the parent box style to adjust RenderStyle for alignment.
Summary: Use the parent box style to adjust RenderStyle for alignment.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 171984 172212
Blocks:
  Show dependency tree / graph
 
Reported: 2017-05-17 03:37 PDT by Emilio Cobos Álvarez
Modified: 2017-05-30 20:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.50 KB, patch)
2017-05-17 03:44 PDT, Emilio Cobos Álvarez 		no flags Details | Formatted Diff | Diff
Patch (7.44 KB, patch)
2017-05-23 11:08 PDT, Emilio Cobos Álvarez 		no flags Details | Formatted Diff | Diff
Patch (7.45 KB, patch)
2017-05-29 04:40 PDT, Emilio Cobos Álvarez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (11.60 MB, application/zip)
2017-05-29 06:05 PDT, Build Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez 2017-05-17 03:37:46 PDT 
Blocked on the display contents RuntimeEnabledFeature (bug 171984), and the css-display-3 tests (bug 172212).
Comment 1 Emilio Cobos Álvarez 2017-05-17 03:44:49 PDT 
Created attachment 310377 [details]
Patch
Comment 2 Emilio Cobos Álvarez 2017-05-23 11:08:06 PDT 
Created attachment 311027 [details]
Patch
Comment 3 Emilio Cobos Álvarez 2017-05-29 04:40:27 PDT 
Created attachment 311467 [details]
Patch
Comment 4 Build Bot 2017-05-29 06:05:28 PDT 
Comment on attachment 311467 [details]
Patch

Attachment 311467 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3836830

New failing tests:
webrtc/peer-connection-audio-mute.html
Comment 5 Build Bot 2017-05-29 06:05:30 PDT 
Created attachment 311470 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 6 Emilio Cobos Álvarez 2017-05-29 06:28:43 PDT 
(In reply to Build Bot from comment #4)
> Comment on attachment 311467 [details]
> Patch
> 
> Attachment 311467 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/3836830
> 
> New failing tests:
> webrtc/peer-connection-audio-mute.html

That definitely doesn't sound related to my changes :-).

Is there any way of retrying it or something?
Comment 7 WebKit Commit Bot 2017-05-29 07:09:41 PDT 
Comment on attachment 311467 [details]
Patch

Clearing flags on attachment: 311467

Committed r217536: <http://trac.webkit.org/changeset/217536>
Comment 8 WebKit Commit Bot 2017-05-29 07:09:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Antti Koivisto 2017-05-29 07:11:03 PDT 
You can set cq+ again.
Comment 10 Radar WebKit Bug Importer 2017-05-30 20:27:43 PDT 
<rdar://problem/32479836>