Bug 170556 – REGRESSION (r209882): Web Inspector: Console's filter bar has text search field, but the next/previous buttons don't do anything

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

We should remove these until we plan to actually make this a find bar instead of a filter bar (e.g., https://bugs.webkit.org/show_bug.cgi?id=164847).

[Radar WebKit Bug Importer]

<rdar://problem/31481755>

[Nikita Vasilyev]

This broke in https://trac.webkit.org/changeset/209882/webkit.

[Nikita Vasilyev]

From UserInterface/Views/FindBanner.js:

    set numberOfResults(numberOfResults)
    {
        if (numberOfResults === undefined || isNaN(numberOfResults))
            numberOfResults = null;

        this._numberOfResults = numberOfResults;

        this._previousResultButton.disabled = this._nextResultButton.disabled = (numberOfResults <= 0);


It appears that when searching in Console tab, next/previous buttons of an instance of WebInspector.FindBanner gets disabled as expected. That problem is that it's a wrong instance of WebInspector.FindBanner, one that isn't even attached to the DOM.

    this._previousResultButton.parentNode // null

[Nikita Vasilyev]

My comment above might be unrelated to this bug.

See https://bugs.webkit.org/show_bug.cgi?id=164047#c10 for the cause of this regression.

[Nikita Vasilyev]

Created attachment 307503 [details]
Patch

[Matt Baker]

Comment on attachment 307503 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 307503 [details]
Patch

Clearing flags on attachment: 307503

Committed r215543: <http://trac.webkit.org/changeset/215543>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.