WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
170555
REGRESSION (
r209882
): Web Inspector: Command-G does not work in the console
https://bugs.webkit.org/show_bug.cgi?id=170555
Summary
REGRESSION (r209882): Web Inspector: Command-G does not work in the console
Blaze Burg
Reported
2017-04-06 10:48:24 PDT
------- Inspected URL: any Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/604.1.16+ (KHTML, like Gecko) Uncaught Exceptions: - TypeError: this.delegate.highlightNextSearchMatch is not a function. (In 'this.delegate.highlightNextSearchMatch()', 'this.delegate.highlightNextSearchMatch' is undefined) (at JavaScriptLogViewController.js:260:47) _handleFindNextShortcut @ JavaScriptLogViewController.js:260:47 _handleFindNextShortcut @ [native code] _handleKeyDown @ KeyboardShortcut.js:84:42 ------- * STEPS TO REPRODUCE 1. Go to Console tab 2. Add some results so it's not empty 3. Search for a string with no results using Console find bar 4. Cmd-g => Boom This seems to work as expected if there is a matching search result being highlighted.
Attachments
Patch
(2.19 KB, patch)
2017-04-24 18:05 PDT
,
Nikita Vasilyev
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-04-06 10:49:17 PDT
<
rdar://problem/31481247
>
Nikita Vasilyev
Comment 2
2017-04-24 17:18:51 PDT
I’m unable to reproduce the bug. Steps I tried: 1. Open
https://webkit.org
2. Go to Console tab 3. Type “foo” in the console, press Enter 4. Press Commang-F, type “bar” 5. Press Commang-G Please let me know if I missed something.
Nikita Vasilyev
Comment 3
2017-04-24 17:27:01 PDT
I was able to reproduce once. I'm not sure how it happened :) _handleFindNextShortcut() { this.delegate.highlightNextSearchMatch(); } highlightNextSearchMatch is not defined anywhere in Web Inspector front-end.
Nikita Vasilyev
Comment 4
2017-04-24 17:38:33 PDT
Steps to reproduce the bug: 1. Go to Console tab 2. Click on the console content view (any message in the console, for example) 3. Press Commang-G this.delegate.highlightNextSearchMatch() was added in 2013 when Web Inspector was open sourced back to WebKit. At some point highlightNextSearchMatch was removed.
Nikita Vasilyev
Comment 5
2017-04-24 17:47:23 PDT
By using git log -c -S'highlightNextSearchMatch' -- Source/WebInspectorUI I found out that it was removed in
https://bugs.webkit.org/show_bug.cgi?id=164047#c12
.
Nikita Vasilyev
Comment 6
2017-04-24 18:05:13 PDT
Created
attachment 308031
[details]
Patch
Blaze Burg
Comment 7
2017-04-25 23:08:09 PDT
Comment on
attachment 308031
[details]
Patch r=me
WebKit Commit Bot
Comment 8
2017-04-25 23:39:03 PDT
Comment on
attachment 308031
[details]
Patch Clearing flags on attachment: 308031 Committed
r215795
: <
http://trac.webkit.org/changeset/215795
>
WebKit Commit Bot
Comment 9
2017-04-25 23:39:05 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug