Bug 164047 - Web Inspector: console search bar jumps, behaves poorly at narrow widths
Summary: Web Inspector: console search bar jumps, behaves poorly at narrow widths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: 165211
  Show dependency treegraph
 
Reported: 2016-10-26 17:13 PDT by BJ Burg
Modified: 2017-04-24 17:45 PDT (History)
5 users (show)

See Also:


Attachments
narrow-console-sad.mov (12.83 MB, video/quicktime)
2016-10-26 17:13 PDT, BJ Burg
no flags Details
[Video] New find banner behavior (271.25 KB, video/mp4)
2016-12-15 14:11 PST, Matt Baker
no flags Details
Patch (18.79 KB, patch)
2016-12-15 14:55 PST, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-10-26 17:13:19 PDT
Created attachment 292977 [details]
narrow-console-sad.mov

See the video.

- The find field should not move around while typing. This is really jarring.
- If there are results, the "NN results" text will push the text field to the right, making trash can and chevron to be hidden.
- If the window is quite narrow, the "NN results" text will take up too much space and cause the filter bar to be hidden.

If anything, we should consider moving the find banner to resemble find-in-page, to show up below the console bar. There's really no good way to make the text bar not jump around when it's in the middle of a flexbox context.
Comment 1 Radar WebKit Bug Importer 2016-11-01 17:03:32 PDT
<rdar://problem/29055582>
Comment 2 Matt Baker 2016-12-14 16:12:50 PST
If the find banner is made to resemble find-in-page, would this also apply to the Console tab where horizontal space isn't as limited?
Comment 3 Matt Baker 2016-12-15 14:11:16 PST
Created attachment 297220 [details]
[Video] New find banner behavior
Comment 4 Nikita Vasilyev 2016-12-15 14:24:29 PST
(In reply to comment #3)
> Created attachment 297220 [details]
> [Video] New find banner behavior

Is there a new keyboard shortcut to search in the split console?

Does this resolve "Bug 164847 - Web Inspector: Provide search for Console, not just filtering"?
Comment 5 Matt Baker 2016-12-15 14:27:35 PST
(In reply to comment #4)
> (In reply to comment #3)
> > Created attachment 297220 [details]
> > [Video] New find banner behavior
> 
> Is there a new keyboard shortcut to search in the split console?

Its also Command-F, it just depends on the focus. If the quick console or the log content area has the focus, the find banner appears in the console drawer.

> Does this resolve "Bug 164847 - Web Inspector: Provide search for Console,
> not just filtering"?

It does not.
Comment 6 Nikita Vasilyev 2016-12-15 14:31:03 PST
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Created attachment 297220 [details]
> > > [Video] New find banner behavior
> > 
> > Is there a new keyboard shortcut to search in the split console?
> 
> Its also Command-F, it just depends on the focus. If the quick console or
> the log content area has the focus, the find banner appears in the console
> drawer.

I like it. I wonder if there's a reason we didn't do this before.
Comment 7 Matt Baker 2016-12-15 14:55:53 PST
Created attachment 297225 [details]
Patch
Comment 8 WebKit Commit Bot 2016-12-15 15:53:19 PST
Comment on attachment 297225 [details]
Patch

Clearing flags on attachment: 297225

Committed r209882: <http://trac.webkit.org/changeset/209882>
Comment 9 WebKit Commit Bot 2016-12-15 15:53:24 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Nikita Vasilyev 2017-04-18 18:37:54 PDT
Comment on attachment 297225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297225&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-941
> -        this._findBanner.numberOfResults = numberOfResults;

Removing this caused Bug 170556 - REGRESSION (r209882): Web Inspector: Console's filter bar has text search field, but the next/previous buttons don't do anything.

Matt, could you explain why this change was needed?
Comment 11 Matt Baker 2017-04-18 20:17:54 PDT
Comment on attachment 297225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297225&action=review

>> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-941
>> -        this._findBanner.numberOfResults = numberOfResults;
> 
> Removing this caused Bug 170556 - REGRESSION (r209882): Web Inspector: Console's filter bar has text search field, but the next/previous buttons don't do anything.
> 
> Matt, could you explain why this change was needed?

I looked over my patch, and don't see any reason for it. Looks like a mistake. Adding it back fixes https://bugs.webkit.org/show_bug.cgi?id=170556.
Comment 12 Nikita Vasilyev 2017-04-24 17:45:31 PDT
Comment on attachment 297225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297225&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-233
> -        this.highlightNextSearchMatch();
> -    }
> -
> -    highlightNextSearchMatch()
> -    {

Removing highlightNextSearchMatch method caused:
Bug 170555 - Uncaught Exception: TypeError: this.delegate.highlightNextSearchMatch is not a function. (In 'this.delegate.highlightNextSearchMatch()', 'this.delegate.highlightNextSearchMatch' is undefined)

highlightNextSearchMatch is used by JavaScriptLogViewController.