In this example, the word “test” used to be centered horizontally on the page. Now it isn’t: <html style="display: flex; flex-direction: column; justify-content: center; align-items: center;"><body>test</body></html>
Here’s an example with divs (showing this isn’t something special about html or body): <div style="display: flex; flex-direction: column; justify-content: center; align-items: center;"><div style="border:solid">test</div></div>
Simpler: <div style="display: flex; flex-direction: column; align-items: center;"><div style="border:solid">test</div></div>
<rdar://problem/30873895>
<rdar://problem/30873913>
Created attachment 303543 [details] Patch
rdar://problem/30791206
Comment on attachment 303543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303543&action=review > Source/WebCore/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + Added new test in css3/flexbox. Would be nice to reference the blink commit(s) that this came from.
Comment on attachment 303543 [details] Patch Attachment 303543 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3254240 New failing tests: fast/forms/searchfield-heights.html fast/forms/search/search-padding-cancel-results-buttons.html fast/forms/placeholder-pseudo-style.html fast/forms/search-vertical-alignment.html fast/repaint/justify-items-overflow-change.html fast/forms/search-cancel-button-style-sharing.html fast/repaint/align-items-overflow-change.html fast/replaced/width100percent-searchfield.html fast/forms/control-restrict-line-height.html fast/forms/search-display-none-cancel-button.html fast/repaint/justify-items-legacy-change.html fast/css/text-input-with-webkit-border-radius.html fast/forms/placeholder-position.html fast/forms/box-shadow-override.html fast/repaint/align-items-change.html fast/css/focus-ring-exists-for-search-field.html fast/forms/search-rtl.html fast/forms/search-input-rtl.html fast/repaint/justify-items-change.html fast/forms/search-styled.html fast/css/text-overflow-input.html fast/repaint/search-field-cancel.html fast/forms/input-appearance-height.html fast/forms/search/search-size-with-decorations.html
Created attachment 303552 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 303543 [details] Patch Attachment 303543 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3254227 New failing tests: fast/forms/searchfield-heights.html fast/forms/search/search-padding-cancel-results-buttons.html fast/forms/placeholder-pseudo-style.html fast/forms/search-vertical-alignment.html fast/repaint/justify-items-overflow-change.html fast/forms/search-cancel-button-style-sharing.html fast/repaint/align-items-overflow-change.html fast/replaced/width100percent-searchfield.html fast/forms/control-restrict-line-height.html fast/forms/search-display-none-cancel-button.html fast/repaint/justify-items-legacy-change.html fast/css/text-input-with-webkit-border-radius.html fast/forms/placeholder-position.html fast/forms/box-shadow-override.html fast/repaint/align-items-change.html fast/css/focus-ring-exists-for-search-field.html fast/forms/search-rtl.html fast/forms/search-input-rtl.html fast/repaint/justify-items-change.html fast/forms/search-styled.html fast/css/text-overflow-input.html fast/repaint/search-field-cancel.html fast/forms/input-appearance-height.html fast/forms/search/search-size-with-decorations.html
Created attachment 303553 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 303543 [details] Patch Attachment 303543 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3254247 New failing tests: fast/forms/search-vertical-alignment.html fast/forms/searchfield-heights.html
Created attachment 303556 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 303561 [details] Patch
Landed in r213480.
Apart from other stuff this was porting two CSS Grid Layout patches from Blink: * "normal" is "start" for replaced grid items (bug #169198): https://chromium.googlesource.com/chromium/src/+/fad39c71033eea490d8437ca186529c8e87125c2 * Use transferred size to calculate the minimum size of grid items (bug #169197): https://chromium.googlesource.com/chromium/src/+/ab779b340b6d4170920e1cf2ce50e67f64d67fac The first thing is mentioned on the ChangeLog but, sadly, the 2nd one is not. Also as part of these changes some Grid Layout tests are passing, I'm removing them from TestExpectations file in bug #169270. I'm not sure if these Grid Layout changes were actually needed to fix this bug, in any case I believe they could be done in separated patches. PS: Again the Grid Layout watchlist seems to be failing, I don't know why.