Bug 169270 - [css-grid] Mark a few tests from the W3C suite as pass after r213480
Summary: [css-grid] Mark a few tests from the W3C suite as pass after r213480
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-07 03:30 PST by Manuel Rego Casasnovas
Modified: 2017-03-07 05:05 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.13 KB, patch)
2017-03-07 03:31 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1011.76 KB, application/zip)
2017-03-07 04:34 PST, Build Bot
no flags Details
Patch (2.45 KB, patch)
2017-03-07 04:36 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2017-03-07 03:30:09 PST
r213480 was porting some Blink patches that makes these tests to pass now.
Check the following bugs for more information:
- https://bugs.webkit.org/show_bug.cgi?id=169197
- https://bugs.webkit.org/show_bug.cgi?id=169198
Comment 1 Manuel Rego Casasnovas 2017-03-07 03:31:11 PST
Created attachment 303639 [details]
Patch
Comment 2 Build Bot 2017-03-07 04:34:21 PST
Comment on attachment 303639 [details]
Patch

Attachment 303639 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3258343

New failing tests:
imported/w3c/csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001.html
Comment 3 Build Bot 2017-03-07 04:34:25 PST
Created attachment 303642 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Manuel Rego Casasnovas 2017-03-07 04:36:13 PST
Created attachment 303643 [details]
Patch
Comment 5 Manuel Rego Casasnovas 2017-03-07 04:37:18 PST
Comment on attachment 303643 [details]
Patch


imported/w3c/csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-001.html was still failing, but not for a different problem (see bug #169271).
Comment 6 Manuel Rego Casasnovas 2017-03-07 05:02:35 PST
(In reply to comment #5)
> Comment on attachment 303643 [details]
> Patch
> 
> 
> imported/w3c/csswg-test/css-grid-1/grid-items/grid-items-sizing-alignment-
> 001.html was still failing, but not for a different problem (see bug
> #169271).

There's a typo in the previous sentence: "but NOW for a different problem (see bug #169271)."
Comment 7 WebKit Commit Bot 2017-03-07 05:05:54 PST
Comment on attachment 303643 [details]
Patch

Clearing flags on attachment: 303643

Committed r213511: <http://trac.webkit.org/changeset/213511>
Comment 8 WebKit Commit Bot 2017-03-07 05:05:58 PST
All reviewed patches have been landed.  Closing bug.