Bug 168693 - Make sampling algorithm more stable and introduce an abstraction for sampled data
Summary: Make sampling algorithm more stable and introduce an abstraction for sampled ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 168813 168863
  Show dependency tree / graph
 
Reported: 2017-02-21 16:39 PST by Ryosuke Niwa
Modified: 2017-02-24 21:15 PST (History)
8 users (show)

See Also:

Attachments
Patch (45.89 KB, patch)
2017-02-21 17:21 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Removed one more unused function (45.70 KB, patch)
2017-02-21 20:15 PST, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-02-21 16:39:20 PST 
Make the sampling algorithm used in TimeSeriesChart a lot simpler and stable
so that changing the window size doesn't result in some points pop up & disappear.

With new algorithm which filters data points based on purely time interval, the sampling is always stable.
Widening the width of a chart always results in more data points to appear
but not hide existing data points.

Also introduce an abstraction to represent the sampled time series data
so that adding the ability to select baseline, etc... would be easier.
Comment 1 Ryosuke Niwa 2017-02-21 17:21:22 PST 
Created attachment 302346 [details]
Patch
Comment 2 Ryosuke Niwa 2017-02-21 20:15:21 PST 
Created attachment 302361 [details]
Removed one more unused function
Comment 3 Ryosuke Niwa 2017-02-22 14:09:25 PST 
Committed r212853: <http://trac.webkit.org/changeset/212853>