Bug 168813 - New sampling algorithm shows very few points when zoomed out
Summary: New sampling algorithm shows very few points when zoomed out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 168693
Blocks:
  Show dependency tree / graph
 
Reported: 2017-02-23 18:12 PST by Ryosuke Niwa
Modified: 2017-02-23 22:58 PST (History)
5 users (show)

See Also:

Attachments
Fixes the bug (13.63 KB, patch)
2017-02-23 20:37 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixes the bug (15.98 KB, patch)
2017-02-23 22:43 PST, Ryosuke Niwa 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-02-23 18:12:32 PST 
Turns out the new sampling algorithm introduced in https://trac.webkit.org/changeset/212853
can hide vast majority of points when zoomed out to a large time range
because then almost all points are fall below the threshold.
Comment 1 Ryosuke Niwa 2017-02-23 20:37:32 PST 
Created attachment 302634 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2017-02-23 21:23:19 PST 
Comment on attachment 302634 [details]
Fixes the bug

Nope, this still has a pathology where if the graph becomes more dense because bots become healthier, cycle time improved, etc... then we can simply drop an entire section of data points :(
Comment 3 Ryosuke Niwa 2017-02-23 22:43:55 PST 
Created attachment 302645 [details]
Fixes the bug
Comment 4 Saam Barati 2017-02-23 22:55:14 PST 
Comment on attachment 302645 [details]
Fixes the bug

r=me
Comment 5 Ryosuke Niwa 2017-02-23 22:58:52 PST 
Committed r212946: <http://trac.webkit.org/changeset/212946>