Bug 168863 - REGRESSION(r212853): Comparisons to baseline no longer shows up
Summary: REGRESSION(r212853): Comparisons to baseline no longer shows up
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 168693
Blocks:
  Show dependency treegraph
 
Reported: 2017-02-24 20:54 PST by Ryosuke Niwa
Modified: 2017-02-25 00:03 PST (History)
5 users (show)

See Also:


Attachments
Fixes the bug (38.04 KB, patch)
2017-02-24 21:14 PST, Ryosuke Niwa
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-02-24 20:54:16 PST
After https://trac.webkit.org/changeset/212853, we no longer see comparisons to baseline/target.
Comment 1 Ryosuke Niwa 2017-02-24 21:14:50 PST
Created attachment 302732 [details]
Fixes the bug
Comment 2 Joseph Pecoraro 2017-02-24 21:23:38 PST
Comment on attachment 302732 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=302732&action=review

rs=me

> Websites/perf.webkit.org/browser-tests/time-series-chart-tests.js:1
> +(() => {

Is this scoping necessary?

> Websites/perf.webkit.org/public/v3/components/chart-status-view.js:118
>          }

Style: You normally use semicolons.
Comment 3 Ryosuke Niwa 2017-02-25 00:01:42 PST
(In reply to comment #2)
> Comment on attachment 302732 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302732&action=review
> 
> rs=me
> 
> > Websites/perf.webkit.org/browser-tests/time-series-chart-tests.js:1
> > +(() => {
> 
> Is this scoping necessary?

Yeah, it was a bunch of functions & variables to the global scope because it's loaded in the browser.

> > Websites/perf.webkit.org/public/v3/components/chart-status-view.js:118
> >          }
> 
> Style: You normally use semicolons.

Oops, fixed.

Thanks for the review!
Comment 4 Ryosuke Niwa 2017-02-25 00:03:51 PST
Committed r212997: <http://trac.webkit.org/changeset/212997>