RESOLVED FIXED 168863
REGRESSION(r212853): Comparisons to baseline no longer shows up 
https://bugs.webkit.org/show_bug.cgi?id=168863
Summary REGRESSION(r212853): Comparisons to baseline no longer shows up
Ryosuke Niwa
Reported 2017-02-24 20:54:16 PST
After https://trac.webkit.org/changeset/212853, we no longer see comparisons to baseline/target.
Attachments
Fixes the bug (38.04 KB, patch)
2017-02-24 21:14 PST, Ryosuke Niwa 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-02-24 21:14:50 PST
Created attachment 302732 [details] Fixes the bug
Joseph Pecoraro
Comment 2 2017-02-24 21:23:38 PST
Comment on attachment 302732 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=302732&action=review rs=me > Websites/perf.webkit.org/browser-tests/time-series-chart-tests.js:1 > +(() => { Is this scoping necessary? > Websites/perf.webkit.org/public/v3/components/chart-status-view.js:118 > } Style: You normally use semicolons.
Ryosuke Niwa
Comment 3 2017-02-25 00:01:42 PST
(In reply to comment #2) > Comment on attachment 302732 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302732&action=review > > rs=me > > > Websites/perf.webkit.org/browser-tests/time-series-chart-tests.js:1 > > +(() => { > > Is this scoping necessary? Yeah, it was a bunch of functions & variables to the global scope because it's loaded in the browser. > > Websites/perf.webkit.org/public/v3/components/chart-status-view.js:118 > > } > > Style: You normally use semicolons. Oops, fixed. Thanks for the review!
Ryosuke Niwa
Comment 4 2017-02-25 00:03:51 PST
Committed r212997: <http://trac.webkit.org/changeset/212997>
Note You need to log in before you can comment on or make changes to this bug.