WKContentObservation.h contains several methods which are used only in WebCore (and need not be exported). However WKContentObservation.h is a private header (not project header). We should move all these methods to a separate header file which would be project header.
Created attachment 300920 [details] Proposed patch
Attachment 300920 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/wak/WKContentObservationInternal.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Only the WKContentChange enum definition needs to be in WebKit SPI headers. I think that as next step, we should move everything else to the Internal header too, and we should make it a private header for WebCore then.
Comment on attachment 300920 [details] Proposed patch Clearing flags on attachment: 300920 Committed r211889: <http://trac.webkit.org/changeset/211889>
All reviewed patches have been landed. Closing bug.
Comment on attachment 300920 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=300920&action=review > Source/WebCore/page/DOMTimer.cpp:50 > #include "WKContentObservation.h" > +#include "WKContentObservationInternal.h" We normally include only the internal header, because it includes the private and public headers as needed.