Bug 167996 - Move private methods from WKGraphics.h to a separate header file
Summary: Move private methods from WKGraphics.h to a separate header file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-08 08:36 PST by Aakash Jain
Modified: 2017-02-08 13:59 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (8.31 KB, patch)
2017-02-08 08:48 PST, Aakash Jain 		ap: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Updated patch (8.26 KB, patch)
2017-02-08 13:23 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-02-08 08:36:39 PST 
WKGraphics.h contains several methods which are used only in WebCore (and need not be exported). However WKGraphics.h is a private header (not project header). We should move all these methods to a separate header file which would be project header.
Comment 1 Aakash Jain 2017-02-08 08:48:51 PST 
Created attachment 300903 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2017-02-08 08:50:47 PST 
Attachment 300903 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/wak/WKGraphicsInternal.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/ios/wak/WKGraphicsInternal.h:41:  The parameter name "imageRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKGraphicsInternal.h:42:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKGraphicsInternal.h:42:  The parameter name "pattern" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2017-02-08 09:17:43 PST 
Comment on attachment 300903 [details]
Proposed patch

r=me pending EWS.

Looking at this code makes me wonder if there is a better place for it. We may even already have duplicate implementations.
Comment 4 Simon Fraser (smfr) 2017-02-08 09:30:34 PST 
WKGraphics is historical junk and we should try to remove as much as possible.
Comment 5 WebKit Commit Bot 2017-02-08 11:48:51 PST 
Comment on attachment 300903 [details]
Proposed patch

Rejecting attachment 300903 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 300903, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm
patching file Source/WebCore/platform/ios/wak/WKGraphics.h
patching file Source/WebCore/platform/ios/wak/WKGraphics.mm
patching file Source/WebCore/platform/ios/wak/WKGraphicsInternal.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3026543
Comment 6 Aakash Jain 2017-02-08 13:23:06 PST 
Created attachment 300950 [details]
Updated patch
Comment 7 WebKit Commit Bot 2017-02-08 13:59:54 PST 
Comment on attachment 300950 [details]
Updated patch

Clearing flags on attachment: 300950

Committed r211899: <http://trac.webkit.org/changeset/211899>
Comment 8 WebKit Commit Bot 2017-02-08 13:59:59 PST 
All reviewed patches have been landed.  Closing bug.