Bug 167996 – Move private methods from WKGraphics.h to a separate header file

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Aakash Jain]

WKGraphics.h contains several methods which are used only in WebCore (and need not be exported). However WKGraphics.h is a private header (not project header). We should move all these methods to a separate header file which would be project header.

[Aakash Jain]

Created attachment 300903 [details]
Proposed patch

[WebKit Commit Bot]

Attachment 300903 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/wak/WKGraphicsInternal.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/ios/wak/WKGraphicsInternal.h:41:  The parameter name "imageRef" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKGraphicsInternal.h:42:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKGraphicsInternal.h:42:  The parameter name "pattern" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Comment on attachment 300903 [details]
Proposed patch

r=me pending EWS.

Looking at this code makes me wonder if there is a better place for it. We may even already have duplicate implementations.

[Simon Fraser (smfr)]

WKGraphics is historical junk and we should try to remove as much as possible.

[WebKit Commit Bot]

Comment on attachment 300903 [details]
Proposed patch

Rejecting attachment 300903 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 300903, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
- saving rejects to file Source/WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file Source/WebCore/platform/graphics/mac/GraphicsContextMac.mm
patching file Source/WebCore/platform/ios/wak/WKGraphics.h
patching file Source/WebCore/platform/ios/wak/WKGraphics.mm
patching file Source/WebCore/platform/ios/wak/WKGraphicsInternal.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alexey Proskuryakov']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3026543

[Aakash Jain]

Created attachment 300950 [details]
Updated patch

[WebKit Commit Bot]

Comment on attachment 300950 [details]
Updated patch

Clearing flags on attachment: 300950

Committed r211899: <http://trac.webkit.org/changeset/211899>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.