Bug 167977 – Don't re-export WKUtilities.h from WebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Aakash Jain]

WKUtilities.h contains several methods which are used only in WebCore (and need not be exported). However WKUtilities.h is a private header (not project header). We should move all these methods to a separate header file which would be project header.

[Aakash Jain]

Created attachment 300877 [details]
Proposed patch

[WebKit Commit Bot]

Attachment 300877 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/ios/wak/WKUtilitiesPrivate.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebCore/platform/ios/wak/WKUtilitiesPrivate.h:42:  The parameter name "size" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKUtilitiesPrivate.h:42:  The parameter name "info" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKUtilitiesPrivate.h:43:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKUtilitiesPrivate.h:44:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKUtilitiesPrivate.h:46:  The parameter name "allocator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKUtilitiesPrivate.h:47:  The parameter name "allocator" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKUtilitiesPrivate.h:52:  The parameter name "array" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/ios/wak/WKUtilitiesPrivate.h:54:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 9 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Comment on attachment 300877 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300877&action=review

> Source/WebCore/ChangeLog:8
> +        * WebCore.xcodeproj/project.pbxproj: Added WKUtilitiesPrivate.h

The correct name for the new file is WKUtilitiesInternal.h. However, it's still not clear to me if anything from this header is needed as SPI.

[Alexey Proskuryakov]

Aakash and I looked into this. We just don't need to migrate this header in WebKit at all, as it's only used in WebKit via WKView.h, which is not migrated.

[Aakash Jain]

Created attachment 300952 [details]
Updated patch

[WebKit Commit Bot]

Comment on attachment 300952 [details]
Updated patch

Clearing flags on attachment: 300952

Committed r211901: <http://trac.webkit.org/changeset/211901>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.