Bug 166484 - Add the support for ShadowRoot.delegateFocus
Summary: Add the support for ShadowRoot.delegateFocus
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Macintosh macOS 10.12
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2016-12-26 14:17 PST by Damiaan Dufaux
Modified: 2019-08-16 09:44 PDT (History)
6 users (show)

See Also:


Attachments
A web page to reproduce the problem (565 bytes, text/html)
2016-12-26 14:17 PST, Damiaan Dufaux
no flags Details
WIP (53.08 KB, patch)
2019-08-14 00:14 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Damiaan Dufaux 2016-12-26 14:17:13 PST
Created attachment 297772 [details]
A web page to reproduce the problem

Overview: As specified in the shadow dom specification (http://w3c.github.io/webcomponents/spec/shadow/#focus): "A shadow host can delegate focus to its shadow root by assigning a boolean delegatesFocus flag to be true in ShadowRootInit dictionary". But this feature is not working.

Steps to Reproduce:
 - open the attached file (delegateFocus.html) in the latest nightly build
 - click on the text "Hello world"

Actual Results: nothing happens

Expected Results: The input field should receive focus.

Build date: December 20, 2016 5:14 PM GMT
Platform: macOS Sierra 10.12.2 (16C67)
Comment 1 Radar WebKit Bug Importer 2016-12-27 15:39:54 PST
<rdar://problem/29816058>
Comment 2 Ryosuke Niwa 2019-08-14 00:14:07 PDT
Created attachment 376241 [details]
WIP
Comment 3 Build Bot 2019-08-14 00:15:38 PDT
Attachment 376241 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Element.cpp:2837:  'newTarget' is incorrectly named. It should be named 'protectedThis'.  [readability/naming/protected] [4]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.