Bug 202497 - Resync WPT shadow DOM tests
Summary: Resync WPT shadow DOM tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 166484
  Show dependency tree / graph
 
Reported: 2019-10-02 15:30 PDT by Ryosuke Niwa
Modified: 2019-10-03 19:01 PDT (History)
6 users (show)

See Also:

Attachments
Resynced tests (84.14 KB, patch)
2019-10-02 15:33 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (86.99 KB, patch)
2019-10-02 21:28 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-10-02 15:30:47 PDT 
Update the tests.
Comment 1 Ryosuke Niwa 2019-10-02 15:33:32 PDT 
Created attachment 380067 [details]
Resynced tests
Comment 2 Ryosuke Niwa 2019-10-02 15:35:51 PDT 
Note: this patch takes https://github.com/web-platform-tests/wpt/pull/19479 into account.
Comment 3 Sam Weinig 2019-10-02 15:37:19 PDT 
Comment on attachment 380067 [details]
Resynced tests

rs=me
Comment 4 Ryosuke Niwa 2019-10-02 15:39:42 PDT 
Thanks!
Comment 5 Ryosuke Niwa 2019-10-02 21:28:36 PDT 
Created attachment 380079 [details]
Patch for landing
Comment 6 Ryosuke Niwa 2019-10-02 21:29:29 PDT 
Comment on attachment 380079 [details]
Patch for landing

Wait for EWS.
Comment 7 Ryosuke Niwa 2019-10-02 21:30:29 PDT 
Apparently sending tab key via UIController doesn't move the focus forward on iOS. There are tests with form controls where it seems to be working so it's rather mysterious. It probably needs to be investigated in another bug as there are other tests that are currently skipped on iOS for similar reasons.
Comment 8 Ryosuke Niwa 2019-10-03 16:53:44 PDT 
Hm... I can't reproduce the test failure of imported/w3c/web-platform-tests/mathml/relations/html5-tree/tabindex-002.html on macOS Mojave. Maybe it's high Sierra only?? That's weird though...
Comment 9 Ryosuke Niwa 2019-10-03 16:56:07 PDT 
This is so frustrating. I've been trying to land this patch for the last three days :(
Comment 10 Ryosuke Niwa 2019-10-03 19:00:15 PDT 
Committed r250696: <https://trac.webkit.org/changeset/250696>
Comment 11 Radar WebKit Bug Importer 2019-10-03 19:01:17 PDT 
<rdar://problem/55970683>