Bug 203869 - Focusing a shadow host which delegates focus should skip inner shadow hosts which delegate focus
Summary: Focusing a shadow host which delegates focus should skip inner shadow hosts w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 148695
  Show dependency tree / graph
 
Reported: 2019-11-05 16:15 PST by Ryosuke Niwa
Modified: 2019-11-18 12:57 PST (History)
11 users (show)

See Also:

Attachments
WIP (6.00 KB, patch)
2019-11-05 16:17 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixes the bug (8.14 KB, patch)
2019-11-15 19:23 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews210 for win-future (15.41 MB, application/zip)
2019-11-15 21:19 PST, EWS Watchlist 		no flags Details
Fixed the tests (8.65 KB, patch)
2019-11-15 23:47 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews211 for win-future (14.16 MB, application/zip)
2019-11-16 02:24 PST, EWS Watchlist 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-11-05 16:15:24 PST 
Per https://github.com/whatwg/html/issues/5052, correct our implementation.
Comment 1 Ryosuke Niwa 2019-11-05 16:17:47 PST 
Created attachment 382859 [details]
WIP
Comment 2 Ryosuke Niwa 2019-11-05 16:17:59 PST 
Waiting for https://github.com/web-platform-tests/wpt/pull/20079 to be corrected & merged.
Comment 3 Ryosuke Niwa 2019-11-15 19:23:18 PST 
Created attachment 383682 [details]
Fixes the bug
Comment 4 EWS Watchlist 2019-11-15 21:19:50 PST 
Comment on attachment 383682 [details]
Fixes the bug

Attachment 383682 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13259922

New failing tests:
fast/forms/fieldset/fieldset-disabled.html
fast/forms/input-appearance-disabled.html
fast/selectors/focus-within-style-update.html
fast/selectors/focus-within-with-selector-checker.html
fast/forms/input-no-renderer.html
Comment 5 EWS Watchlist 2019-11-15 21:19:52 PST 
Created attachment 383687 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 Ryosuke Niwa 2019-11-15 23:47:35 PST 
Created attachment 383693 [details]
Fixed the tests
Comment 7 EWS Watchlist 2019-11-16 02:24:41 PST 
Comment on attachment 383693 [details]
Fixed the tests

Attachment 383693 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13260287

New failing tests:
fast/repaint/backgroundSizeRepaint.html
Comment 8 EWS Watchlist 2019-11-16 02:24:43 PST 
Created attachment 383694 [details]
Archive of layout-test-results from ews211 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews211  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 9 Ryosuke Niwa 2019-11-17 21:31:59 PST 
(In reply to Build Bot from comment #7)
> Comment on attachment 383693 [details]
> Fixed the tests
> 
> Attachment 383693 [details] did not pass win-ews (win):
> Output: https://webkit-queues.webkit.org/results/13260287
> 
> New failing tests:
> fast/repaint/backgroundSizeRepaint.html

Don't think this Windows test failure is related to this patch.

Also, Mac debug WK1 failures are to do with page cache code, and they have been crashing on bots as well. Not sure why EWS thought it was caused by this patch.
Comment 10 WebKit Commit Bot 2019-11-17 22:27:16 PST 
Comment on attachment 383693 [details]
Fixed the tests

Clearing flags on attachment: 383693

Committed r252537: <https://trac.webkit.org/changeset/252537>
Comment 11 WebKit Commit Bot 2019-11-17 22:27:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-11-17 22:28:26 PST 
<rdar://problem/57272509>